bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Stanislav Fomichev <sdf@google.com>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf] bpf: support pre-2.25-binutils objcopy for vmlinux BTF
Date: Tue, 26 Nov 2019 14:30:31 -0800	[thread overview]
Message-ID: <CAEf4BzZ+e4vnW7Gconhq3AJ5od=TULAZC=-+UANFDGXcWCoOSA@mail.gmail.com> (raw)
In-Reply-To: <20191126174221.200522-1-sdf@google.com>

On Tue, Nov 26, 2019 at 9:56 AM Stanislav Fomichev <sdf@google.com> wrote:
>
> If vmlinux BTF generation fails, but CONFIG_DEBUG_INFO_BTF is set,
> .BTF section of vmlinux is empty and kernel will prohibit
> BPF loading and return "in-kernel BTF is malformed".
>
> --dump-section argument to binutils' objcopy was added in version 2.25.
> When using pre-2.25 binutils, BTF generation silently fails. Convert
> to --only-section which is present on pre-2.25 binutils.
>
> Documentation/process/changes.rst states that binutils 2.21+
> is supported, not sure those standards apply to BPF subsystem.
>
> Fixes: 341dfcf8d78ea ("btf: expose BTF info through sysfs")
> Signed-off-by: Stanislav Fomichev <sdf@google.com>
> ---

Looks good, still works for me :)

Tested-by: Andrii Nakryiko <andriin@fb.com>

>  scripts/link-vmlinux.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/link-vmlinux.sh b/scripts/link-vmlinux.sh
> index 06495379fcd8..c56ba91f52b0 100755
> --- a/scripts/link-vmlinux.sh
> +++ b/scripts/link-vmlinux.sh
> @@ -127,7 +127,8 @@ gen_btf()
>                 cut -d, -f1 | cut -d' ' -f2)
>         bin_format=$(LANG=C ${OBJDUMP} -f ${1} | grep 'file format' | \
>                 awk '{print $4}')
> -       ${OBJCOPY} --dump-section .BTF=.btf.vmlinux.bin ${1} 2>/dev/null
> +       ${OBJCOPY} --set-section-flags .BTF=alloc -O binary \
> +               --only-section=.BTF ${1} .btf.vmlinux.bin 2>/dev/null
>         ${OBJCOPY} -I binary -O ${bin_format} -B ${bin_arch} \
>                 --rename-section .data=.BTF .btf.vmlinux.bin ${2}
>  }
> --
> 2.24.0.432.g9d3f5f5b63-goog
>

  reply	other threads:[~2019-11-26 22:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26 17:42 [PATCH bpf] bpf: support pre-2.25-binutils objcopy for vmlinux BTF Stanislav Fomichev
2019-11-26 22:30 ` Andrii Nakryiko [this message]
2019-11-26 22:37 ` John Fastabend
2019-11-26 22:47   ` Stanislav Fomichev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzZ+e4vnW7Gconhq3AJ5od=TULAZC=-+UANFDGXcWCoOSA@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).