From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78141C32750 for ; Tue, 13 Aug 2019 23:38:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3E0502054F for ; Tue, 13 Aug 2019 23:38:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L8NaXcnZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726231AbfHMXiZ (ORCPT ); Tue, 13 Aug 2019 19:38:25 -0400 Received: from mail-qt1-f196.google.com ([209.85.160.196]:32994 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726102AbfHMXiZ (ORCPT ); Tue, 13 Aug 2019 19:38:25 -0400 Received: by mail-qt1-f196.google.com with SMTP id v38so15881221qtb.0; Tue, 13 Aug 2019 16:38:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5VALDoEQf5ycz8FvNAJ3LejkjVDYOhmuS9Gj/GkPw3o=; b=L8NaXcnZszHCR5swq/jeZgG9+LgXkXjr5vp5FI6+CmzaiGkc9mEYgSUN2+girqWBfS N9fRsXuBX1Bj4TmlnESNCBdrMZjNC+2y57OhTMwG29lPxPBiV+u4IoPNd58aAZmv46M2 nClDdbRRGV9oSSZFRZOd7HjJ6P9mWv3U9xUJaN/6J2RiToYSoN38TJ3kK6qZBIZbSvMu dXCo6a32kuxP7LoIFdynydFUkM5fl9fX/OYm8ZKcH9Gc6Z5b0m2pgANrAUBM8xTjGYAH 7lVK006xQbSMnmgLLk/zTUsLLwipeQzzAygqgMPC4hFtf+gaZWuw2SGlF8EPx4Kyuld2 iG+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5VALDoEQf5ycz8FvNAJ3LejkjVDYOhmuS9Gj/GkPw3o=; b=mo+JmOrx9rYcuZ1FEpbUB+l0TA6LsCuaqKGpE/WeaRrqgIhO63UO0NJ9j19zaJbEMU C2M5vGRk218a5PdRVOjbq0Q47RYPEM7R/fL5wpb74FVJF8evJRJx25lgOYWSDKDzE27s HgEVz56T1CWL/UESrIwMKNYc0191DklhMuXs81LwTzXfrtSGgzgJOhAk313iNQSFt/J4 sNCk/1ujjasbwZXSydR0W8RaaKc64ltfoHPRojA8M96SdVdtI/+Y/Hu3cw5eldyTG3g9 Xq5wf6ynPvG8HN2i0aiR6G1PtIypIFHZP5CkTHf0tW57WPEXGEddAt7KOzRBpvgVaeUV AYsw== X-Gm-Message-State: APjAAAWXVOkQn+AWTBkBzZbcj7nnFKiOwdqf6GLVt12MNRozrxoYpXg6 rlZpQ8BECXHBjnxpLEfoMvOGH9tPvQL8+qIRjaU= X-Google-Smtp-Source: APXvYqyCeaZb5/L5tcoh0D1rc5SJBaOdSZCtPAgTtPVTXyCLT7/j8QVo2aQrKHtr2cMwuVGfFKsRk9xnszjWggzRKBU= X-Received: by 2002:ad4:56a2:: with SMTP id bd2mr559803qvb.162.1565739504161; Tue, 13 Aug 2019 16:38:24 -0700 (PDT) MIME-Version: 1.0 References: <20190813102318.5521-1-ivan.khoronzhuk@linaro.org> <20190813102318.5521-2-ivan.khoronzhuk@linaro.org> In-Reply-To: <20190813102318.5521-2-ivan.khoronzhuk@linaro.org> From: Andrii Nakryiko Date: Tue, 13 Aug 2019 16:38:13 -0700 Message-ID: Subject: Re: [PATCH bpf-next 1/3] libbpf: add asm/unistd.h to xsk to get __NR_mmap2 To: Ivan Khoronzhuk Cc: Magnus Karlsson , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , "David S. Miller" , Jesper Dangaard Brouer , john fastabend , Jakub Kicinski , Daniel Borkmann , Networking , bpf , xdp-newbies@vger.kernel.org, open list Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Aug 13, 2019 at 3:24 AM Ivan Khoronzhuk wrote: > > That's needed to get __NR_mmap2 when mmap2 syscall is used. > > Signed-off-by: Ivan Khoronzhuk > --- > tools/lib/bpf/xsk.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c > index 5007b5d4fd2c..f2fc40f9804c 100644 > --- a/tools/lib/bpf/xsk.c > +++ b/tools/lib/bpf/xsk.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include asm/unistd.h is not present in Github libbpf projection. Is there any way to avoid including this header? Generally, libbpf can't easily use all of kernel headers, we need to re-implemented all the extra used stuff for Github version of libbpf, so we try to minimize usage of new headers that are not just plain uapi headers from include/uapi. > #include > #include > #include > -- > 2.17.1 >