From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26DB9C388F9 for ; Fri, 23 Oct 2020 20:27:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B4E6520897 for ; Fri, 23 Oct 2020 20:27:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W2kEhKQ/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756033AbgJWU1y (ORCPT ); Fri, 23 Oct 2020 16:27:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756082AbgJWU1x (ORCPT ); Fri, 23 Oct 2020 16:27:53 -0400 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9653CC0613CE for ; Fri, 23 Oct 2020 13:27:53 -0700 (PDT) Received: by mail-yb1-xb41.google.com with SMTP id c3so2248698ybl.0 for ; Fri, 23 Oct 2020 13:27:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HFXm37Qr5xXi36i8NUhvr6aKhojTpRtpohdMplDqryw=; b=W2kEhKQ/kBhsqERVmQrIizVahLcu+yz0wJ3dmoSn5SPZfmrHxQ8qcyoD9CdpwQc/H/ Y69GMMtU5efOkU/72dTXoUE7zdRKcZTCYOlHfTIxtB9AbzwLuVOYrtwDiRUZrhEK3dBf g/a++UQMdLADO5dGP1xSIN+oBTW6E1axOrPgZmZXnBY3QNpfkpxsLWHYaDEQ+7Dzp17M zyr7AYCEUE9QdAJdy7i2wVqzj9Ez+PNKHpP1QGpcOGl3rXK7ilF4ONaWazuIM7e1l0u2 3I8v+ypzcay/EbtPfFicFHnZ5j39wueSasK5xKFXdQ+NU8EChXQirEJSR48sOMymmvn2 SJvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HFXm37Qr5xXi36i8NUhvr6aKhojTpRtpohdMplDqryw=; b=M23Jj1/sthACSzLPZyHZIs7bswBR9jp6JcF6SouykaO63mnwX2A5kTuolv03JPl/Uz oVoxRCyiddl6q2aYu1YsYhqRudG5MwG8rYCtS8IZPGYacJGxw4PGt19fMkAdyhidzN7T oDuANeooE7iKNzIjpM1c7vZPWzM15toDZqYYNkG44gGXE1D0HD9OnU+H5t9p5bjQXw9C ek6b+LQjChzthl6nDVDGJSftWC2oUsHna54vNY/oxlrVRMZEyzohSOC9WTr8f7oGQwqA lV0xXj1NNBcIRUi1OOawHkXBBU9u15PCk9glkclf09MWzbTz1UEdJb3NQqHTW5Y6P8ke +ZBg== X-Gm-Message-State: AOAM531mxI79oIYdmc9rtpkP4AwsuI+sK1VR89QIsEUyXWpFB7xjMXOQ mhICTwMcmCoXYqqSCELSy5ZxdURFqZTVGW0e4LE= X-Google-Smtp-Source: ABdhPJzxOAUST4a6puV252W2th1Q5oaPSKJJN0h9vPNBpU3fxEI9vryxrbiXqQRtQleJbbhR9zvl2sKAvubctwU8LKU= X-Received: by 2002:a25:da4e:: with SMTP id n75mr5897854ybf.425.1603484872899; Fri, 23 Oct 2020 13:27:52 -0700 (PDT) MIME-Version: 1.0 References: <20200922190234.224161-1-dev@der-flo.net> <20201013144515.298647-1-dev@der-flo.net> <5f87ce648edd5_b7602085a@john-XPS-13-9370.notmuch> <20201023163518.GA4777@der-flo.net> In-Reply-To: <20201023163518.GA4777@der-flo.net> From: Andrii Nakryiko Date: Fri, 23 Oct 2020 13:27:42 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2] bpf: Lift hashtab key_size limit To: Florian Lehner Cc: John Fastabend , Alexei Starovoitov , Daniel Borkmann , bpf Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Fri, Oct 23, 2020 at 9:38 AM Florian Lehner wrote: > > On Wed, Oct 14, 2020 at 09:21:56PM -0700, John Fastabend wrote: > > > > OK the check appears unnecessary. It seems a bit excessive to have > > such large keys though. > > > > Daniel, Alexei I couldn't find this patch in patchworks, not sure > > where it went. > > > > Acked-by: John Fastabend > > Is there something left I have missed to address? > Or should I rebase the patch and send it in again? Yeah, please rebase and resubmit. There were some problems with patchworks and a bunch of patches didn't make it to the system. Yours might have been one of them. > > Thanks, > Florian