From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E838C4360C for ; Mon, 7 Oct 2019 00:13:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 465922084B for ; Mon, 7 Oct 2019 00:13:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="jUUDWa0P" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726307AbfJGANa (ORCPT ); Sun, 6 Oct 2019 20:13:30 -0400 Received: from mail-qt1-f195.google.com ([209.85.160.195]:45466 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726266AbfJGANa (ORCPT ); Sun, 6 Oct 2019 20:13:30 -0400 Received: by mail-qt1-f195.google.com with SMTP id c21so16777612qtj.12; Sun, 06 Oct 2019 17:13:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IsIVE2IZg7zRoFf75XZATurzX1xHvEfb7tRbjT/egVo=; b=jUUDWa0PhjuqHZ0R5C0SCIknQzlfJZ5X3rIhIp96goxlWNtKX8MqPKmYDqouYVtTSV vOpLJK/wmIGkVHjlzFyOMI6745+PT5XycfUiX/5K4NRRZABM7c9XQ9J1NMZ1FOQnLYuK 0HP4HpkB7+xxd44RDRH9GGuTuPmggFldJEXbqSl/D0mXNMNAkst2UEjKio7hYS/GNXUj /rd7XB4BZARwLgMfcGiTwTZYjjmBroW28sgeFlaxvZ4wkSZqYFhhwcXLA8FrAF1b64go ic8GIqFdW0msbykiz9bBYgUnKO13PC8gFBh8zc5tPmutIM9RtB0Y4KtfTkpA5WVn1/XN NZyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IsIVE2IZg7zRoFf75XZATurzX1xHvEfb7tRbjT/egVo=; b=SsuAvPUakfOPeE2KH9wQhELvutAd2LfcoyCpDtWPNgtXL4Cff/hOqxF7ptbGr5UuKN DceIo3nkCsQBKt9I4K+QhlUYMcioijx4Lfq6/+2HK4PRL2XcbTK06YrZbIG7wgLsRw2H 77auJXjbp3EK/1QI2AygZZG5K47M4TZEtfMEbIOQpbDv22tyL+x4ysn3kNufyrfId2x/ ishr9DOjpLhpC3Hzld+BEJoZ+bQ/BU2Z0yieUvy0se0v+mQlx9cojI3ld5vfVFsDFUd6 oDUtPQro1ii3bQSbLozIiksJZe792ff0l4eyKv7lIjCtuJiQuSI5073VYJnhJeXoGzjc 9Lsg== X-Gm-Message-State: APjAAAWbgP2uwxKn66z9GKG9xmoY2En2jP8EYzvqGb+o/us/2rss7bJt Vr3aX+jh7ocSFIMnTZ3oKD0E6wTRcDOVxSuSgazuypmF27k= X-Google-Smtp-Source: APXvYqzgCYdqVw+ejAOsu61I2hK3VR+yyvl6JewaYlYaau/2woilm5HNFKT07RvurwZwNkap3SgwiDUMBJKxkCuKNM8= X-Received: by 2002:a0c:ae9a:: with SMTP id j26mr3139484qvd.163.1570407209267; Sun, 06 Oct 2019 17:13:29 -0700 (PDT) MIME-Version: 1.0 References: <20191006054350.3014517-1-andriin@fb.com> <20191006054350.3014517-4-andriin@fb.com> In-Reply-To: From: Andrii Nakryiko Date: Sun, 6 Oct 2019 17:13:18 -0700 Message-ID: Subject: Re: [PATCH v3 bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions To: Alexei Starovoitov Cc: Andrii Nakryiko , bpf , Network Development , Alexei Starovoitov , Daniel Borkmann , Quentin Monnet , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, Oct 6, 2019 at 4:56 PM Alexei Starovoitov wrote: > > On Sat, Oct 5, 2019 at 10:46 PM Andrii Nakryiko wrote: > > > > Get rid of list of BPF helpers in bpf_helpers.h (irony...) and > > auto-generate it into bpf_helpers_defs.h, which is now included from > > bpf_helpers.h. > > > > Suggested-by: Alexei Starovoitov > > Signed-off-by: Andrii Nakryiko > > --- > > tools/lib/bpf/.gitignore | 1 + > > tools/lib/bpf/Makefile | 10 +- > > tools/lib/bpf/bpf_helpers.h | 264 +----------------------------------- > > 3 files changed, 10 insertions(+), 265 deletions(-) > > This patch doesn't apply to bpf-next. Yes, it has to be applied on top of bpf_helpers.h move patch set. I can bundle them together and re-submit as one patch set, but I don't think there were any remaining issues besides the one solved in this patch set (independence from any specific bpf.h UAPI), so that one can be applied as is.