From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Ilya Leoshkevich <iii@linux.ibm.com>
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>, bpf <bpf@vger.kernel.org>,
Heiko Carstens <hca@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>
Subject: Re: [PATCH bpf-next 0/3] core_reloc fixes for s390
Date: Fri, 22 Oct 2021 16:38:24 -0700 [thread overview]
Message-ID: <CAEf4BzZBTDpcbEzpm5v7GUE7z_bZ+Azxf-Gt3oqqKGWFRYQP-w@mail.gmail.com> (raw)
In-Reply-To: <20211021234653.643302-1-iii@linux.ibm.com>
On Thu, Oct 21, 2021 at 4:47 PM Ilya Leoshkevich <iii@linux.ibm.com> wrote:
>
> Hi,
>
> this series fixes test failures in core_reloc on s390.
>
> Patch 1 fixes a bug in byte order determination.
> Patch 2 fixes an endianness issue in bitfield relocation.
> Patch 3 fixes an endianness issue in test_core_reloc_mods.
>
This doesn't apply cleanly anymore. Please rebase and re-submit. You
mentioned that patch #2 is not necessary, so please drop it as well.
As for the patch #1, can you please split it into libbpf, selftests
and samples patches? Thanks.
> Best regards,
> Ilya
>
> Ilya Leoshkevich (3):
> bpf: Use __BYTE_ORDER__ everywhere
> libbpf: Fix relocating big-endian bitfields
> selftests/bpf: Fix test_core_reloc_mods on big-endian machines
>
> samples/seccomp/bpf-helper.h | 8 ++++----
> tools/lib/bpf/bpf_core_read.h | 2 +-
> tools/lib/bpf/btf.c | 4 ++--
> tools/lib/bpf/btf_dump.c | 8 ++++----
> tools/lib/bpf/libbpf.c | 4 ++--
> tools/lib/bpf/linker.c | 12 ++++++------
> tools/lib/bpf/relo_core.c | 13 +++++++++----
> .../testing/selftests/bpf/prog_tests/btf_endian.c | 6 +++---
> .../selftests/bpf/progs/test_core_reloc_mods.c | 9 +++++++++
> tools/testing/selftests/bpf/test_sysctl.c | 4 ++--
> tools/testing/selftests/bpf/verifier/ctx_skb.c | 14 +++++++-------
> tools/testing/selftests/bpf/verifier/lwt.c | 2 +-
> .../bpf/verifier/perf_event_sample_period.c | 6 +++---
> tools/testing/selftests/seccomp/seccomp_bpf.c | 6 +++---
> 14 files changed, 56 insertions(+), 42 deletions(-)
>
> --
> 2.31.1
>
prev parent reply other threads:[~2021-10-22 23:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 23:46 [PATCH bpf-next 0/3] core_reloc fixes for s390 Ilya Leoshkevich
2021-10-21 23:46 ` [PATCH bpf-next 1/3] bpf: Use __BYTE_ORDER__ everywhere Ilya Leoshkevich
2021-10-21 23:46 ` [PATCH bpf-next 2/3] libbpf: Fix relocating big-endian bitfields Ilya Leoshkevich
2021-10-22 10:24 ` Ilya Leoshkevich
2021-10-21 23:46 ` [PATCH bpf-next 3/3] selftests/bpf: Fix test_core_reloc_mods on big-endian machines Ilya Leoshkevich
2021-10-22 23:38 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzZBTDpcbEzpm5v7GUE7z_bZ+Azxf-Gt3oqqKGWFRYQP-w@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iii@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).