From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Andrii Nakryiko <andriin@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
Alexei Starovoitov <ast@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v3 bpf-next 7/7] selftest/bpf: remove test_libbpf.sh and test_libbpf_open
Date: Tue, 15 Oct 2019 22:53:02 -0700 [thread overview]
Message-ID: <CAEf4BzZDm5ZWhrtp0R78rEhaNYHjBCKgXdK3QXFzKrEqHMxx8Q@mail.gmail.com> (raw)
In-Reply-To: <20191016054945.1988387-8-andriin@fb.com>
On Tue, Oct 15, 2019 at 10:50 PM Andrii Nakryiko <andriin@fb.com> wrote:
>
> test_progs is much more sophisticated superset of tests compared to
> test_libbpf.sh and test_libbpf_open. Remove test_libbpf.sh and
> test_libbpf_open.
>
> Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> ---
> tools/testing/selftests/bpf/.gitignore | 2 -
> tools/testing/selftests/bpf/Makefile | 3 +-
> tools/testing/selftests/bpf/test_libbpf | Bin 0 -> 384568 bytes
> tools/testing/selftests/bpf/test_libbpf.sh | 43 -------------------
> tools/testing/selftests/bpf/test_libbpf_open | Bin 0 -> 396096 bytes
well this was certainly not intended, sorry about that
> 5 files changed, 1 insertion(+), 47 deletions(-)
> create mode 100755 tools/testing/selftests/bpf/test_libbpf
> delete mode 100755 tools/testing/selftests/bpf/test_libbpf.sh
> create mode 100755 tools/testing/selftests/bpf/test_libbpf_open
>
> diff --git a/tools/testing/selftests/bpf/.gitignore b/tools/testing/selftests/bpf/.gitignore
> index c51f356f84b5..55d2adf64832 100644
> --- a/tools/testing/selftests/bpf/.gitignore
> +++ b/tools/testing/selftests/bpf/.gitignore
> @@ -11,7 +11,6 @@ test_dev_cgroup
> test_tcpbpf_user
> test_verifier_log
> feature
> -test_libbpf_open
> test_sock
> test_sock_addr
> test_sock_fields
> @@ -30,7 +29,6 @@ flow_dissector_load
> test_netcnt
> test_section_names
> test_tcpnotify_user
> -test_libbpf
> test_tcp_check_syncookie_user
> test_sysctl
> libbpf.pc
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index db8c842ade73..9d7422a514c5 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -52,7 +52,6 @@ TEST_FILES =
>
> # Order correspond to 'make run_tests' order
> TEST_PROGS := test_kmod.sh \
> - test_libbpf.sh \
> test_xdp_redirect.sh \
> test_xdp_meta.sh \
> test_xdp_veth.sh \
> @@ -79,7 +78,7 @@ TEST_PROGS_EXTENDED := with_addr.sh \
> test_xdp_vlan.sh
>
> # Compile but not part of 'make run_tests'
> -TEST_GEN_PROGS_EXTENDED = test_libbpf_open test_sock_addr test_skb_cgroup_id_user \
> +TEST_GEN_PROGS_EXTENDED = test_sock_addr test_skb_cgroup_id_user \
> flow_dissector_load test_flow_dissector test_tcp_check_syncookie_user \
> test_lirc_mode2_user
>
> diff --git a/tools/testing/selftests/bpf/test_libbpf b/tools/testing/selftests/bpf/test_libbpf
> new file mode 100755
> index 0000000000000000000000000000000000000000..af5e18b8353486db7156dc81ac25b9eab3720370
> GIT binary patch
> literal 384568
> zcmd44e|%KM)jz%gB0<rOiW*z35w(I<8h>CxQ5R)(LDBdlidH3nASgd#ND!>iU`U(m
oops
prev parent reply other threads:[~2019-10-16 5:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 5:49 [PATCH v3 bpf-next 0/7] Fix, clean up, and revamp selftests/bpf Makefile Andrii Nakryiko
2019-10-16 5:49 ` [PATCH v3 bpf-next 1/7] selftests/bpf: teach test_progs to cd into subdir Andrii Nakryiko
2019-10-16 5:49 ` [PATCH v3 bpf-next 2/7] selftests/bpf: make CO-RE reloc test impartial to test_progs flavor Andrii Nakryiko
2019-10-16 5:49 ` [PATCH v3 bpf-next 3/7] selftests/bpf: switch test_maps to test_progs' test.h format Andrii Nakryiko
2019-10-16 5:49 ` [PATCH v3 bpf-next 4/7] selftests/bpf: add simple per-test targets to Makefile Andrii Nakryiko
2019-10-16 5:49 ` [PATCH v3 bpf-next 5/7] selftests/bpf: replace test_progs and test_maps w/ general rule Andrii Nakryiko
2019-10-16 5:49 ` [PATCH v3 bpf-next 6/7] selftests/bpf: move test_queue_stack_map.h into progs/ where it belongs Andrii Nakryiko
[not found] ` <20191016054945.1988387-8-andriin@fb.com>
2019-10-16 5:53 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzZDm5ZWhrtp0R78rEhaNYHjBCKgXdK3QXFzKrEqHMxx8Q@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).