From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Dave Marchevsky <davemarchevsky@fb.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 2/9] selftests/bpf: normalize SEC("classifier") usage
Date: Tue, 21 Sep 2021 16:10:58 -0700 [thread overview]
Message-ID: <CAEf4BzZZXZuHWqYpVRzPa8OPDMe50gmnM8c2kmshg7DCqw-MrQ@mail.gmail.com> (raw)
In-Reply-To: <f89e5325-0096-6239-98bf-0da6a489e3fd@fb.com>
On Mon, Sep 20, 2021 at 10:21 PM Dave Marchevsky <davemarchevsky@fb.com> wrote:
>
> On 9/20/21 7:43 PM, Andrii Nakryiko wrote:
> > Convert all SEC("classifier*") uses to strict SEC("classifier") with no
> > extra characters. In reference_tracking selftests also drop the usage of
> > broken bpf_program__load(). Along the way switch from ambiguous searching by
> > program title (section name) to non-ambiguous searching by name in some
> > selftests, getting closer to completely removing
> > bpf_object__find_program_by_title().
> >
> > Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
> > ---
>
> Looks like you feel similarly about the SEC("version") comment from patch 1.
>
> > .../bpf/prog_tests/reference_tracking.c | 22 ++++---
> > .../selftests/bpf/prog_tests/sk_assign.c | 2 +-
> > .../selftests/bpf/prog_tests/tailcalls.c | 58 +++++++++----------
> > .../testing/selftests/bpf/progs/skb_pkt_end.c | 2 +-
> > tools/testing/selftests/bpf/progs/tailcall1.c | 5 +-
> > tools/testing/selftests/bpf/progs/tailcall2.c | 21 ++++---
> > tools/testing/selftests/bpf/progs/tailcall3.c | 5 +-
> > tools/testing/selftests/bpf/progs/tailcall4.c | 5 +-
> > tools/testing/selftests/bpf/progs/tailcall5.c | 5 +-
> > tools/testing/selftests/bpf/progs/tailcall6.c | 4 +-
> > .../selftests/bpf/progs/tailcall_bpf2bpf1.c | 5 +-
> > .../selftests/bpf/progs/tailcall_bpf2bpf2.c | 5 +-
> > .../selftests/bpf/progs/tailcall_bpf2bpf3.c | 9 ++-
> > .../selftests/bpf/progs/tailcall_bpf2bpf4.c | 13 ++---
> > .../bpf/progs/test_btf_skc_cls_ingress.c | 2 +-
> > .../selftests/bpf/progs/test_cls_redirect.c | 2 +-
> > .../selftests/bpf/progs/test_global_data.c | 2 +-
> > .../selftests/bpf/progs/test_global_func1.c | 2 +-
> > .../selftests/bpf/progs/test_global_func3.c | 2 +-
> > .../selftests/bpf/progs/test_global_func5.c | 2 +-
> > .../selftests/bpf/progs/test_global_func6.c | 2 +-
> > .../selftests/bpf/progs/test_global_func7.c | 2 +-
> > .../selftests/bpf/progs/test_pkt_access.c | 2 +-
> > .../selftests/bpf/progs/test_pkt_md_access.c | 4 +-
> > .../selftests/bpf/progs/test_sk_assign.c | 3 +-
> > .../selftests/bpf/progs/test_sk_lookup_kern.c | 37 ++++++------
> > .../selftests/bpf/progs/test_skb_helpers.c | 2 +-
> > .../selftests/bpf/progs/test_sockmap_update.c | 2 +-
> > .../selftests/bpf/progs/test_tc_neigh.c | 6 +-
> > .../selftests/bpf/progs/test_tc_neigh_fib.c | 6 +-
> > .../selftests/bpf/progs/test_tc_peer.c | 10 ++--
> > 31 files changed, 117 insertions(+), 132 deletions(-)
> >
> > diff --git a/tools/testing/selftests/bpf/prog_tests/reference_tracking.c b/tools/testing/selftests/bpf/prog_tests/reference_tracking.c
> > index ded2dc8ddd79..836b8bf17fff 100644
> > --- a/tools/testing/selftests/bpf/prog_tests/reference_tracking.c
> > +++ b/tools/testing/selftests/bpf/prog_tests/reference_tracking.c
> > @@ -2,14 +2,14 @@
> > #include <test_progs.h>
> >
> > static void toggle_object_autoload_progs(const struct bpf_object *obj,
> > - const char *title_load)
> > + const char *name_load)
> > {
> > struct bpf_program *prog;
> >
> > bpf_object__for_each_program(prog, obj) {
> > - const char *title = bpf_program__section_name(prog);
> > + const char *name = bpf_program__name(prog);
> >
> > - if (!strcmp(title_load, title))
> > + if (!strcmp(name_load, name))
> > bpf_program__set_autoload(prog, true);
> > else
> > bpf_program__set_autoload(prog, false);
> > @@ -39,23 +39,20 @@ void test_reference_tracking(void)
> > goto cleanup;
> >
> > bpf_object__for_each_program(prog, obj_iter) {
> > - const char *title;
> > + const char *name;
> >
> > /* Ignore .text sections */
>
> I think this comment should go as well, no longer helps understand the test
yep, I originally removed it but then it was accidentally resurrected
when I was resolving merge conflict with your vprintk() patches. I'll
drop if I need to re-spin, but otherwise we can get to this in follow
up patches.
next prev parent reply other threads:[~2021-09-21 23:11 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 23:43 [PATCH v2 bpf-next 0/9] libbpf: stricter BPF program section name handling Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 1/9] selftests/bpf: normalize XDP section names in selftests Andrii Nakryiko
2021-09-21 4:55 ` Dave Marchevsky
2021-09-21 23:08 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 2/9] selftests/bpf: normalize SEC("classifier") usage Andrii Nakryiko
2021-09-21 5:20 ` Dave Marchevsky
2021-09-21 23:10 ` Andrii Nakryiko [this message]
2021-09-20 23:43 ` [PATCH v2 bpf-next 3/9] selftests/bpf: normalize all the rest SEC() uses Andrii Nakryiko
2021-09-21 5:41 ` Dave Marchevsky
2021-09-21 23:12 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 4/9] libbpf: refactor internal sec_def handling to enable pluggability Andrii Nakryiko
2021-09-22 0:42 ` Dave Marchevsky
2021-09-22 22:06 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 5/9] libbpf: reduce reliance of attach_fns on sec_def internals Andrii Nakryiko
2021-09-22 1:00 ` Dave Marchevsky
2021-09-20 23:43 ` [PATCH v2 bpf-next 6/9] libbpf: refactor ELF section handler definitions Andrii Nakryiko
2021-09-22 1:34 ` Dave Marchevsky
2021-09-22 21:54 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 7/9] libbpf: complete SEC() table unification for BPF_APROG_SEC/BPF_EAPROG_SEC Andrii Nakryiko
2021-09-22 1:42 ` Dave Marchevsky
2021-09-22 21:55 ` Andrii Nakryiko
2021-09-22 22:12 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 8/9] libbpf: add opt-in strict BPF program section name handling logic Andrii Nakryiko
2021-09-22 1:53 ` Dave Marchevsky
2021-09-22 21:57 ` Andrii Nakryiko
2021-09-20 23:43 ` [PATCH v2 bpf-next 9/9] selftests/bpf: switch sk_lookup selftests to strict SEC("sk_lookup") use Andrii Nakryiko
2021-09-22 2:37 ` Dave Marchevsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzZZXZuHWqYpVRzPa8OPDMe50gmnM8c2kmshg7DCqw-MrQ@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).