From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49895C433DF for ; Tue, 30 Jun 2020 03:35:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DB582063A for ; Tue, 30 Jun 2020 03:35:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sh9H+6YC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729124AbgF3Dfk (ORCPT ); Mon, 29 Jun 2020 23:35:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728949AbgF3Dfk (ORCPT ); Mon, 29 Jun 2020 23:35:40 -0400 Received: from mail-qk1-x742.google.com (mail-qk1-x742.google.com [IPv6:2607:f8b0:4864:20::742]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B224C061755; Mon, 29 Jun 2020 20:35:40 -0700 (PDT) Received: by mail-qk1-x742.google.com with SMTP id r22so17328665qke.13; Mon, 29 Jun 2020 20:35:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X+G/fC1ZJxg9D7sXRo1zoSpZ6TzsmSrYBlcJIXJdrBw=; b=sh9H+6YC61FqM9Yw+5iHaaiVQkb2rlCgmYWQk1dbBhyDcKvVeVftDplFj9lxl8ZUR1 SRaeO+jLM9dB9rwHVVH9Qj9y1e4E7ZFE+z9ZIt66fGk0PgK/qEfrpQ1Ro0clydTZaWrG 21TjROTW5DUPNpq/6myomXJtwNu52/zO23JNCh9mowDzlJM1DhY3r+5X5ZPJSxJsYLhR B4raugXWyZdRJam1qOfWsvtYW5yoToxc715xsF2zGWHviMPge+kusxKU8kmgXNsNBR+4 nHUxqhEKTVH73ZGnIte1bm8Duklryj/foxTzJMZA7EmIVlmQDrYAbZmTjVlPvV5XjQaT U3xQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X+G/fC1ZJxg9D7sXRo1zoSpZ6TzsmSrYBlcJIXJdrBw=; b=Gv9steNxr15YhVeXlYZUsDvmXNSzy/jzK5Vfu49695yVyulP5gpRzHv0NnaIvFbP0F +n9IuPCuNKiJXts9A3OMVPJ/4fXXByj7QQIwd0haq7+qms2TnKl00pKsV6j0ffPIEYjk QIIqyMQ5YXhUFlOiYM2mW6mRgxQNwwWkIIDgXibCFan2hl4KfKfSzbIN7WMpxsxyYGh5 XTxeKPy00Oomsa4GzED3bbSlGwaNhXb8DOLOV2d0erJAGyI2Skuo2zvNqX7Ing8x+joa 15dMoPsNpJEB7YU54SUFu83rtp4KxD8u9gl/i+ctI2LeEPWTPG1Ez9X1SHNPxAQlchJC yVYA== X-Gm-Message-State: AOAM530/YpLe4vKpdYuYailjr7FBPlsL+9/0OpL0NxsJWcLWfP3GhmWb aXTj2UK3BK1IvjNCFOTZIurAzKdUANP33I3vZf0= X-Google-Smtp-Source: ABdhPJzP6AII8IaFL3yt6fo39puoK2J/siP1rOLK+tXJea71FjRs32d2Bi+fbupo/AUmMp1zOIDkcEjNIcFfZiTKnWw= X-Received: by 2002:a05:620a:2409:: with SMTP id d9mr18763746qkn.36.1593488139441; Mon, 29 Jun 2020 20:35:39 -0700 (PDT) MIME-Version: 1.0 References: <20200630020539.787781-1-andriin@fb.com> <20200630030910.p7xnbnywofvzcr7r@ast-mbp.dhcp.thefacebook.com> In-Reply-To: <20200630030910.p7xnbnywofvzcr7r@ast-mbp.dhcp.thefacebook.com> From: Andrii Nakryiko Date: Mon, 29 Jun 2020 20:35:28 -0700 Message-ID: Subject: Re: [PATCH bpf-next] libbpf: make bpf_endian co-exist with vmlinux.h To: Alexei Starovoitov Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jun 29, 2020 at 8:09 PM Alexei Starovoitov wrote: > > On Mon, Jun 29, 2020 at 07:05:38PM -0700, Andrii Nakryiko wrote: > > Copy over few #defines from UAPI swab.h header to make all the rest of > > bpf_endian.h work and not rely on any extra headers. This way it can be used > > both with linux header includes, as well with a vmlinux.h. This has been > > a frequent complaint from users, that need this header. > > > > Signed-off-by: Andrii Nakryiko > > --- > > tools/lib/bpf/bpf_endian.h | 22 ++++++++++++++++++++-- > > 1 file changed, 20 insertions(+), 2 deletions(-) > > > > diff --git a/tools/lib/bpf/bpf_endian.h b/tools/lib/bpf/bpf_endian.h > > index fbe28008450f..a4be8a70845c 100644 > > --- a/tools/lib/bpf/bpf_endian.h > > +++ b/tools/lib/bpf/bpf_endian.h > > @@ -2,8 +2,26 @@ > > #ifndef __BPF_ENDIAN__ > > #define __BPF_ENDIAN__ > > > > -#include > > -#include > > +/* copied from include/uapi/linux/swab.h */ > > You cannot just copy due to different licenses. Ah, I see. I was thinking that because it's from UAPI header it might be ok. Alright, I'll try to re-implement it instead.