From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <ast@fb.com>
Cc: Andrii Nakryiko <andriin@fb.com>, Yonghong Song <yhs@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bpf@vger.kernel.org" <bpf@vger.kernel.org>,
"daniel@iogearbox.net" <daniel@iogearbox.net>,
Song Liu <songliubraving@fb.com>
Subject: Re: [PATCH bpf-next 2/4] bpf/verifier: fix code formatting
Date: Sat, 2 Mar 2019 14:02:28 -0800 [thread overview]
Message-ID: <CAEf4BzZtqJbZuTbAsyoowi1LBFfKb_csxFknMwQKNFtYeLYQ3w@mail.gmail.com> (raw)
In-Reply-To: <fda23d5e-6de3-ab2f-107c-8abc1abaaef8@fb.com>
On Fri, Mar 1, 2019 at 11:24 AM Alexei Starovoitov <ast@fb.com> wrote:
>
> On 2/28/19 5:37 PM, Andrii Nakryiko wrote:
> > -#define REALLOC_STATE_FN(NAME, COUNT, FIELD, SIZE) \
> > -static int realloc_##NAME##_state(struct bpf_func_state *state, int size, \
> > - bool copy_old) \
> > -{ \
> > - u32 old_size = state->COUNT; \
> > - struct bpf_##NAME##_state *new_##FIELD; \
> > - int slot = size / SIZE; \
> > - \
> > - if (size <= old_size || !size) { \
> > - if (copy_old) \
> > - return 0; \
> > - state->COUNT = slot * SIZE; \
> > - if (!size && old_size) { \
> > - kfree(state->FIELD); \
> > - state->FIELD = NULL; \
> > - } \
> > - return 0; \
> > - } \
> > +#define REALLOC_STATE_FN(NAME, COUNT, FIELD, SIZE) \
> > +static int realloc_##NAME##_state(struct bpf_func_state *state, int size, \
> > + bool copy_old) \
> > +{ \
> > + u32 old_size = state->COUNT; \
>
> what is the change here?
> extra tab at the end of every line?
> I think that adds too much noise to git history.
> I'd rather keep this bit as-is.
>
>
I feel like this whole patchset doesn't add much value and will just
pollute history. I'm just going to abandon it for now.
next prev parent reply other threads:[~2019-03-02 22:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 1:37 [PATCH bpf-next 0/4] Formatting and typo fixes in kernel/bpf Andrii Nakryiko
2019-03-01 1:37 ` [PATCH bpf-next 1/4] bpf: formatting fixes in syscall.c Andrii Nakryiko
2019-03-01 1:37 ` [PATCH bpf-next 2/4] bpf/verifier: fix code formatting Andrii Nakryiko
2019-03-01 19:23 ` Alexei Starovoitov
2019-03-02 22:02 ` Andrii Nakryiko [this message]
2019-03-01 1:37 ` [PATCH bpf-next 3/4] bpf/verifier: typo fixes and reflow verifier overview comment Andrii Nakryiko
2019-03-01 1:37 ` [PATCH bpf-next 4/4] bpf/verifier: fix minor typos in comments Andrii Nakryiko
2019-03-01 6:35 ` [PATCH bpf-next 0/4] Formatting and typo fixes in kernel/bpf Song Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzZtqJbZuTbAsyoowi1LBFfKb_csxFknMwQKNFtYeLYQ3w@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=ast@fb.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).