From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38817C47256 for ; Wed, 6 May 2020 17:40:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0EFF4208DB for ; Wed, 6 May 2020 17:40:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B4QPqqQw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728796AbgEFRkZ (ORCPT ); Wed, 6 May 2020 13:40:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728047AbgEFRkZ (ORCPT ); Wed, 6 May 2020 13:40:25 -0400 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D63D7C061A0F; Wed, 6 May 2020 10:40:24 -0700 (PDT) Received: by mail-qk1-x741.google.com with SMTP id f83so2908678qke.13; Wed, 06 May 2020 10:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vh69jvYL8rP/gJYqShJHYtuquy/MVM6OccSOU1yzpfM=; b=B4QPqqQweo58nFL0vxi+WUePpvQPYG/TSlGtZ9Sd1HRjfcIFh2HQAognvkdVWUXTVm oEs/W/9IhBjBLVAtPpdJTfWMjXN9xO9Iz1xkbSuX5HlGQX8ogtTRWHSvwIkkMUmFeF8m Z0SIS/LbHzCZqrOFKLOqlvKkNt1EIVzJnoVVcLfDWJRWYbNbVx6repcOw/HL+TRB9/BQ bdcupK1paVsDz86ZrzSHP5NoNlrzbGgilTJFC7RmzbqN/LJxU0mjiEXhhyTtRf2YvNU+ j+WPA2sOIrCWJ5e5AVRztyqvypsHVPzSLQPwCRIKs8x3Gi0IpLjSzmjLguNY97NqJGdy W2vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vh69jvYL8rP/gJYqShJHYtuquy/MVM6OccSOU1yzpfM=; b=SMiK1eh08kEMFLP+UxYDfR/6U1JQ++nWSQftSv+aZbp7AwUT3n2np7pP66d2XkqTqi XXTF0dgFEQw/ZYA88XE2dVuNE1UnbtXX5DHTnjthQy5TAG3gxJKnLD0jtUM9Flzxjzmi DenDMuSBjOybMcg/itjXFsmZ5ZlIjS74EkAFPNFMYq2fKIU4RXhVFC2zU+WhqkjeG4Qb aupJH5U5A9dPEDOgKJZX4Z6AOd84Su1cbWsrteApYm3ytHcsg/wdq1pqeP9xXwmOcDXu ndBnUlPNiDKcoNJhW/xVya4G4d1/EKTtue5XOc/6voq9AIhRqqtndOutm6Y9OywxcHJD 7lEA== X-Gm-Message-State: AGi0PubZugQgC+PXXc0jNbLoonCTVDoyZ4Jo8OshoF31xaah3E3ttLLq qwxWJGI+44jypF09bHhQ1+JqDvoB/ohRzH8mQxw= X-Google-Smtp-Source: APiQypLz+1zXhNr/M18qHjj5wR/+BYu7IcrllyHeCrwswONCS9cDgP8oWpTqJD+s5/0qSHdDC/0lIT1qbcS1jeoRQTw= X-Received: by 2002:ae9:e713:: with SMTP id m19mr10162813qka.39.1588786822693; Wed, 06 May 2020 10:40:22 -0700 (PDT) MIME-Version: 1.0 References: <20200504062547.2047304-1-yhs@fb.com> <20200504062604.2048804-1-yhs@fb.com> In-Reply-To: <20200504062604.2048804-1-yhs@fb.com> From: Andrii Nakryiko Date: Wed, 6 May 2020 10:40:11 -0700 Message-ID: Subject: Re: [PATCH bpf-next v2 15/20] bpf: support variable length array in tracing programs To: Yonghong Song Cc: Andrii Nakryiko , bpf , Martin KaFai Lau , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, May 3, 2020 at 11:27 PM Yonghong Song wrote: > > In /proc/net/ipv6_route, we have > struct fib6_info { > struct fib6_table *fib6_table; > ... > struct fib6_nh fib6_nh[0]; > } > struct fib6_nh { > struct fib_nh_common nh_common; > struct rt6_info **rt6i_pcpu; > struct rt6_exception_bucket *rt6i_exception_bucket; > }; > struct fib_nh_common { > ... > u8 nhc_gw_family; > ... > } > > The access: > struct fib6_nh *fib6_nh = &rt->fib6_nh; > ... fib6_nh->nh_common.nhc_gw_family ... > > This patch ensures such an access is handled properly. > > Signed-off-by: Yonghong Song > --- LGTM. Acked-by: Andrii Nakryiko > kernel/bpf/btf.c | 37 +++++++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > [...]