From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14930C433ED for ; Mon, 10 May 2021 18:00:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEAD661481 for ; Mon, 10 May 2021 18:00:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233151AbhEJSBr (ORCPT ); Mon, 10 May 2021 14:01:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232262AbhEJSBq (ORCPT ); Mon, 10 May 2021 14:01:46 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EFDAAC061574; Mon, 10 May 2021 11:00:40 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id y2so22779915ybq.13; Mon, 10 May 2021 11:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DD7i9qP2zN0Z45a4kHjOpZVD+4L/ua3ViHeI4lwRELc=; b=IL2s8Hb7zDWa8g/9CV8Jb+WWAuQVB1p2p9P8TlFVvTshfkkmISMTkFnqmGvY9SqgCa fNALF0iXQZxdTXmTqgY+7Bgf+sfxnXjBwjIG/We2/dDEnC+LoR/pb/jPu/gQh609yyH3 UOtZzR25YpmKeZWNeV8OTCMZFF4/Ns7EyMpXeFSUCIh+JoraxQ/6mJW0H5XFewKINZ5o DfZ8ubBAj6wL/O8xobf5RGrDxiwIRIS8PGJpH9leNhLODhQHBKcV8fIuYRKAXHGRj/wb V8pKPOA3kgqkQq+dlBU23AgJAVjq8crihk5953Ozj70o0KVyNhxtVnDvvWduK38M0QQn 489Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DD7i9qP2zN0Z45a4kHjOpZVD+4L/ua3ViHeI4lwRELc=; b=Rxc7qd8T2nFA8o5sTHyO8Vf+ZS1mGg6cSVGpCO+cCgXipbhk9CMvDFuY7oR66Dr2+M nquRrJutOsY9e1SG1sKStT3DnK8jGWDpGX5D0KJVSDr9h/kUp24DKigsdhKPPHbkXs8n AkDpAe2gj6SwS85tivKNiww5qu6HBLgg4rAP53AGkV2LbebKx3nydw3Ft0+Tgk+k84pA TOvw3h9aTe3x8/MIrhS8bJtbS/wPxt8dvdI9nwoooDaXc/Ms0BDAsfjcD52aCwx10OEK p0iE2HhdEC5bOfteQCy33dild18S7ZnEa5j4Y6VGyHxIOsQiSNu+h8ZNvaCh+y+vH6Ts zY3w== X-Gm-Message-State: AOAM530pRETffzRz+xMffSOeMZHieKNst0j5HyzhuM7CjGLngIv7Ag3Y O1UTx/EMx9OunSioWchE3QcupGyQ6jn/SeiBL6g= X-Google-Smtp-Source: ABdhPJwQU1cEqxBN12jhvT65LdxQ/CLSsoiOa5153me5eZSjvbk3csssQsl3fuFGQD6nmk4Kk6j9UIQHAtUJK/7mWBA= X-Received: by 2002:a25:3357:: with SMTP id z84mr33990965ybz.260.1620669640289; Mon, 10 May 2021 11:00:40 -0700 (PDT) MIME-Version: 1.0 References: <20210510124315.3854-1-thunder.leizhen@huawei.com> In-Reply-To: <20210510124315.3854-1-thunder.leizhen@huawei.com> From: Andrii Nakryiko Date: Mon, 10 May 2021 11:00:29 -0700 Message-ID: Subject: Re: [PATCH 1/1] libbpf: Delete an unneeded bool conversion To: Zhen Lei Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , netdev , bpf Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, May 10, 2021 at 5:43 AM Zhen Lei wrote: > > The result of an expression consisting of a single relational operator is > already of the bool type and does not need to be evaluated explicitly. > > No functional change. > > Signed-off-by: Zhen Lei > --- See [0] and [1]. [0] https://lore.kernel.org/bpf/CAEf4BzYgLf5g3oztbA-CJR4gQ7AVKQAGrsHWCOgTtUMUM-Mxfg@mail.gmail.com/ [1] https://lore.kernel.org/bpf/CAEf4BzZQ6=-h3g1duXFwDLr92z7nE6ajv8Rz_Zv=qx=-F3sRVA@mail.gmail.com/ > tools/lib/bpf/libbpf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c > index e2a3cf4378140f2..fa02213c451f4d2 100644 > --- a/tools/lib/bpf/libbpf.c > +++ b/tools/lib/bpf/libbpf.c > @@ -1504,7 +1504,7 @@ static int set_kcfg_value_tri(struct extern_desc *ext, void *ext_val, > ext->name, value); > return -EINVAL; > } > - *(bool *)ext_val = value == 'y' ? true : false; > + *(bool *)ext_val = value == 'y'; > break; > case KCFG_TRISTATE: > if (value == 'y') > -- > 2.26.0.106.g9fadedd > >