From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2C27C64E90 for ; Wed, 2 Dec 2020 00:27:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 76EF22158C for ; Wed, 2 Dec 2020 00:27:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726342AbgLBA1h (ORCPT ); Tue, 1 Dec 2020 19:27:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726229AbgLBA1g (ORCPT ); Tue, 1 Dec 2020 19:27:36 -0500 Received: from mail-yb1-xb42.google.com (mail-yb1-xb42.google.com [IPv6:2607:f8b0:4864:20::b42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A999C0613CF; Tue, 1 Dec 2020 16:26:56 -0800 (PST) Received: by mail-yb1-xb42.google.com with SMTP id o71so38538ybc.2; Tue, 01 Dec 2020 16:26:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vfCF2rrgBv4Qtm98WE1uwXxGb7ee+2ZYnfEmg2VySPE=; b=Lx0ntsOgTlCheqLAQiMrZXM0n1USD7f5oQf/FsL3s87zOyYRGgvULQOIU8Nr+b032u joW3d9jxBpb1YzfF3mTvKJKFK4/29DIJoP1IJgGRMrMxiivqFEnaQ1p4fee/tjijFbW6 bW4MWlx6kCAKvls4J1tF4BFRn+XxNl6DEzHKKng0OZaaH95VbV+PJiHxFNY+TrZkbj6q 9vNmwsfvgiw284pEGNAcBGjdPuAL1Y1LMQKmJwppm7CuhoYN+zwyvo0778koDxyFx6vN 2PecywuGaQYjNNjtK4+9nGA1NljxWLwsqeYuGnVINVO8Ewlc+comMPGI+Dv0MEx61N6m n+pA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vfCF2rrgBv4Qtm98WE1uwXxGb7ee+2ZYnfEmg2VySPE=; b=pha+CbRPgAFeKYLZ3oqPdA43EfRzSY9ZIIlweginton02lsppkCkDvHMVuZy3kD+ba A/XsNeeXC7vwXtILtJGJnXeN5eTUH1cBjcDrSHxDgWBYCbJEHz6pZYu8zeRWm3E4p8B6 WrKa2ZVG/0Y3AoBNpLHZ/sxyyshu0GIoqikoOGPuvBYDhC4eMmmhGGQ01K+VQ/kEk5p6 GTuS/tIY48VL8Q3ISshzoEGaz5MdeXAMmTYKHsB/NevyA2cH/b3/ANWxoSzMhFVOChIH HhVXuwh9ZJyVp6FrnrxiryqD0tHZAGehjVCYjf5bNg5z9+uouRPu/6S78dT7PTK+qzXT mTcQ== X-Gm-Message-State: AOAM531Mk3xrWzF9D37KJvWFEtxXM6xraB8WyJCv+NMXmhG8b4Lvs+vc tEJrOAeRJvMrCf74jgK01T8g+JmNTToUdA6oBJ4= X-Google-Smtp-Source: ABdhPJxog44/VOr67JY6HNC903NDUE8Kw2I1Wc4DYYxrc0gUlLwGgmecdPKIsoWt3kCMVpHarTWIDGsGmfHKigeMzyg= X-Received: by 2002:a25:3d7:: with SMTP id 206mr6691097ybd.27.1606868815940; Tue, 01 Dec 2020 16:26:55 -0800 (PST) MIME-Version: 1.0 References: <20201118001742.85005-1-sdf@google.com> <20201118001742.85005-2-sdf@google.com> In-Reply-To: <20201118001742.85005-2-sdf@google.com> From: Andrii Nakryiko Date: Tue, 1 Dec 2020 16:26:45 -0800 Message-ID: Subject: Re: [PATCH bpf-next 1/3] selftests/bpf: rewrite test_sock_addr bind bpf into C To: Stanislav Fomichev Cc: Networking , bpf , "David S. Miller" , Alexei Starovoitov , Daniel Borkmann Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Nov 17, 2020 at 4:20 PM Stanislav Fomichev wrote: > > I'm planning to extend it in the next patches. It's much easier to > work with C than BPF assembly. > > Signed-off-by: Stanislav Fomichev > --- With nits below: Acked-by: Andrii Nakryiko > .../testing/selftests/bpf/progs/bind4_prog.c | 73 +++++++ > .../testing/selftests/bpf/progs/bind6_prog.c | 90 ++++++++ > tools/testing/selftests/bpf/test_sock_addr.c | 196 ++---------------- > 3 files changed, 175 insertions(+), 184 deletions(-) > create mode 100644 tools/testing/selftests/bpf/progs/bind4_prog.c > create mode 100644 tools/testing/selftests/bpf/progs/bind6_prog.c > > diff --git a/tools/testing/selftests/bpf/progs/bind4_prog.c b/tools/testing/selftests/bpf/progs/bind4_prog.c > new file mode 100644 > index 000000000000..ff3def2ee6f9 > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/bind4_prog.c > @@ -0,0 +1,73 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#define SERV4_IP 0xc0a801feU /* 192.168.1.254 */ > +#define SERV4_PORT 4040 > +#define SERV4_REWRITE_IP 0x7f000001U /* 127.0.0.1 */ > +#define SERV4_REWRITE_PORT 4444 > + > +int _version SEC("version") = 1; not needed, let's not add it to a new test prog > + [...] > diff --git a/tools/testing/selftests/bpf/progs/bind6_prog.c b/tools/testing/selftests/bpf/progs/bind6_prog.c > new file mode 100644 > index 000000000000..97686baaae65 > --- /dev/null > +++ b/tools/testing/selftests/bpf/progs/bind6_prog.c > @@ -0,0 +1,90 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > + > +#define SERV6_IP_0 0xfaceb00c /* face:b00c:1234:5678::abcd */ > +#define SERV6_IP_1 0x12345678 > +#define SERV6_IP_2 0x00000000 > +#define SERV6_IP_3 0x0000abcd > +#define SERV6_PORT 6060 > +#define SERV6_REWRITE_IP_0 0x00000000 > +#define SERV6_REWRITE_IP_1 0x00000000 > +#define SERV6_REWRITE_IP_2 0x00000000 > +#define SERV6_REWRITE_IP_3 0x00000001 > +#define SERV6_REWRITE_PORT 6666 > + > +int _version SEC("version") = 1; same > + > +SEC("cgroup/bind6") > +int bind_v6_prog(struct bpf_sock_addr *ctx) > +{ [...]