bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: carlos antonio neira bustos <cneirabustos@gmail.com>
Cc: Alexei Starovoitov <alexei.starovoitov@gmail.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Jesper Dangaard Brouer <brouer@redhat.com>,
	Network Development <netdev@vger.kernel.org>,
	Yonghong Song <yhs@fb.com>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH v17 0/3] BPF: New helper to obtain namespace data from current task
Date: Mon, 27 Apr 2020 18:47:07 -0700	[thread overview]
Message-ID: <CAEf4BzaRr55yNeCpGXihbo49n+bZDkypiFhvsY11QUw4Rr_msw@mail.gmail.com> (raw)
In-Reply-To: <CACiB22iSFBybiAn_Z0cspWFLObZy30ZoQHnvH4kFdVsB9dinvQ@mail.gmail.com>

On Mon, Apr 27, 2020 at 6:44 PM carlos antonio neira bustos
<cneirabustos@gmail.com> wrote:
>
> Hi,
>
> I’m sorry I’ll do the work needed this week.
> Thanks for the heads up.
>
> Bests.

No worries, thanks!

>
>
> El El lun, 27 de abr. de 2020 a la(s) 21:40, Andrii Nakryiko <andrii.nakryiko@gmail.com> escribió:
>>
>> On Fri, Mar 13, 2020 at 5:48 AM Carlos Antonio Neira Bustos
>> <cneirabustos@gmail.com> wrote:
>> >
>> > On Thu, Mar 12, 2020 at 05:45:09PM -0700, Alexei Starovoitov wrote:
>> > > On Wed, Mar 4, 2020 at 12:42 PM Carlos Neira <cneirabustos@gmail.com> wrote:
>> > > >
>> > > > Currently bpf_get_current_pid_tgid(), is used to do pid filtering in bcc's
>> > > > scripts but this helper returns the pid as seen by the root namespace which is
>> > > > fine when a bcc script is not executed inside a container.
>> > > > When the process of interest is inside a container, pid filtering will not work
>> > > > if bpf_get_current_pid_tgid() is used.
>> > > > This helper addresses this limitation returning the pid as it's seen by the current
>> > > > namespace where the script is executing.
>> > > >
>> > > > In the future different pid_ns files may belong to different devices, according to the
>> > > > discussion between Eric Biederman and Yonghong in 2017 Linux plumbers conference.
>> > > > To address that situation the helper requires inum and dev_t from /proc/self/ns/pid.
>> > > > This helper has the same use cases as bpf_get_current_pid_tgid() as it can be
>> > > > used to do pid filtering even inside a container.
>> > >
>> > > Applied. Thanks.
>> > > There was one spurious trailing whitespace that I fixed in patch 3
>> > > and missing .gitignore update for test_current_pid_tgid_new_ns.
>> > > Could you please follow up with another patch to fold
>> > > test_current_pid_tgid_new_ns into test_progs.
>> > > I'd really like to consolidate all tests into single binary.
>> >
>> > Thank you very much Alexei,
>> > I'll start working on the follow up patch to add test_current_pid_tgid_new_ns into test_progs.
>> >
>>
>> Hey Carlos,
>>
>> Do you still plan to fold test_current_pid_tgid_new_ns into test_progs?
>>
>> > Bests

      parent reply	other threads:[~2020-04-28  1:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-04 20:41 [PATCH v17 0/3] BPF: New helper to obtain namespace data from current task Carlos Neira
2020-03-04 20:41 ` [PATCH v17 1/3] fs/nsfs.c: added ns_match Carlos Neira
2020-03-04 20:41 ` [PATCH v17 2/3] bpf: added new helper bpf_get_ns_current_pid_tgid Carlos Neira
2020-03-04 20:41 ` [PATCH v17 3/3] tools/testing/selftests/bpf: Add self-tests for " Carlos Neira
2020-03-13  0:45 ` [PATCH v17 0/3] BPF: New helper to obtain namespace data from current task Alexei Starovoitov
2020-03-13 10:39   ` Quentin Monnet
2020-03-13 12:48     ` Carlos Antonio Neira Bustos
2020-03-13 12:46   ` Carlos Antonio Neira Bustos
2020-04-28  1:40     ` Andrii Nakryiko
     [not found]       ` <CACiB22iSFBybiAn_Z0cspWFLObZy30ZoQHnvH4kFdVsB9dinvQ@mail.gmail.com>
2020-04-28  1:47         ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzaRr55yNeCpGXihbo49n+bZDkypiFhvsY11QUw4Rr_msw@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=brouer@redhat.com \
    --cc=cneirabustos@gmail.com \
    --cc=ebiederm@xmission.com \
    --cc=netdev@vger.kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).