From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Hou Tao <houtao1@huawei.com>
Cc: Alexei Starovoitov <ast@kernel.org>, Yonghong Song <yhs@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <kafai@fb.com>,
Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf-next v2 2/3] libbpf: support detecting and attaching of writable tracepoint program
Date: Tue, 21 Sep 2021 14:42:05 -0700 [thread overview]
Message-ID: <CAEf4BzaVaOiwkNgFQjwRfy9V_5NqiEyPMj-_AotO5TYeWiva3g@mail.gmail.com> (raw)
In-Reply-To: <20210918020958.1167652-3-houtao1@huawei.com>
On Fri, Sep 17, 2021 at 6:56 PM Hou Tao <houtao1@huawei.com> wrote:
>
> Program on writable tracepoint is BPF_PROG_TYPE_RAW_TRACEPOINT_WRITABLE,
> but its attachment is the same as BPF_PROG_TYPE_RAW_TRACEPOINT.
>
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
> tools/lib/bpf/libbpf.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/libbpf.c
> index da65a1666a5e..981fcdd95bdc 100644
> --- a/tools/lib/bpf/libbpf.c
> +++ b/tools/lib/bpf/libbpf.c
> @@ -7976,6 +7976,10 @@ static const struct bpf_sec_def section_defs[] = {
> .attach_fn = attach_raw_tp),
> SEC_DEF("raw_tp/", RAW_TRACEPOINT,
> .attach_fn = attach_raw_tp),
> + SEC_DEF("raw_tracepoint_writable/", RAW_TRACEPOINT_WRITABLE,
> + .attach_fn = attach_raw_tp),
> + SEC_DEF("raw_tp_writable/", RAW_TRACEPOINT_WRITABLE,
> + .attach_fn = attach_raw_tp),
_writable is a bit mouthful, maybe we should do the same we did for
"sleepable", just add ".w" suffix? So it will be "raw_tp.w/..."? Or
does anyone feel it's too subtle?
> SEC_DEF("tp_btf/", TRACING,
> .expected_attach_type = BPF_TRACE_RAW_TP,
> .is_attach_btf = true,
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-09-21 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-18 2:09 [PATCH bpf-next v2 0/3] add support for writable bare tracepoint Hou Tao
2021-09-18 2:09 ` [PATCH bpf-next v2 1/3] bpf: support writable context for " Hou Tao
2021-09-18 2:09 ` [PATCH bpf-next v2 2/3] libbpf: support detecting and attaching of writable tracepoint program Hou Tao
2021-09-21 21:42 ` Andrii Nakryiko [this message]
2021-09-28 12:28 ` Hou Tao
2021-09-18 2:09 ` [PATCH bpf-next v2 3/3] bpf/selftests: add test for writable bare tracepoint Hou Tao
2021-09-21 21:53 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzaVaOiwkNgFQjwRfy9V_5NqiEyPMj-_AotO5TYeWiva3g@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=houtao1@huawei.com \
--cc=kafai@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).