From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3575C4CEC9 for ; Tue, 17 Sep 2019 04:12:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8021F20880 for ; Tue, 17 Sep 2019 04:12:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f5HaSEB5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727170AbfIQEMf (ORCPT ); Tue, 17 Sep 2019 00:12:35 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:42699 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725780AbfIQEMe (ORCPT ); Tue, 17 Sep 2019 00:12:34 -0400 Received: by mail-qk1-f194.google.com with SMTP id f16so2416290qkl.9; Mon, 16 Sep 2019 21:12:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=yZzOqidsjo85aSS4sastJYqRni/k6zjUrRu+ouhRS4U=; b=f5HaSEB5mb4x627zbUcF1RDiWpeIxa5U6vcPYImWyHyBds+Wzg2wGOs9jrw/JGXEec ZsFD1nhBNuiS8sEOWCsr1/RpRyMU9lpSZQ/vIVI0MYROAiKz/S401fExSIqqTsASNtbZ ibDZwuRORia+0K1gGBCRv87Sv+B1bsB4BjGyz13wnOxJASm9NMGWeJeXlTceaQnAYtgz Tl7XAPs+3dD8jnulAH7H2cpN5G8Oz/P8lzJfhTo2zps28+vORaiEDjjUWdkWqTWiyTmC Wztn+nW7chYOzH5beR5kLZyuUfMtsabgeEltuFgFSKYhzWAT0EupEMx8O2hrxFe2VyFw EfAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=yZzOqidsjo85aSS4sastJYqRni/k6zjUrRu+ouhRS4U=; b=jyK5TbjiqckwxuHEHGPR8O+oK1r5tG60HojSk91QQqCrCmRxk2W2yrks9hLA5LDnUC rx/59F4GZeAKPnEsCVtjfT2DwPrqwSxdrIkdQMJ8GHGiGS1N/Mjs99McWhgij9hqRRqL kScCXkxSyQeKXqrodLevYVthl1h+jY3AYh0bZSwo8ggXLd3UEFQrR3F2Q35b9y+jNVIS qrjp6ecc7YRxqc2WZr7pnDIPzs82HxkaHxdbv4UsZQ0fdgjtKBuAqCwLCDwLz8CVfeZ3 MyHhth+b4bbQ4re3A4EGuPh8KEL8Nr/xLijqRsHpg7R6c70Z1Sxlqd7tdkR/jh6f+N8I hGoQ== X-Gm-Message-State: APjAAAUJy35cklmWJbgwffUUfRDSyWy05f+oSpWMrnOGzyIFunKsy5KK vrKAFPJsKq35TD0z9ZeYbWlSHBNFCXis7zNMcQM= X-Google-Smtp-Source: APXvYqwZSDge9O/o77NWbL3xsm+hUhFvt7SDF/Go533S0kmBVDWDg8bT9LLIDvRF8Y8np2/C30Gkogc1muKdFZ0YMIk= X-Received: by 2002:ae9:dc87:: with SMTP id q129mr1762990qkf.92.1568693553793; Mon, 16 Sep 2019 21:12:33 -0700 (PDT) MIME-Version: 1.0 References: <20190916123342.49928-1-toke@redhat.com> In-Reply-To: <20190916123342.49928-1-toke@redhat.com> From: Andrii Nakryiko Date: Mon, 16 Sep 2019 21:12:23 -0700 Message-ID: Subject: Re: [PATCH bpf v2] libbpf: Remove getsockopt() check for XDP_OPTIONS To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Alexei Starovoitov , Daniel Borkmann , Networking , bpf , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Yonghong Song Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Sep 16, 2019 at 6:05 AM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > The xsk_socket__create() function fails and returns an error if it cannot > get the XDP_OPTIONS through getsockopt(). However, support for XDP_OPTION= S > was not added until kernel 5.3, so this means that creating XSK sockets > always fails on older kernels. > > Since the option is just used to set the zero-copy flag in the xsk struct= , > and that flag is not really used for anything yet, just remove the > getsockopt() call until a proper use for it is introduced. > > Suggested-by: Yonghong Song > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > --- > v2: > - Remove the call entirely. > > tools/lib/bpf/xsk.c | 11 ----------- > 1 file changed, 11 deletions(-) > Who doesn't like removal of code?.. :) Acked-by: Andrii Nakryiko [...]