From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Dave Marchevsky <davemarchevsky@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>,
Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH v3 bpf-next 7/7] selftests/bpf: add trace_vprintk test prog
Date: Mon, 30 Aug 2021 17:04:51 -0700 [thread overview]
Message-ID: <CAEf4BzaZmtmtcS0g36o0CW9MkQ1UQ1qpo_8LWQj_-Tw2gk6qKA@mail.gmail.com> (raw)
In-Reply-To: <20210828052006.1313788-8-davemarchevsky@fb.com>
On Fri, Aug 27, 2021 at 10:20 PM Dave Marchevsky <davemarchevsky@fb.com> wrote:
>
> This commit adds a test prog for vprintk which confirms that:
> * bpf_trace_vprintk is writing to dmesg
> * __bpf_vprintk macro works as expected
> * >3 args are printed
>
> Approach and code are borrowed from trace_printk test.
>
> Signed-off-by: Dave Marchevsky <davemarchevsky@fb.com>
> ---
LGTM.
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> tools/testing/selftests/bpf/Makefile | 3 +-
> .../selftests/bpf/prog_tests/trace_vprintk.c | 65 +++++++++++++++++++
> .../selftests/bpf/progs/trace_vprintk.c | 25 +++++++
> 3 files changed, 92 insertions(+), 1 deletion(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/trace_vprintk.c
> create mode 100644 tools/testing/selftests/bpf/progs/trace_vprintk.c
>
[...]
prev parent reply other threads:[~2021-08-31 0:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-28 5:19 [PATCH v3 bpf-next 0/7] bpf: implement variadic printk helper Dave Marchevsky
2021-08-28 5:20 ` [PATCH v3 bpf-next 1/7] bpf: merge printk and seq_printf VARARG max macros Dave Marchevsky
2021-08-28 5:20 ` [PATCH v3 bpf-next 2/7] bpf: add bpf_trace_vprintk helper Dave Marchevsky
2021-08-30 23:35 ` Andrii Nakryiko
2021-09-03 8:00 ` Daniel Borkmann
2021-09-13 17:30 ` Dave Marchevsky
2021-08-28 5:20 ` [PATCH v3 bpf-next 3/7] libbpf: Modify bpf_printk to choose helper based on arg count Dave Marchevsky
2021-08-28 16:44 ` Dave Marchevsky
2021-08-28 5:20 ` [PATCH v3 bpf-next 4/7] libbpf: use static const fmt string in __bpf_printk Dave Marchevsky
2021-08-28 16:40 ` Dave Marchevsky
2021-08-29 16:57 ` Alexei Starovoitov
2021-08-31 0:36 ` Andrii Nakryiko
2021-08-31 0:37 ` Andrii Nakryiko
2021-08-28 5:20 ` [PATCH v3 bpf-next 5/7] bpftool: only probe trace_vprintk feature in 'full' mode Dave Marchevsky
2021-08-28 5:20 ` [PATCH v3 bpf-next 6/7] selftests/bpf: Migrate prog_tests/trace_printk CHECKs to ASSERTs Dave Marchevsky
2021-08-31 0:03 ` Andrii Nakryiko
2021-08-28 5:20 ` [PATCH v3 bpf-next 7/7] selftests/bpf: add trace_vprintk test prog Dave Marchevsky
2021-08-31 0:04 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzaZmtmtcS0g36o0CW9MkQ1UQ1qpo_8LWQj_-Tw2gk6qKA@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davemarchevsky@fb.com \
--cc=netdev@vger.kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).