From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3838C2D0D2 for ; Thu, 19 Dec 2019 00:54:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 79241218AC for ; Thu, 19 Dec 2019 00:54:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QafT74dz" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726616AbfLSAyk (ORCPT ); Wed, 18 Dec 2019 19:54:40 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:45463 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726518AbfLSAyk (ORCPT ); Wed, 18 Dec 2019 19:54:40 -0500 Received: by mail-qt1-f196.google.com with SMTP id l12so3542480qtq.12; Wed, 18 Dec 2019 16:54:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=A1Urs4RsdGYBrM/Z6psT6VFuLwM10wg/j95CYysxehQ=; b=QafT74dzFrnd5FdUc7ZzJZlaKDob9h1sLpE+XITJl54ZNHghpJtwWE7dcAkDiPKqhX lbx2ass0Ebil/RJsJijTZP3Js7drMaUnjPbmxgFL73QBDCWFkHtn8OnDLO7T2pW41HaO nPio5pHds+vJOAx6gQvrzuGJzL+qNvKkFbJWykiaU1K1mEuKaGQG3t4zi8vdh6XGuiH8 ypLnvN3hshsvmwhleq2fcjUpOqWlbaAbajNsGYxNtjdDW5RmWuUhZYXkTQHWs8eDVOTT MGsQrBruQfvqqAkjtR3vXomeOsANkyO9SBKlLxmJq+BKIo4lj4y7nlZPQGHhrrLkQvtV 3yhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=A1Urs4RsdGYBrM/Z6psT6VFuLwM10wg/j95CYysxehQ=; b=oZItB2ygC0o5F3mWiVDgyWz6NPeCRL5UaBjJJQ9vuXKBm4qLLtpWFDkiSBuZpy+ls6 qGcpg4LsYNzArxP1WZAAI0hxEqcy5Ni8sG/8DVdRM7nax4hqM9A3DxsP1+3CGFNf3IvV 9os9N2OSHx0IseynNSnTve2eC9QmN/IPBVJYQ+WjXZ9HtM8ZiK/UpOoPRCLYidmDxeCS i+Dl5VLY1e0C+UNUfTApaUgG0XZrletARbniOUOnDWrlSHu4VD/GXLQFxs/26wgzJdM2 KNPeV18mx4mgqyEEAVUNGZxySGvSSUIW/M42xOZhuN6L4MyA8Z6D1kBSUIxhssv7O76+ cbUw== X-Gm-Message-State: APjAAAWHNDtrueTMU6ZEgEFAq9nRow6hjQaCQ6RxOoEQguewxlVrlX/q RcABIhZfkIbqKgCQgtwKEq/+Ob6sJOo9HIR2Atc= X-Google-Smtp-Source: APXvYqxYXKEfiJIR4aztDlh6AyQHzq1Z+GedyfsEKbjzdal3F7FXFiTAT4o0HbCkk48AOkhwhMPm+llnUg8iQhz4gJw= X-Received: by 2002:ac8:4050:: with SMTP id j16mr4757783qtl.171.1576716879274; Wed, 18 Dec 2019 16:54:39 -0800 (PST) MIME-Version: 1.0 References: <20191211223344.165549-1-brianvv@google.com> <20191211223344.165549-9-brianvv@google.com> In-Reply-To: <20191211223344.165549-9-brianvv@google.com> From: Andrii Nakryiko Date: Wed, 18 Dec 2019 16:54:28 -0800 Message-ID: Subject: Re: [PATCH v3 bpf-next 08/11] libbpf: add libbpf support to batch ops To: Brian Vazquez Cc: Brian Vazquez , Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Yonghong Song , Stanislav Fomichev , Petar Penkov , Willem de Bruijn , open list , Networking , bpf Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Dec 11, 2019 at 2:35 PM Brian Vazquez wrote: > > From: Yonghong Song > > Added four libbpf API functions to support map batch operations: > . int bpf_map_delete_batch( ... ) > . int bpf_map_lookup_batch( ... ) > . int bpf_map_lookup_and_delete_batch( ... ) > . int bpf_map_update_batch( ... ) > > Signed-off-by: Yonghong Song > --- These libbpf APIs should use _opts approach from the get go to make them extensible, but preserving backwards/forward compatibility. Please take a look at one of few that are already using them (or follow Andrey's bpf_prog_attach work, as he's adding opts-based one at the moment). > tools/lib/bpf/bpf.c | 61 ++++++++++++++++++++++++++++++++++++++++ > tools/lib/bpf/bpf.h | 14 +++++++++ > tools/lib/bpf/libbpf.map | 4 +++ > 3 files changed, 79 insertions(+) > [...]