From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Jakub Sitnicki <jakub@cloudflare.com>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
kernel-team <kernel-team@cloudflare.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH bpf-next] selftests/bpf: Omit nodad flag when adding addresses to loopback
Date: Thu, 30 Jul 2020 12:30:53 -0700 [thread overview]
Message-ID: <CAEf4Bzan-B5ZTc6jSf3Dut7frEKq1XhYxg3sTtdKbds+mmmrrQ@mail.gmail.com> (raw)
In-Reply-To: <20200730125325.1869363-1-jakub@cloudflare.com>
On Thu, Jul 30, 2020 at 5:53 AM Jakub Sitnicki <jakub@cloudflare.com> wrote:
>
> Setting IFA_F_NODAD flag for IPv6 addresses to add to loopback is
> unnecessary. Duplicate Address Detection does not happen on loopback
> device.
>
> Also, passing 'nodad' flag to 'ip address' breaks libbpf CI, which runs in
> an environment with BusyBox implementation of 'ip' command, that doesn't
> understand this flag.
>
> Fixes: 0ab5539f8584 ("selftests/bpf: Tests for BPF_SK_LOOKUP attach point")
> Reported-by: Andrii Nakryiko <andrii.nakryiko@gmail.com>
> Signed-off-by: Jakub Sitnicki <jakub@cloudflare.com>
> ---
This fixes the nodad issue, thanks for quick fix!
Tested-by: Andrii Nakryiko <andrii@fb.com>
Acked-by: Andrii Nakryiko <andriin@fb.com>
But now I see these, which seems like you have a separate fix for, right?
(network_helpers.c:112: errno: Cannot assign requested address) Failed
to connect to server
run_lookup_test:FAIL:connect_fd_to_fd unexpected result err -1 errno 99
#14 cgroup_skb_sk_lookup:FAIL
udp_recv_send:FAIL:recvmsg failed
(/data/users/andriin/linux/tools/testing/selftests/bpf/prog_tests/sk_lookup.c:339:
errno: Resource temporarily unavailable) failed to receive
#73/14 UDP IPv4 redir and reuseport with conns:FAIL
> tools/testing/selftests/bpf/prog_tests/sk_lookup.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
> index 9bbd2b2b7630..379da6f10ee9 100644
> --- a/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
> +++ b/tools/testing/selftests/bpf/prog_tests/sk_lookup.c
> @@ -1290,8 +1290,8 @@ static void run_tests(struct test_sk_lookup *skel)
> static int switch_netns(void)
> {
> static const char * const setup_script[] = {
> - "ip -6 addr add dev lo " EXT_IP6 "/128 nodad",
> - "ip -6 addr add dev lo " INT_IP6 "/128 nodad",
> + "ip -6 addr add dev lo " EXT_IP6 "/128",
> + "ip -6 addr add dev lo " INT_IP6 "/128",
> "ip link set dev lo up",
> NULL,
> };
> --
> 2.25.4
>
next prev parent reply other threads:[~2020-07-30 19:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 12:53 [PATCH bpf-next] selftests/bpf: Omit nodad flag when adding addresses to loopback Jakub Sitnicki
2020-07-30 19:30 ` Andrii Nakryiko [this message]
2020-07-31 0:06 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4Bzan-B5ZTc6jSf3Dut7frEKq1XhYxg3sTtdKbds+mmmrrQ@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).