From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Rafael David Tinoco <rafaeldtinoco@ubuntu.com>
Cc: bpf <bpf@vger.kernel.org>, Daniel Borkmann <daniel@iogearbox.net>
Subject: Re: [PATCH v2 bpf-next] libbpf: add bpf object kern_version attribute setter
Date: Mon, 22 Mar 2021 12:46:28 -0700 [thread overview]
Message-ID: <CAEf4BzasP1GGccfBT9UFdC+AU775T+_vLAB4dv2cvE3Yb3SEfA@mail.gmail.com> (raw)
In-Reply-To: <4867B26C-E650-451B-9103-2FFB99DD03C4@ubuntu.com>
On Mon, Mar 22, 2021 at 12:36 PM Rafael David Tinoco
<rafaeldtinoco@ubuntu.com> wrote:
>
>
> >> +LIBBPF_API int bpf_object__set_kversion(struct bpf_object *obj, __u32
> >> kern_version);
> >
> > have you run libbpf's Makefile? It should have complained about
> > bpf_object__set_kversion symbol mismatches/etc. That means that this
> > API needs to be listed in libbpf.map file, please add it there (to
> > latest version, 0.4, and also preserve alphabetical order). Thanks.
>
> Alright, sending a v3 with changes. I had only static builds on
> my side and it didn’t run assigned linker version-script. Will
> include in my tests before further submissions.
>
>
Oh, I just noticed that you based your patch on top of Github
repository. libbpf sources actually live and are developed against
bpf-next kernel tree. Github repository is periodically synced from
kernel trees with a special script. Please do the development against
libbpf sources in the kernel tree (in tools/lib/bpf). You should also
try running selftests from tools/testing/selftests/bpf, especially
`sudo ./test_progs`. You'll need very recent Clang built from sources
to build and run everything. But at least you won't have to spend
efforts setting up your VM for testing, see vmtest.sh script in
selftests, added recently by KP Singh. It will build latest kernel and
will spin up qemu VM to run tests.
It's a bit of an upfront setup, but if you are intending to keep
contributing to libbpf and kernel, it's worth it :)
Also we have CI that would automatically test submitted patch sets
(see [0]). See also [1] for the build for your v2.
[0] https://github.com/kernel-patches/bpf/pulls
[1] https://travis-ci.com/github/kernel-patches/bpf/builds/220716720
>
prev parent reply other threads:[~2021-03-22 19:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-20 20:28 [PATCH v2 bpf-next] libbpf: add bpf object kern_version attribute setter Rafael David Tinoco
2021-03-22 17:06 ` Andrii Nakryiko
2021-03-22 19:36 ` Rafael David Tinoco
2021-03-22 19:46 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzasP1GGccfBT9UFdC+AU775T+_vLAB4dv2cvE3Yb3SEfA@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=rafaeldtinoco@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).