bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kernel Team <kernel-team@fb.com>,
	Jiong Wang <jiong.wang@netronome.com>,
	Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH bpf-next] tools/bpf: turn on llvm alu32 attribute by default
Date: Mon, 21 Oct 2019 20:01:04 -0700	[thread overview]
Message-ID: <CAEf4BzaugaCBgUFnavTtAzezY-Tz55bbfPcQFHOv9Z5VbMh-TQ@mail.gmail.com> (raw)
In-Reply-To: <20191022023226.2255076-1-yhs@fb.com>

On Mon, Oct 21, 2019 at 7:32 PM Yonghong Song <yhs@fb.com> wrote:
>
> llvm alu32 was introduced in llvm7:
>   https://reviews.llvm.org/rL325987
>   https://reviews.llvm.org/rL325989
> Experiments showed that in general performance
> is better with alu32 enabled:
>   https://lwn.net/Articles/775316/
>
> This patch turned on alu32 with no-flavor test_progs
> which is tested most often. The flavor test at
> no_alu32/test_progs can be used to test without
> alu32 enabled. The Makefile check for whether
> llvm supports '-mattr=+alu32 -mcpu=v3' is
> removed as llvm7 should be available for recent
> distributions and also latest llvm is preferred
> to run bpf selftests.
>
> Note that jmp32 is checked by -mcpu=probe and
> will be enabled if the host kernel supports it.
>
> Cc: Jiong Wang <jiong.wang@netronome.com>
> Cc: Andrii Nakryiko <andriin@fb.com>
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---

Sounds good to me, see minor nit below.

Acked-by: Andrii Nakryiko <andriin@fb.com>

>  tools/testing/selftests/bpf/Makefile | 26 ++++++++------------------
>  1 file changed, 8 insertions(+), 18 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> index 4ff5f4aada08..5a0bca2802fe 100644
> --- a/tools/testing/selftests/bpf/Makefile
> +++ b/tools/testing/selftests/bpf/Makefile
> @@ -32,15 +32,7 @@ TEST_GEN_PROGS = test_verifier test_tag test_maps test_lru_map test_lpm_map test
>         test_netcnt test_tcpnotify_user test_sock_fields test_sysctl test_hashmap \
>         test_cgroup_attach xdping
>
> -# Also test sub-register code-gen if LLVM has eBPF v3 processor support which
> -# contains both ALU32 and JMP32 instructions.
> -SUBREG_CODEGEN := $(shell echo "int cal(int a) { return a > 0; }" | \
> -                       $(CLANG) -target bpf -O2 -emit-llvm -S -x c - -o - | \
> -                       $(LLC) -mattr=+alu32 -mcpu=v3 2>&1 | \
> -                       grep 'if w')
> -ifneq ($(SUBREG_CODEGEN),)
> -TEST_GEN_PROGS += test_progs-alu32
> -endif
> +TEST_GEN_PROGS += test_progs-no_alu32

combine this with TEST_GEN_PROGS list above, it's not conditional anymore?

>
>  # Also test bpf-gcc, if present
>  ifneq ($(BPF_GCC),)
> @@ -179,7 +171,7 @@ endef
>  # $eval()) and pass control to DEFINE_TEST_RUNNER_RULES.
>  # Parameters:

[...]

  reply	other threads:[~2019-10-22  3:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-22  2:32 Yonghong Song
2019-10-22  3:01 ` Andrii Nakryiko [this message]
2019-10-22  3:49   ` Yonghong Song

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzaugaCBgUFnavTtAzezY-Tz55bbfPcQFHOv9Z5VbMh-TQ@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=jiong.wang@netronome.com \
    --cc=kernel-team@fb.com \
    --cc=yhs@fb.com \
    --subject='Re: [PATCH bpf-next] tools/bpf: turn on llvm alu32 attribute by default' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).