bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andriin@fb.com>, bpf <bpf@vger.kernel.org>,
	Networking <netdev@vger.kernel.org>,
	Alexei Starovoitov <ast@fb.com>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH v2 bpf-next 3/3] bpftool: add gen subcommand manpage
Date: Tue, 17 Dec 2019 21:22:41 -0800	[thread overview]
Message-ID: <CAEf4BzayD4Luv3=LivvJo3XK3+PNhjsd5T0B8p8JJ=T1dQspmg@mail.gmail.com> (raw)
In-Reply-To: <20191218030525.lhxuieceglidv3jf@ast-mbp.dhcp.thefacebook.com>

On Tue, Dec 17, 2019 at 7:05 PM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Tue, Dec 17, 2019 at 03:00:38PM -0800, Andrii Nakryiko wrote:
> > Add bpftool-gen.rst describing skeleton on the high level. Also include
> > a small, but complete, example BPF app (BPF side, userspace side, generated
> > skeleton) in example section to demonstrate skeleton API and its usage.
> >
> > Acked-by: Yonghong Song <yhs@fb.com>
> > Signed-off-by: Andrii Nakryiko <andriin@fb.com>
> > ---
> >  .../bpf/bpftool/Documentation/bpftool-gen.rst | 302 ++++++++++++++++++
>
> Please test it more thoroughly.
>
>   GEN      bpftool-gen.8
> bpftool-gen.rst:244: (ERROR/3) Unexpected indentation.
> bpftool-gen.rst:285: (ERROR/3) Unexpected indentation.

yep, my bad, didn't realize there is Makefile I'm supposed to run...

Fixed those two errors, reStructuredText is strict about code blocks.

>
> Patch 1 probably needs foo(void) instead of just foo().
> I think some compilers warn on it.
>

Added. Also simplified xxx__create_skeleton() a bit.

      reply	other threads:[~2019-12-18  5:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-17 23:00 [PATCH v2 bpf-next 0/3] Skeleton improvements and documentation Andrii Nakryiko
2019-12-17 23:00 ` [PATCH v2 bpf-next 1/3] bpftool, selftests/bpf: embed object file inside skeleton Andrii Nakryiko
2019-12-17 23:00 ` [PATCH v2 bpf-next 2/3] libbpf: remove BPF_EMBED_OBJ macro from libbpf.h Andrii Nakryiko
2019-12-17 23:00 ` [PATCH v2 bpf-next 3/3] bpftool: add gen subcommand manpage Andrii Nakryiko
2019-12-18  3:05   ` Alexei Starovoitov
2019-12-18  5:22     ` Andrii Nakryiko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEf4BzayD4Luv3=LivvJo3XK3+PNhjsd5T0B8p8JJ=T1dQspmg@mail.gmail.com' \
    --to=andrii.nakryiko@gmail.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andriin@fb.com \
    --cc=ast@fb.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=kernel-team@fb.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).