From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Yonghong Song <yhs@fb.com>, Andrii Nakryiko <andrii@kernel.org>,
Jiri Olsa <jolsa@kernel.org>, Sedat Dilek <sedat.dilek@gmail.com>,
Nathan Chancellor <natechancellor@gmail.com>,
Clang-Built-Linux ML <clang-built-linux@googlegroups.com>,
Fangrui Song <maskray@google.com>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH v5 0/3] Kbuild: DWARF v5 support
Date: Thu, 4 Feb 2021 16:17:35 -0800 [thread overview]
Message-ID: <CAEf4Bzb-dyTkYaQK_hzFdf6akd5SnBCR8Kt-k2ygrXRM1BmwTw@mail.gmail.com> (raw)
In-Reply-To: <CAKwvOdk7vkep157q4q4EamkdYWMLYzwM_7PYW1rdy=BFQye66w@mail.gmail.com>
On Thu, Feb 4, 2021 at 4:12 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> On Thu, Feb 4, 2021 at 4:07 PM Andrii Nakryiko
> <andrii.nakryiko@gmail.com> wrote:
> >
> > On Thu, Feb 4, 2021 at 4:04 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
> > >
> > > Moving a bunch of folks + lists to BCC.
> > >
> > > On Thu, Feb 4, 2021 at 3:54 PM Andrii Nakryiko
> > > <andrii.nakryiko@gmail.com> wrote:
> > > >
> > > > On Wed, Feb 3, 2021 at 7:13 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
> > > > >
> > > > > On Wed, Feb 3, 2021 at 6:58 PM Andrii Nakryiko
> > > > > <andrii.nakryiko@gmail.com> wrote:
> > > > > >
> > > > > > On Wed, Feb 3, 2021 at 5:31 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
> > > > > > >
> > > > > > > On Sun, Jan 17, 2021 at 12:14 PM Arnaldo Carvalho de Melo
> > > > > > > <acme@kernel.org> wrote:
> > > > > > > >
> > > > > > > > Em Fri, Jan 15, 2021 at 03:43:06PM -0800, Yonghong Song escreveu:
> > > > > > > > >
> > > > > > > > >
> > > > > > > > > On 1/15/21 3:34 PM, Nick Desaulniers wrote:
> > > > > > > > > > On Fri, Jan 15, 2021 at 3:24 PM Yonghong Song <yhs@fb.com> wrote:
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > On 1/15/21 1:53 PM, Sedat Dilek wrote:
> > > > > > > > > > > > En plus, I encountered breakage with GCC v10.2.1 and LLVM=1 and
> > > > > > > > > > > > CONFIG_DEBUG_INFO_DWARF4.
> > > > > > > > > > > > So might be good to add a "depends on !DEBUG_INFO_BTF" in this combination.
> > > > > > > > > >
> > > > > > > > > > Can you privately send me your configs that repro? Maybe I can isolate
> > > > > > > > > > it to a set of configs?
> > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > > > I suggested not to add !DEBUG_INFO_BTF to CONFIG_DEBUG_INFO_DWARF4.
> > > > > > > > > > > It is not there before and adding this may suddenly break some users.
> > > > > > > > > > >
> > > > > > > > > > > If certain combination of gcc/llvm does not work for
> > > > > > > > > > > CONFIG_DEBUG_INFO_DWARF4 with pahole, this is a bug bpf community
> > > > > > > > > > > should fix.
> > > > > > > > > >
> > > > > > > > > > Is there a place I should report bugs?
> > > > > > > > >
> > > > > > > > > You can send bug report to Arnaldo Carvalho de Melo <acme@kernel.org>,
> > > > > > > > > dwarves@vger.kernel.org and bpf@vger.kernel.org.
> > > > > > > >
> > > > > > > > I'm coming back from vacation, will try to read the messages and see if
> > > > > > > > I can fix this.
> > > > > > >
> > > > > > > IDK about DWARF v4; that seems to work for me. I was previously observing
> > > > > > > https://bugzilla.redhat.com/show_bug.cgi?id=1922698
> > > > > > > with DWARF v5. I just re-pulled the latest pahole, rebuilt, and no
> > > > > > > longer see that warning.
> > > > > > >
> > > > > > > I now observe a different set. I plan on attending "BPF office hours
> > > > > > > tomorrow morning," but if anyone wants a sneak peak of the errors and
> > > > > > > how to reproduce:
> > > > > > > https://gist.github.com/nickdesaulniers/ae8c9efbe4da69b1cf0dce138c1d2781
> > > > > > >
> > > > > >
> > > > > > Is there another (easy) way to get your patch set without the b4 tool?
> > > > > > Is your patch set present in some patchworks instance, so that I can
> > > > > > download it in mbox format, for example?
> > > > >
> > > > > $ wget https://lore.kernel.org/lkml/20210130004401.2528717-2-ndesaulniers@google.com/raw
> > > > > -O - | git am
> > > > > $ wget https://lore.kernel.org/lkml/20210130004401.2528717-3-ndesaulniers@google.com/raw
> > > > > -O - | git am
> > > > >
> > > > > If you haven't tried b4 yet, it's quite nice. Hard to go back. Lore
> > > > > also has mbox.gz links. Not sure about patchwork.
> > > > >
> > > >
> > > > Ok, I managed to apply that on linux-next, but I can't get past this:
> > > >
> > > > ld.lld: error: undefined symbol: pa_trampoline_start
> > > > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header)
> > >
> > > Thanks for testing and the report. Do you have a .config you can send
> > > me to reproduce?
> > >
> >
> > I followed your steps exactly, used olddefconfig. I've build with both
> > latest clang master and llvmorg-12.0.0-rc1 tag. This might be
> > something with my environment, I don't know.
>
> Perhaps, but "olddefconfig" is not reproducible for anyone else, ever.
> Please send me your .config that produced the errors.
>
Sorry, I meant defconfig + enable DWARF5 and BTF + then olddefconfig.
But I can send you config still a bit later.
> >
> > > >
> > > > ld.lld: error: undefined symbol: pa_trampoline_header
> > > > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header)
> > > >
> > > > ld.lld: error: undefined symbol: pa_trampoline_pgd
> > > > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header)
> > > > >>> referenced by trampoline_64.S:142 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:142)
> > > > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32)
> > > >
> > > > ld.lld: error: undefined symbol: pa_wakeup_start
> > > > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header)
> > > >
> > > > ld.lld: error: undefined symbol: pa_wakeup_header
> > > > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header)
> > > >
> > > > ld.lld: error: undefined symbol: pa_machine_real_restart_asm
> > > > >>> referenced by arch/x86/realmode/rm/header.o:(real_mode_header)
> > > >
> > > > ld.lld: error: undefined symbol: pa_startup_32
> > > > >>> referenced by trampoline_64.S:77 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:77)
> > > > >>> arch/x86/realmode/rm/trampoline_64.o:(trampoline_start)
> > > >
> > > > ld.lld: error: undefined symbol: pa_tr_flags
> > > > >>> referenced by trampoline_64.S:124 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:124)
> > > > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32)
> > > >
> > > > ld.lld: error: undefined symbol: pa_tr_cr4
> > > > >>> referenced by trampoline_64.S:138 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:138)
> > > > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32)
> > > >
> > > > ld.lld: error: undefined symbol: pa_tr_efer
> > > > >>> referenced by trampoline_64.S:146 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:146)
> > > > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32)
> > > > >>> referenced by trampoline_64.S:147 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:147)
> > > > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32)
> > > >
> > > > ld.lld: error: undefined symbol: pa_startup_64
> > > > >>> referenced by trampoline_64.S:161 (/data/users/andriin/linux/arch/x86/realmode/rm/trampoline_64.S:161)
> > > > >>> arch/x86/realmode/rm/trampoline_64.o:(startup_32)
> > > >
> > > > ld.lld: error: undefined symbol: pa_tr_gdt
> > > > >>> referenced by arch/x86/realmode/rm/trampoline_64.o:(tr_gdt)
> > > > >>> referenced by reboot.S:28 (/data/users/andriin/linux/arch/x86/realmode/rm/reboot.S:28)
> > > > >>> arch/x86/realmode/rm/reboot.o:(machine_real_restart_asm)
> > > >
> > > > ld.lld: error: undefined symbol: pa_machine_real_restart_paging_off
> > > > >>> referenced by reboot.S:34 (/data/users/andriin/linux/arch/x86/realmode/rm/reboot.S:34)
> > > > >>> arch/x86/realmode/rm/reboot.o:(machine_real_restart_asm)
> > > >
> > > > ld.lld: error: undefined symbol: pa_machine_real_restart_idt
> > > > >>> referenced by reboot.S:47 (/data/users/andriin/linux/arch/x86/realmode/rm/reboot.S:47)
> > > > >>> arch/x86/realmode/rm/reboot.o:(machine_real_restart_asm)
> > > >
> > > > ld.lld: error: undefined symbol: pa_machine_real_restart_gdt
> > > > >>> referenced by reboot.S:54 (/data/users/andriin/linux/arch/x86/realmode/rm/reboot.S:54)
> > > > >>> arch/x86/realmode/rm/reboot.o:(machine_real_restart_asm)
> > > > >>> referenced by arch/x86/realmode/rm/reboot.o:(machine_real_restart_gdt)
> > > >
> > > > ld.lld: error: undefined symbol: pa_wakeup_gdt
> > > > >>> referenced by arch/x86/realmode/rm/wakeup_asm.o:(wakeup_gdt)
> > > > CC arch/x86/mm/numa_64.o
> > > > CC arch/x86/mm/amdtopology.o
> > > > HOSTCC arch/x86/entry/vdso/vdso2c
> > > > make[4]: *** [arch/x86/realmode/rm/realmode.elf] Error 1
> > > > make[3]: *** [arch/x86/realmode/rm/realmode.bin] Error 2
> > > > make[2]: *** [arch/x86/realmode] Error 2
> > > > make[2]: *** Waiting for unfinished jobs....
> > > >
> > > >
> > > > Hopefully Arnaldo will have better luck.
> > > >
> > > >
> > > >
> > > > > >
> > > > > > >
> > > > > > > (FWIW: some other folks are hitting issues now with kernel's lack of
> > > > > > > DWARF v5 support: https://bugzilla.redhat.com/show_bug.cgi?id=1922707)
> > > > >
> > > > >
> > > > > --
> > > > > Thanks,
> > > > > ~Nick Desaulniers
> > >
> > >
> > >
> > > --
> > > Thanks,
> > > ~Nick Desaulniers
>
>
>
> --
> Thanks,
> ~Nick Desaulniers
next prev parent reply other threads:[~2021-02-05 0:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210115210616.404156-1-ndesaulniers@google.com>
[not found] ` <CA+icZUVp+JNq89uc_DyWC6zh5=kLtUr7eOxHizfFggnEVGJpqw@mail.gmail.com>
[not found] ` <7354583d-de40-b6b9-6534-a4f4c038230f@fb.com>
[not found] ` <CAKwvOd=5iR0JONwDb6ypD7dzzjOS3Uj0CjcyYqPF48eK4Pi90Q@mail.gmail.com>
[not found] ` <12b6c2ca-4cf7-4edd-faf2-72e3cb59c00e@fb.com>
[not found] ` <20210117201500.GO457607@kernel.org>
2021-02-04 1:31 ` [PATCH v5 0/3] Kbuild: DWARF v5 support Nick Desaulniers
2021-02-04 2:57 ` Andrii Nakryiko
2021-02-04 3:13 ` Nick Desaulniers
2021-02-04 23:54 ` Andrii Nakryiko
2021-02-05 0:04 ` Nick Desaulniers
2021-02-05 0:06 ` Andrii Nakryiko
2021-02-05 0:11 ` Nick Desaulniers
2021-02-05 0:17 ` Andrii Nakryiko [this message]
2021-02-04 8:42 ` Sedat Dilek
2021-02-04 8:59 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4Bzb-dyTkYaQK_hzFdf6akd5SnBCR8Kt-k2ygrXRM1BmwTw@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=acme@kernel.org \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=jolsa@kernel.org \
--cc=maskray@google.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).