From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1802C43331 for ; Thu, 2 Apr 2020 19:31:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A39062077D for ; Thu, 2 Apr 2020 19:31:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qtiL8TpB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390038AbgDBTbu (ORCPT ); Thu, 2 Apr 2020 15:31:50 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:40194 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389108AbgDBTbt (ORCPT ); Thu, 2 Apr 2020 15:31:49 -0400 Received: by mail-qk1-f193.google.com with SMTP id l25so5406980qki.7; Thu, 02 Apr 2020 12:31:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7I6mCCWO0NI2W9Hv1j2ODnDFaCT13IrYKH20fIeShyM=; b=qtiL8TpB80vLSxlF06cwi699QC+hLcU4dTsjnFf39v34jsBq6n0YTbCvrIiysheT5e 0iDCSMRVYq48fkYuwf7bD68+pxz7nQ74cvtLS3nYaJvZ/0obYVA+yCpyTHkq7mg+SMkQ 8f1FSy+tnNukU5h6Ew2OMmoz4LRVMG1Hy91BKk6TaIta7EWlN7Im+cdyphWu6CHElvxQ DI6YuEBFoXYi0/2CuK1IpIDQrK2TiGauWUnjjcXO3tbCTNXIgzwz0uY+weQQYLLwH4qV HMR0Up/BJT+QPMlycRANAHWJQePSQ3f0ZrLLcHFbcQdmKZVoe2t3s0mBEG/syw612Eko iu4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7I6mCCWO0NI2W9Hv1j2ODnDFaCT13IrYKH20fIeShyM=; b=iO1TQrhKCdF/9JFs2YDL9/No7/v6XhhhpIyEAYXS8pGNyk/CAzbzxZNA6zhW5b53+m j9MVAs49Glfx3KDHds3uGBCqrl9lc5QRk9LQUzDchlcd8E2qyf5qPlgJoZlGKX+omwY7 jLigLxRBYyfVWdIt4Vv5e/2qeqr1RlslH6p0bfPKFoyvHigfC9wKkJKjKjMLyS6ol22F 5TuwkZ0G/v9sAqG5eT5cXeufqpxav238zinQOK4uckvb0zRjOvzG7dpg+tke8dUzW2a0 5yk4sKCyc2qF/FPUDzKXCvFidatSFjuF/081XOOlXXN+/njRtCqk4xWeMvWX5ccbHtM3 PgIQ== X-Gm-Message-State: AGi0PuZ/8R61U06U7cm9WlGbf1ENSomLLiyjCQl6fi0u1Y2icIkbeLXH Cf0mdOWrL1zDBuFmxiClm/qsjEXx0NyOnGHW7e4= X-Google-Smtp-Source: APiQypK/ZbpMk9Dj0Hosok9jPEo30Su45nhINvZzVFcgTSuckkMrLuD8FT88jQlIP1pGI5Y6rlhHf2KJzp2UlipKQtA= X-Received: by 2002:a37:6411:: with SMTP id y17mr5397810qkb.437.1585855906945; Thu, 02 Apr 2020 12:31:46 -0700 (PDT) MIME-Version: 1.0 References: <202004010849.CC7E9412@keescook> <20200402153335.38447-1-slava@bacher09.org> In-Reply-To: From: Andrii Nakryiko Date: Thu, 2 Apr 2020 12:31:36 -0700 Message-ID: Subject: Re: [PATCH v4 bpf] kbuild: fix dependencies for DEBUG_INFO_BTF To: Slava Bacherikov Cc: Andrii Nakryiko , Kees Cook , bpf , open list , Jann Horn , Alexei Starovoitov , Daniel Borkmann , Kernel Hardening , Liu Yiding , kpsingh@google.com Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Apr 2, 2020 at 8:40 AM Slava Bacherikov wrote: > > > > 02.04.2020 18:33, Slava Bacherikov wrote: > > + depends on DEBUG_INFO || COMPILE_TEST > > Andrii are you fine by this ? I think it needs a good comment explaining this weirdness, at least. As I said, if there is no DEBUG_INFO, there is not point in doing DWARF-to-BTF conversion, even more -- it actually might fail, I haven't checked what pahole does in that case. So I'd rather drop GCC_PLUGIN_RANDSTRUCT is that's the issue here. DEBUG_INFO_SPLIT and DEBUG_INFO_REDUCED look good.