From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA3C5C352AA for ; Wed, 2 Oct 2019 03:18:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9EA0720818 for ; Wed, 2 Oct 2019 03:18:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IhspJJTC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727772AbfJBDSC (ORCPT ); Tue, 1 Oct 2019 23:18:02 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:36570 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726869AbfJBDSC (ORCPT ); Tue, 1 Oct 2019 23:18:02 -0400 Received: by mail-qt1-f194.google.com with SMTP id o12so24558994qtf.3; Tue, 01 Oct 2019 20:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DkfOxbgDr7IYTTOG7aOBpzhIL2nlLLSARJt6E+jjVXU=; b=IhspJJTCUMExojADiKr2W/9JHFM0sVu94fB83wkgQSgbKLnWmSlRyg7OBZ2wEQ6zFV yQRvkabi8UL5SqFLiyi6m1SPuhofDVvoaLHj2L0C5sx0uSySug1ibL7hNfGwvie86GJZ NPDitckoC0vaohlnMQmYOv3L4Gzsz5OKIx1/tNUWeRcIkDPLdjAYtuaq5ZnE6QFg6YmW b/ZHkclTCiwtvPp0BZ9CKTdn7ZAX02ne0DRLfidO2AcVv8LtvDpS+06BS7nGcH+8xBzy hX8Um03GcW04FPtVizP/47K82r2th84FqA7j86y5kLcTI9+J/FmtI6oDhKZ47QCYRd6j 1uUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DkfOxbgDr7IYTTOG7aOBpzhIL2nlLLSARJt6E+jjVXU=; b=k8/+Nuij7PdJh+FT1554aeGnvu1e0FUYGRpJejN6MVLrH8wAhMM+VilQcA94S7Ydj0 ++eCCbw0aItGuCT8cuoqLLIwbLcithTsKBz46XF1soHZ5K4VD102ktbHyp1/vUt33UXK D7VOX6XvBvSseVVPbVqmCVAp4wRtYpRxVGQfF0L4HJV52yejlOTVUXiaVw86FmBBqca6 CdWYMwe2Ac8voOHHcuqT0IfSC4jBUJzbWTQAPzDhrQYAX1PxOF6tJHOFtKCxAWNrtbx/ 5UckLgHmwAEOXyCzRX2bDAc/QEkDeRFyaVauscvdVQyOFFgyy5prtRXUbbiI3Mkde6fl WgJg== X-Gm-Message-State: APjAAAUY42veVtfPMZQsiJ/6OdarslG9yOBcJ9wTSkbl0jG8Fe+cnI8G p+UYUeTeMS+Uc5XwPGT5yCN/75xdG8bAx3MY/Nw= X-Google-Smtp-Source: APXvYqw3Go3PwnQpyK3Qdr1NGe4I3IFRGZ1+38xzNKIt7ca1IGQDBDYkiZWNeqhmy2nhKIfw6qymUYBbF/yKvCcGtUk= X-Received: by 2002:a0c:88f0:: with SMTP id 45mr1215730qvo.78.1569986280629; Tue, 01 Oct 2019 20:18:00 -0700 (PDT) MIME-Version: 1.0 References: <20191001173728.149786-1-brianvv@google.com> <20191001173728.149786-2-brianvv@google.com> In-Reply-To: <20191001173728.149786-2-brianvv@google.com> From: Andrii Nakryiko Date: Tue, 1 Oct 2019 20:17:49 -0700 Message-ID: Subject: Re: [PATCH bpf 1/2] selftests/bpf: test_progs: don't leak server_fd in tcp_rtt To: Brian Vazquez Cc: Brian Vazquez , Alexei Starovoitov , Daniel Borkmann , "David S . Miller" , Stanislav Fomichev , open list , Networking , bpf Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Oct 1, 2019 at 10:39 AM Brian Vazquez wrote: > > server_fd needs to be closed if pthread can't be created. > > Fixes: 8a03222f508b ("selftests/bpf: test_progs: fix client/server race > in tcp_rtt") Fixes tag hast to be on single line, no wrapping. Besides that: Acked-by: Andrii Nakryiko > Cc: Stanislav Fomichev > > Signed-off-by: Brian Vazquez > --- > tools/testing/selftests/bpf/prog_tests/tcp_rtt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/bpf/prog_tests/tcp_rtt.c b/tools/testing/selftests/bpf/prog_tests/tcp_rtt.c > index a82da555b1b02..f4cd60d6fba2e 100644 > --- a/tools/testing/selftests/bpf/prog_tests/tcp_rtt.c > +++ b/tools/testing/selftests/bpf/prog_tests/tcp_rtt.c > @@ -260,13 +260,14 @@ void test_tcp_rtt(void) > > if (CHECK_FAIL(pthread_create(&tid, NULL, server_thread, > (void *)&server_fd))) > - goto close_cgroup_fd; > + goto close_server_fd; > > pthread_mutex_lock(&server_started_mtx); > pthread_cond_wait(&server_started, &server_started_mtx); > pthread_mutex_unlock(&server_started_mtx); > > CHECK_FAIL(run_test(cgroup_fd, server_fd)); > +close_server_fd: > close(server_fd); > close_cgroup_fd: > close(cgroup_fd); > -- > 2.23.0.444.g18eeb5a265-goog >