From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Yonghong Song <yhs@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next v2] selftests/bpf: fix probe_user test failure with clang build kernel
Date: Tue, 28 Sep 2021 23:23:47 -0700 [thread overview]
Message-ID: <CAEf4Bzb9pCbwC0jncHM0F3py0xkmNc_XjOpUDH1Gm4=SQZ-4gA@mail.gmail.com> (raw)
In-Reply-To: <20210929033000.3711921-1-yhs@fb.com>
On Tue, Sep 28, 2021 at 8:30 PM Yonghong Song <yhs@fb.com> wrote:
>
> clang build kernel failed the selftest probe_user.
> $ ./test_progs -t probe_user
> $ ...
> $ test_probe_user:PASS:get_kprobe_res 0 nsec
> $ test_probe_user:FAIL:check_kprobe_res wrong kprobe res from probe read: 0.0.0.0:0
> $ #94 probe_user:FAIL
>
> The test attached to kernel function __sys_connect(). In net/socket.c, we have
> int __sys_connect(int fd, struct sockaddr __user *uservaddr, int addrlen)
> {
> ......
> }
> ...
> SYSCALL_DEFINE3(connect, int, fd, struct sockaddr __user *, uservaddr,
> int, addrlen)
> {
> return __sys_connect(fd, uservaddr, addrlen);
> }
>
> The gcc compiler (8.5.0) does not inline __sys_connect() in syscall entry
> function. But latest clang trunk did the inlining. So the bpf program
> is not triggered.
>
> To make the test more reliable, let us kprobe the syscall entry function
> instead. Note that x86_64, arm64 and s390 have syscall wrappers and they have
> to be handled specially.
>
> Signed-off-by: Yonghong Song <yhs@fb.com>
> ---
Applied to bpf-next, thanks.
> .../selftests/bpf/prog_tests/probe_user.c | 4 +--
> .../selftests/bpf/progs/test_probe_user.c | 28 +++++++++++++++++--
> 2 files changed, 28 insertions(+), 4 deletions(-)
>
[...]
prev parent reply other threads:[~2021-09-29 6:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 3:30 [PATCH bpf-next v2] selftests/bpf: fix probe_user test failure with clang build kernel Yonghong Song
2021-09-29 6:23 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4Bzb9pCbwC0jncHM0F3py0xkmNc_XjOpUDH1Gm4=SQZ-4gA@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).