From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9AF6C433E2 for ; Thu, 21 May 2020 22:10:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7457720814 for ; Thu, 21 May 2020 22:10:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oZBWHO6M" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730663AbgEUWKv (ORCPT ); Thu, 21 May 2020 18:10:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728701AbgEUWKu (ORCPT ); Thu, 21 May 2020 18:10:50 -0400 Received: from mail-qk1-x744.google.com (mail-qk1-x744.google.com [IPv6:2607:f8b0:4864:20::744]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70688C061A0E; Thu, 21 May 2020 15:10:50 -0700 (PDT) Received: by mail-qk1-x744.google.com with SMTP id n11so3428006qkn.8; Thu, 21 May 2020 15:10:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cY8bWJYAziC6DykutTES7fh6tr7JoLymaKn0aTQJgAA=; b=oZBWHO6MlDik/xfnpMWKRcWYwij9zTcWmbH9JuSmErAy7WB07e1TiF4dmrbYGrUrqE qfRPZudJxSJMEBbPTN71bDZdMWPCrJkbvu8G7XGoSbB0Kx34lsholiAsXcWwqN10JtAU iOCFxhlFjbpIHLaFaQJOBJAm68LmJFbPxQgZuVSKrSYMQSv1COiw2SUduvBiHjvsxcll SIQaO4hysm74vwz4ag6lDgfbljYQ6gTEO0Fln/KDw5G3EyoU4W7ba+OEbrCIfHydiwYn pXBLSiowmepxk4ogSoo4Ab+GKnE6jOcIyJP+L+T59F2DnNwEODLueAcdNSCaAW5tjuuP lBTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cY8bWJYAziC6DykutTES7fh6tr7JoLymaKn0aTQJgAA=; b=Iqwnql0sBCYQt1OKGCkBTzWU9dAPGEizA1ZYNv8/EOhJKWrYc3s8FETsQmO+1m2doJ ajvFEHK/IMMuNPL8j+Fyn4OkhKQDQpSdSVMSg8GdyR/o/6uZVjNizbkIbgvyNyYfaZ20 EeaBSEbO3zK13Y6hShEQ9LqrRRLaXxDlRwlkfdXwtB//o77OKHyUJy908AbESx2dHK1d 8gbCtIyzKBqWe0Bx2UvPeyaom2ACT4TpYB5kJOguFS5xc32L9HIc4wWQWWo5gavq5Lbl 21hGx+dA+EqbEVNsBHieTYwXDwPyonVSbmO5ZsXkMyK5bwCpj7+DrIj3OEun5+OADQ2v mr7Q== X-Gm-Message-State: AOAM533Sx79UpA27RUtHfZKZs/fLVMcdIHdsAT0D6fA52IcY5DL+/t4P BEVKaJrBgR9e1OQI4kEGoyquZU7vIXH3BxmYH4g= X-Google-Smtp-Source: ABdhPJzIXkJVvDhLwFX1ARUU8mtpCzq9VTmjBd6JQhlCMg9ID1AyioP6mhJJ2XBj6nVE6eoFrNsRgaLgO0TsCsULEdY= X-Received: by 2002:a05:620a:2049:: with SMTP id d9mr13093079qka.449.1590099049726; Thu, 21 May 2020 15:10:49 -0700 (PDT) MIME-Version: 1.0 References: <20200521152301.2587579-1-hch@lst.de> <20200521152301.2587579-13-hch@lst.de> In-Reply-To: <20200521152301.2587579-13-hch@lst.de> From: Andrii Nakryiko Date: Thu, 21 May 2020 15:10:38 -0700 Message-ID: Subject: Re: [PATCH 12/23] bpf: handle the compat string in bpf_trace_copy_string better To: Christoph Hellwig Cc: x86@kernel.org, Alexei Starovoitov , Daniel Borkmann , Masami Hiramatsu , Linus Torvalds , Andrew Morton , linux-parisc@vger.kernel.org, linux-um@lists.infradead.org, Networking , bpf , linux-mm@kvack.org, open list Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, May 21, 2020 at 8:24 AM Christoph Hellwig wrote: > > User the proper helper for kernel or userspace addresses based on > TASK_SIZE instead of the dangerous strncpy_from_unsafe function. > > Signed-off-by: Christoph Hellwig > --- Acked-by: Andrii Nakryiko > kernel/trace/bpf_trace.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > [...]