From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48653C4360C for ; Mon, 7 Oct 2019 02:24:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 167E72080F for ; Mon, 7 Oct 2019 02:24:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="a4OhdPIx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726822AbfJGCYg (ORCPT ); Sun, 6 Oct 2019 22:24:36 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:46782 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726797AbfJGCYg (ORCPT ); Sun, 6 Oct 2019 22:24:36 -0400 Received: by mail-qk1-f194.google.com with SMTP id 201so11181126qkd.13; Sun, 06 Oct 2019 19:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oQVDfdvpNuS9LR4+M9rlMhnhNaHXLejC2F/bb7MSgEE=; b=a4OhdPIxsRJdogOCym2L/I1Pyr+JQE1pHa9X1g1s78QKEgy5IYRMP98l37beHT3fmp +KgvSpY1RZI/6vzCZz25HIeBAae05KDjreapCmiTBhNVdl677epogwGfinx9uZJ/NfYL GLYI+30ybg9/D9jO87ISLpBDJFgyMLpUKrpqP8WoGV4cTOYcdKHP5wL7EpXRhubQrm0p Z92D6mOCjv6j/Fn3tHPNpZviJTGtkGvZkVb0TOJgI9NMHi+1cY4aQQAs1oFlQQbUoCbK 2U6+sNBr+YZGo8RmnLP5T5aA3XkPrgLcYTT8tP8J831b4NcNfpx3QbHOcLkylZRysGqd tJxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oQVDfdvpNuS9LR4+M9rlMhnhNaHXLejC2F/bb7MSgEE=; b=X34VK1HHoOCPvAdvm407ArM2vdWHG5dGRH1gDzgFJ7rrWzYOcpDstf5Aw3nChxKRZY sfpI3zm5/gUmJhHWRl2pCus8ADe3+4P5M9EUbeQIuugeOHhywRaTTBaeFgfhu8wwkP/a Evb66YsRWUh9od5P7ViXElQKraoyMlOeumFtZ1jgqusud1gPk30Rkjr4m7ZsmZLVsFhm xHdBaLALG4OxSd8pTART2YtBO0xJ6lhYNow6lzb4TeHLHWF8DOkqK4/maICw1sUMJJBZ xLwtzZlQOcyEFdzmmEohWhP3YMJ/8BMaWkJgiR6SPGtlselvpBedbyqKoTLWA32OnJSA pGWw== X-Gm-Message-State: APjAAAU6uJRAfo5GM14PQsh70IVmkmOpZ9QKzIKEgFLcUlQ+IlClDJKX Epp+TQtNIuMKFe1AIZXQvihHyfALbRwpPa+9R/8= X-Google-Smtp-Source: APXvYqwt1V+qOGtXOZp6pXd5iquuU7ZgbCZ+nKAk8RaJ//dLCQHrx31MOiuVQHe5XlBEYk4zkRwY90vmrbjsHWjgb4U= X-Received: by 2002:a37:98f:: with SMTP id 137mr22224385qkj.449.1570415074875; Sun, 06 Oct 2019 19:24:34 -0700 (PDT) MIME-Version: 1.0 References: <20191006054350.3014517-1-andriin@fb.com> <20191006054350.3014517-4-andriin@fb.com> In-Reply-To: From: Andrii Nakryiko Date: Sun, 6 Oct 2019 19:24:23 -0700 Message-ID: Subject: Re: [PATCH v3 bpf-next 3/3] libbpf: auto-generate list of BPF helper definitions To: Alexei Starovoitov Cc: Andrii Nakryiko , bpf , Network Development , Alexei Starovoitov , Daniel Borkmann , Quentin Monnet , Kernel Team Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Sun, Oct 6, 2019 at 5:32 PM Alexei Starovoitov wrote: > > On Sun, Oct 6, 2019 at 5:13 PM Andrii Nakryiko > wrote: > > > > On Sun, Oct 6, 2019 at 4:56 PM Alexei Starovoitov > > wrote: > > > > > > On Sat, Oct 5, 2019 at 10:46 PM Andrii Nakryiko wrote: > > > > > > > > Get rid of list of BPF helpers in bpf_helpers.h (irony...) and > > > > auto-generate it into bpf_helpers_defs.h, which is now included from > > > > bpf_helpers.h. > > > > > > > > Suggested-by: Alexei Starovoitov > > > > Signed-off-by: Andrii Nakryiko > > > > --- > > > > tools/lib/bpf/.gitignore | 1 + > > > > tools/lib/bpf/Makefile | 10 +- > > > > tools/lib/bpf/bpf_helpers.h | 264 +----------------------------------- > > > > 3 files changed, 10 insertions(+), 265 deletions(-) > > > > > > This patch doesn't apply to bpf-next. > > > > Yes, it has to be applied on top of bpf_helpers.h move patch set. I > > can bundle them together and re-submit as one patch set, but I don't > > think there were any remaining issues besides the one solved in this > > patch set (independence from any specific bpf.h UAPI), so that one can > > be applied as is. > > It looks to me that auto-gen of bpf helpers set is ready, > whereas move is till being debated. > I also would like to test autogen-ed .h in my environment first > before we move things around. Alright, will post v4 based on master with bpf_helpers.h still in selftests/bpf