From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FFB2CA9ECB for ; Thu, 31 Oct 2019 17:27:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 481A520650 for ; Thu, 31 Oct 2019 17:27:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HL1rCEoX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728928AbfJaR1Z (ORCPT ); Thu, 31 Oct 2019 13:27:25 -0400 Received: from mail-qk1-f196.google.com ([209.85.222.196]:41785 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728561AbfJaR1Y (ORCPT ); Thu, 31 Oct 2019 13:27:24 -0400 Received: by mail-qk1-f196.google.com with SMTP id m125so7810172qkd.8; Thu, 31 Oct 2019 10:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=iSUqkqDU/faH7JUBJ7EtgjdsgyN20noA3ne4iNgagfU=; b=HL1rCEoXI3ZE7uCXx4wHERSIV798yQnGNNqADhveQ7iWs6rKflQFHJOmeVVNSL7let UBSXvX528jKBESCZwiVJRRISm4FY0pJ1i3Q9luUFwhWELkvTKqZBsB8FywK0eG3mFSIp OwSSrz20bf1U+fvBJiEYRinWmAQ9pBtMvZeND+j2veSaHZmdVxaInl2q/sIDr4Jhenay hvF2iBMLXEOfENOe9Ppy1iOXVtZ5D/TadqYwJ0iA38J7U9YyRixLENVx2SGqTt/GbPNN eVZ31wMyKoGu/Y1Hy3ZIIvNQC5lAST2UiAVcdg4Qk35/UobpnhpbIxG2RGzZsapgLPcQ ShZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=iSUqkqDU/faH7JUBJ7EtgjdsgyN20noA3ne4iNgagfU=; b=Cc7cYQv4klLwnli1PHy2C3HmeJ67/Ww+flLgAMOxcsqLyXz+5hAkj2ABE94ABGrxK3 qK7Zs7vxx6FBM8zYsDBgKgejM0iSgVwJ9g2ZTtaB6qlNvL2JeAnBIwY5e95pjREh6EgB sRgKYxQpLZWNrveXxEb4VMEo1Ue1mStOjtMXrrq0JwLqq3gbZMuwK2gzg+mj9fXts5gH OXNQSVr58m13rU3APzkiz27UK8G930p25T3PgEn7yDy1dpEyFZBTlcVcMTjWmlrgn8zy 6MPsbZ+yKmIQh06xmZnVCNsAPR3jy3QszTWSxlFAuDqpFMVL5yQUIdwR3JjRE284LXi9 lYNg== X-Gm-Message-State: APjAAAWd/f7fLEHMf+Q0L+x2X/6tRxegzXKmUiD9foALs9s4WebUqXzh g7qIMzqQ13kndsqe+J/ej29sYTVTwI467oEyyn0= X-Google-Smtp-Source: APXvYqy6kbLgkJyURaQYfF1fdw/STSnhQvWvCgOE/TZK2rzQ7ZgPXpKV/RBRTfGAmlCI9x3SB77RPgiYNnkp+zgBxaM= X-Received: by 2002:a37:8f83:: with SMTP id r125mr1631089qkd.36.1572542843511; Thu, 31 Oct 2019 10:27:23 -0700 (PDT) MIME-Version: 1.0 References: <157237796219.169521.2129132883251452764.stgit@toke.dk> <157237796564.169521.10850494774906637330.stgit@toke.dk> In-Reply-To: <157237796564.169521.10850494774906637330.stgit@toke.dk> From: Andrii Nakryiko Date: Thu, 31 Oct 2019 10:27:12 -0700 Message-ID: Subject: Re: [PATCH bpf-next v4 3/5] libbpf: Move directory creation into _pin() functions To: =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= Cc: Daniel Borkmann , Alexei Starovoitov , Martin KaFai Lau , Song Liu , Yonghong Song , Jesper Dangaard Brouer , David Miller , Networking , bpf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Oct 29, 2019 at 12:39 PM Toke H=C3=B8iland-J=C3=B8rgensen wrote: > > From: Toke H=C3=B8iland-J=C3=B8rgensen > > The existing pin_*() functions all try to create the parent directory > before pinning. Move this check into the per-object _pin() functions > instead. This ensures consistent behaviour when auto-pinning is > added (which doesn't go through the top-level pin_maps() function), at th= e > cost of a few more calls to mkdir(). > > Signed-off-by: Toke H=C3=B8iland-J=C3=B8rgensen > --- Makes sense, thanks. Acked-by: Andrii Nakryiko > tools/lib/bpf/libbpf.c | 61 +++++++++++++++++++++++++++---------------= ------ > 1 file changed, 34 insertions(+), 27 deletions(-) > [...]