From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA0D6C433EF for ; Thu, 19 May 2022 04:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233765AbiESEm1 (ORCPT ); Thu, 19 May 2022 00:42:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233769AbiESEmZ (ORCPT ); Thu, 19 May 2022 00:42:25 -0400 Received: from mail-io1-xd31.google.com (mail-io1-xd31.google.com [IPv6:2607:f8b0:4864:20::d31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 115776005E; Wed, 18 May 2022 21:42:24 -0700 (PDT) Received: by mail-io1-xd31.google.com with SMTP id o190so4588030iof.10; Wed, 18 May 2022 21:42:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3p2RmX54Nl+qu0eLlsWLYFrSbWckEmVL0yWxFMlgwAA=; b=Ohmbav6isHcmvaBs0lKmpTanHP10xbh/uPwF9AWkcAMlnEiRUp1upwyCGCufmfGy/8 5db2cyJyJMTObsO/D41xiGiu7fbHqI01IYdfZeqyc7PmoplvtlGFZhLHpZvNj8vVR8Py leCDf/HfYu4J0sgJw5wt0f0g9vBl7e/kdver89gBRFrUlT9YV+YAAvOBpfBMw3jjqyby EY8+uoEjlGCdMAP8opZ3+XciFZJMFJ5Eo6FbQx+4v9V6XfanPSmpUyEtlQn3bWG4Exxt c9ulomqH+h4NKCSRlm789FzZ8t1Zxq4MpElHrAwY8Fy5SbbiOAu/5e6H99BNpMxsY/18 cEbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3p2RmX54Nl+qu0eLlsWLYFrSbWckEmVL0yWxFMlgwAA=; b=qJUqF72t6cKEfM58tfu8/9ZI2DOIix8mk6gFgXaI9aCzhcODz1EFRW1OVeb8rPmKvy rLn0bdUL3YCQiaPeOkqyiMPXYLLpGLI1Rwp4lgG0ah4cK9Id79pdkH2tjzwbfUDSlDKr Rk51x2aLEYbrhIubYH1+gmNs/FuEogn7L/evBnULC0aKXFlX4sln+ZbAoZXjwdbbLaBr mUgA0jj590SG2mTtxrZ8N7bAB/BxsIT6ixMjaxZS64MpFu2krAa/1YNvphmGQCLyvyCZ BUESUKBHIWcEgkXhwBm5Y90NgJV3r6MH0Jv3A9974jotXHjsyoGtuGuSg0BQtqPsgmZL TNgA== X-Gm-Message-State: AOAM532XKrim+4LCvaOFC0RzdPgwRVZ2h3RPr3YvOxG8G8g2Sm4MxxZy AyHSEHFmJfj5XqPlcmPobjlIcX3Rtee4iLVudXE= X-Google-Smtp-Source: ABdhPJxyfAkP3RamK35fbam2DglCrWDBTRYIhHWBrCHtJFJtFRXSXHaIfrTBTl6mBKsGOsTtHsxIvp8iJsUdhdeVPxo= X-Received: by 2002:a02:9f87:0:b0:32e:69ae:23df with SMTP id a7-20020a029f87000000b0032e69ae23dfmr1620828jam.237.1652935343429; Wed, 18 May 2022 21:42:23 -0700 (PDT) MIME-Version: 1.0 References: <20220503171437.666326-1-maximmi@nvidia.com> <13051d07-babc-1991-104b-f4969ac24b9b@nvidia.com> <48df5a60-f6e2-de05-1413-4511825511a5@nvidia.com> In-Reply-To: From: Andrii Nakryiko Date: Wed, 18 May 2022 21:42:12 -0700 Message-ID: Subject: Re: [PATCH bpf-next v9 0/5] New BPF helpers to accelerate synproxy To: Maxim Mikityanskiy , Ilya Leoshkevich Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Networking , Tariq Toukan , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , "David S. Miller" , Jakub Kicinski , Eric Dumazet , Hideaki YOSHIFUJI , David Ahern , Shuah Khan , Jesper Dangaard Brouer , Nathan Chancellor , Nick Desaulniers , Joe Stringer , Florent Revest , "open list:KERNEL SELFTEST FRAMEWORK" , =?UTF-8?B?VG9rZSBIw7hpbGFuZC1Kw7hyZ2Vuc2Vu?= , Kumar Kartikeya Dwivedi , Florian Westphal , pabeni@redhat.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, May 18, 2022 at 6:43 AM Maxim Mikityanskiy wrote: > > On 2022-05-16 20:17, Maxim Mikityanskiy wrote: > > On 2022-05-11 14:48, Maxim Mikityanskiy wrote: > >> On 2022-05-11 02:59, Andrii Nakryiko wrote: > >>> On Tue, May 10, 2022 at 12:21 PM Maxim Mikityanskiy > >>> wrote: > >>>> > >>>> On 2022-05-07 00:51, Andrii Nakryiko wrote: > >>>>> > >>>>> Is it expected that your selftests will fail on s390x? Please check > >>>>> [0] > >>>> > >>>> I see it fails with: > >>>> > >>>> test_synproxy:FAIL:ethtool -K tmp0 tx off unexpected error: 32512 > >>>> (errno 2) > >>>> > >>>> errno 2 is ENOENT, probably the ethtool binary is missing from the > >>>> s390x > >>>> image? When reviewing v6, you said you added ethtool to the CI image. > >>>> Maybe it was added to x86_64 only? Could you add it to s390x? > >>>> > >>> > >>> Could be that it was outdated in s390x, but with [0] just merged in it > >>> should have pretty recent one. > >> > >> Do you mean the image was outdated and didn't contain ethtool? Or > >> ethtool was in the image, but was outdated? If the latter, I would > >> expect it to work, this specific ethtool command has worked for ages. > > > > Hi Andrii, > > > > Could you reply this question? I need to understand whether I need to > > make any changes to the CI before resubmitting. > > I brought up a s390x VM to run the test locally, and there are two > issues with the latest (2022-05-09) s390x image: > > 1. It lacks stdbuf. stdbuf is used by > tools/testing/selftests/bpf/vmtest.sh to run any test, and this is > clearly broken. Hence two questions: > > 1.1. How does CI work without stdbuf in the image? I thought it used the > same vmtest.sh script, is that right? no, CI doesn't use vmtest.sh. vmtest.sh is an approximation of what CI is doing, but it doesn't share the code/scripts (it does use the same kernel config and VM image, though) > > 1.2. Who can add stdbuf to the image (to fix local runs)? > For s390x things I usually ping Ilya. Ilya, can you help here please? > 2. It lacks iptables needed by my test, so if I resubmit my series, it > will fail on the CI again. Who can add iptables to the image? Ditto, I'll defer to Ilya for this. > > I also compared the old (2021-03-24) and the new (2022-05-09) s390x > images, and ethtool was indeed added only after my submission, so that > explains the current CI error. > > > Thanks, > > Max >