From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Maxim Mikityanskiy <maximmi@nvidia.com>
Cc: bpf <bpf@vger.kernel.org>, "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
Networking <netdev@vger.kernel.org>,
"Tariq Toukan" <tariqt@nvidia.com>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Hideaki YOSHIFUJI" <yoshfuji@linux-ipv6.org>,
"David Ahern" <dsahern@kernel.org>,
"Shuah Khan" <shuah@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Joe Stringer" <joe@cilium.io>,
"Florent Revest" <revest@chromium.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
"Florian Westphal" <fw@strlen.de>,
pabeni@redhat.com
Subject: Re: [PATCH bpf-next v9 0/5] New BPF helpers to accelerate synproxy
Date: Fri, 6 May 2022 14:51:12 -0700 [thread overview]
Message-ID: <CAEf4BzbSO8oLK3_4Ecrx-c-o+Z6S8HMm3c_XQhZUQgpU8hfHoQ@mail.gmail.com> (raw)
In-Reply-To: <20220503171437.666326-1-maximmi@nvidia.com>
On Tue, May 3, 2022 at 10:14 AM Maxim Mikityanskiy <maximmi@nvidia.com> wrote:
>
> The first patch of this series is a documentation fix.
>
> The second patch allows BPF helpers to accept memory regions of fixed
> size without doing runtime size checks.
>
> The two next patches add new functionality that allows XDP to
> accelerate iptables synproxy.
>
> v1 of this series [1] used to include a patch that exposed conntrack
> lookup to BPF using stable helpers. It was superseded by series [2] by
> Kumar Kartikeya Dwivedi, which implements this functionality using
> unstable helpers.
>
> The third patch adds new helpers to issue and check SYN cookies without
> binding to a socket, which is useful in the synproxy scenario.
>
> The fourth patch adds a selftest, which includes an XDP program and a
> userspace control application. The XDP program uses socketless SYN
> cookie helpers and queries conntrack status instead of socket status.
> The userspace control application allows to tune parameters of the XDP
> program. This program also serves as a minimal example of usage of the
> new functionality.
>
> The last patch exposes the new helpers to TC BPF.
>
> The draft of the new functionality was presented on Netdev 0x15 [3].
>
> v2 changes:
>
> Split into two series, submitted bugfixes to bpf, dropped the conntrack
> patches, implemented the timestamp cookie in BPF using bpf_loop, dropped
> the timestamp cookie patch.
>
> v3 changes:
>
> Moved some patches from bpf to bpf-next, dropped the patch that changed
> error codes, split the new helpers into IPv4/IPv6, added verifier
> functionality to accept memory regions of fixed size.
>
> v4 changes:
>
> Converted the selftest to the test_progs runner. Replaced some
> deprecated functions in xdp_synproxy userspace helper.
>
> v5 changes:
>
> Fixed a bug in the selftest. Added questionable functionality to support
> new helpers in TC BPF, added selftests for it.
>
> v6 changes:
>
> Wrap the new helpers themselves into #ifdef CONFIG_SYN_COOKIES, replaced
> fclose with pclose and fixed the MSS for IPv6 in the selftest.
>
> v7 changes:
>
> Fixed the off-by-one error in indices, changed the section name to
> "xdp", added missing kernel config options to vmtest in CI.
>
> v8 changes:
>
> Properly rebased, dropped the first patch (the same change was applied
> by someone else), updated the cover letter.
>
> v9 changes:
>
> Fixed selftests for no_alu32.
>
> [1]: https://lore.kernel.org/bpf/20211020095815.GJ28644@breakpoint.cc/t/
> [2]: https://lore.kernel.org/bpf/20220114163953.1455836-1-memxor@gmail.com/
> [3]: https://netdevconf.info/0x15/session.html?Accelerating-synproxy-with-XDP
>
> Maxim Mikityanskiy (5):
> bpf: Fix documentation of th_len in bpf_tcp_{gen,check}_syncookie
> bpf: Allow helpers to accept pointers with a fixed size
> bpf: Add helpers to issue and check SYN cookies in XDP
> bpf: Add selftests for raw syncookie helpers
> bpf: Allow the new syncookie helpers to work with SKBs
>
Is it expected that your selftests will fail on s390x? Please check [0]
[0] https://github.com/kernel-patches/bpf/runs/6277764463?check_suite_focus=true#step:6:6130
> include/linux/bpf.h | 10 +
> include/net/tcp.h | 1 +
> include/uapi/linux/bpf.h | 88 +-
> kernel/bpf/verifier.c | 26 +-
> net/core/filter.c | 128 +++
> net/ipv4/tcp_input.c | 3 +-
> scripts/bpf_doc.py | 4 +
> tools/include/uapi/linux/bpf.h | 88 +-
> tools/testing/selftests/bpf/.gitignore | 1 +
> tools/testing/selftests/bpf/Makefile | 5 +-
> .../selftests/bpf/prog_tests/xdp_synproxy.c | 144 +++
> .../selftests/bpf/progs/xdp_synproxy_kern.c | 819 ++++++++++++++++++
> tools/testing/selftests/bpf/xdp_synproxy.c | 466 ++++++++++
> 13 files changed, 1761 insertions(+), 22 deletions(-)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/xdp_synproxy.c
> create mode 100644 tools/testing/selftests/bpf/progs/xdp_synproxy_kern.c
> create mode 100644 tools/testing/selftests/bpf/xdp_synproxy.c
>
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-05-06 21:51 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 17:14 [PATCH bpf-next v9 0/5] New BPF helpers to accelerate synproxy Maxim Mikityanskiy
2022-05-03 17:14 ` [PATCH bpf-next v9 1/5] bpf: Fix documentation of th_len in bpf_tcp_{gen,check}_syncookie Maxim Mikityanskiy
2022-05-03 17:14 ` [PATCH bpf-next v9 2/5] bpf: Allow helpers to accept pointers with a fixed size Maxim Mikityanskiy
2022-05-06 21:12 ` Andrii Nakryiko
2022-05-03 17:14 ` [PATCH bpf-next v9 3/5] bpf: Add helpers to issue and check SYN cookies in XDP Maxim Mikityanskiy
2022-05-06 21:19 ` Andrii Nakryiko
2022-05-10 19:20 ` Maxim Mikityanskiy
2022-05-11 0:03 ` Andrii Nakryiko
2022-05-03 17:14 ` [PATCH bpf-next v9 4/5] bpf: Add selftests for raw syncookie helpers Maxim Mikityanskiy
2022-05-06 21:34 ` Andrii Nakryiko
2022-05-10 19:21 ` Maxim Mikityanskiy
2022-05-11 0:10 ` Andrii Nakryiko
2022-05-11 11:48 ` Maxim Mikityanskiy
2022-05-03 17:14 ` [PATCH bpf-next v9 5/5] bpf: Allow the new syncookie helpers to work with SKBs Maxim Mikityanskiy
2022-05-06 21:39 ` Andrii Nakryiko
2022-05-06 21:51 ` Andrii Nakryiko [this message]
2022-05-10 19:21 ` [PATCH bpf-next v9 0/5] New BPF helpers to accelerate synproxy Maxim Mikityanskiy
2022-05-10 23:59 ` Andrii Nakryiko
2022-05-11 11:48 ` Maxim Mikityanskiy
2022-05-16 17:17 ` Maxim Mikityanskiy
2022-05-18 13:43 ` Maxim Mikityanskiy
2022-05-19 4:42 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbSO8oLK3_4Ecrx-c-o+Z6S8HMm3c_XQhZUQgpU8hfHoQ@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=hawk@kernel.org \
--cc=joe@cilium.io \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=maximmi@nvidia.com \
--cc=memxor@gmail.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=revest@chromium.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=tariqt@nvidia.com \
--cc=toke@toke.dk \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).