From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Veronika Kabatova <vkabatov@redhat.com>,
bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andriin@fb.com>
Subject: Re: [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory
Date: Mon, 27 Apr 2020 13:18:37 -0700 [thread overview]
Message-ID: <CAEf4BzbZPHyR5cqqM73QbppHMDuaRXCf9z08VZFcohdsQE2DGw@mail.gmail.com> (raw)
In-Reply-To: <20200427160240.5e66a954@carbon>
On Mon, Apr 27, 2020 at 7:03 AM Jesper Dangaard Brouer
<brouer@redhat.com> wrote:
>
> On Mon, 27 Apr 2020 15:29:40 +0200
> Veronika Kabatova <vkabatov@redhat.com> wrote:
>
> > $(OUTPUT)/runqslower makefile target doesn't actually create runqslower
> > binary in the $(OUTPUT) directory. As lib.mk expects all
> > TEST_GEN_PROGS_EXTENDED (which runqslower is a part of) to be present in
> > the OUTPUT directory, this results in an error when running e.g. `make
> > install`:
> >
> > rsync: link_stat "tools/testing/selftests/bpf/runqslower" failed: No
> > such file or directory (2)
> >
> > Copy the binary into the OUTPUT directory after building it to fix the
> > error.
> >
> > Signed-off-by: Veronika Kabatova <vkabatov@redhat.com>
> > ---
>
Did I miss original patch somewhere on bpf@vger mailing list?..
> Looks good to me
>
> Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
>
> > tools/testing/selftests/bpf/Makefile | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/testing/selftests/bpf/Makefile b/tools/testing/selftests/bpf/Makefile
> > index 7729892e0b04..cb8e7e5b2307 100644
> > --- a/tools/testing/selftests/bpf/Makefile
> > +++ b/tools/testing/selftests/bpf/Makefile
> > @@ -142,6 +142,7 @@ $(OUTPUT)/runqslower: $(BPFOBJ)
> > $(Q)$(MAKE) $(submake_extras) -C $(TOOLSDIR)/bpf/runqslower \
> > OUTPUT=$(SCRATCH_DIR)/ VMLINUX_BTF=$(VMLINUX_BTF) \
> > BPFOBJ=$(BPFOBJ) BPF_INCLUDE=$(INCLUDE_DIR)
> > + @cp $(SCRATCH_DIR)/runqslower $(OUTPUT)/runqslower
This should be AND'ed (&&) with $(MAKE) to not attempt copy on failed
make run. Also in general @cp should be $(Q)cp, but if you use $$ you
shouldn't need $(Q).
Also, just use $@ instead of $(OUTPUT)/runqslower:
cp $(SCRATCH_DIR)/runqslower $@
> >
> > $(TEST_GEN_PROGS) $(TEST_GEN_PROGS_EXTENDED): $(OUTPUT)/test_stub.o $(BPFOBJ)
>
> --
> Best regards,
> Jesper Dangaard Brouer
> MSc.CS, Principal Kernel Engineer at Red Hat
> LinkedIn: http://www.linkedin.com/in/brouer
>
next prev parent reply other threads:[~2020-04-27 20:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200427132940.2857289-1-vkabatov@redhat.com>
2020-04-27 14:02 ` [PATCH] selftests/bpf: Copy runqslower to OUTPUT directory Jesper Dangaard Brouer
2020-04-27 15:48 ` Jesper Dangaard Brouer
2020-04-27 20:18 ` Andrii Nakryiko [this message]
2020-04-28 14:40 ` Veronika Kabatova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbZPHyR5cqqM73QbppHMDuaRXCf9z08VZFcohdsQE2DGw@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andriin@fb.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=vkabatov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).