From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Dmitrii Banshchikov <me@ubique.spb.ru>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
john fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>, Andrey Ignatov <rdna@fb.com>
Subject: Re: [PATCH v2 bpf-next 2/4] bpf: Extract nullable reg type conversion into a helper function
Date: Wed, 10 Feb 2021 12:39:09 -0800 [thread overview]
Message-ID: <CAEf4Bzb_5nynJeeGRYiNT_XpBaEvMtcJKPq45DBz_x3Ywh2O7A@mail.gmail.com> (raw)
In-Reply-To: <20210209064421.15222-3-me@ubique.spb.ru>
On Mon, Feb 8, 2021 at 10:44 PM Dmitrii Banshchikov <me@ubique.spb.ru> wrote:
>
> Extract conversion from a register's nullable type to a type with a
> value. The helper will be used in mark_ptr_not_null_reg().
>
> Signed-off-by: Dmitrii Banshchikov <me@ubique.spb.ru>
> ---
LGMT.
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> v1 -> v2:
> - Simplify logic for is_null case
> - Add WARN_ON on an uknown nullable register type
> - Use switch instead of ifs
>
> kernel/bpf/verifier.c | 83 +++++++++++++++++++++++++++----------------
> 1 file changed, 52 insertions(+), 31 deletions(-)
>
[...]
next prev parent reply other threads:[~2021-02-10 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 6:44 [PATCH v2 bpf-next 0/4] Add support of pointer to struct in global functions Dmitrii Banshchikov
2021-02-09 6:44 ` [PATCH v2 bpf-next 1/4] bpf: Rename bpf_reg_state variables Dmitrii Banshchikov
2021-02-10 20:34 ` Andrii Nakryiko
2021-02-09 6:44 ` [PATCH v2 bpf-next 2/4] bpf: Extract nullable reg type conversion into a helper function Dmitrii Banshchikov
2021-02-10 20:39 ` Andrii Nakryiko [this message]
2021-02-09 6:44 ` [PATCH v2 bpf-next 3/4] bpf: Support pointers in global func args Dmitrii Banshchikov
2021-02-10 23:32 ` Andrii Nakryiko
2021-02-11 9:23 ` Dmitrii Banshchikov
2021-02-09 6:44 ` [PATCH v2 bpf-next 4/4] selftests/bpf: Add unit tests for pointers in global functions Dmitrii Banshchikov
2021-02-10 23:49 ` Andrii Nakryiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4Bzb_5nynJeeGRYiNT_XpBaEvMtcJKPq45DBz_x3Ywh2O7A@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=me@ubique.spb.ru \
--cc=rdna@fb.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).