From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AA9AC2D0A3 for ; Mon, 9 Nov 2020 20:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BAE66206E3 for ; Mon, 9 Nov 2020 20:23:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CdOi5J6Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729452AbgKIUXk (ORCPT ); Mon, 9 Nov 2020 15:23:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33506 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726952AbgKIUXk (ORCPT ); Mon, 9 Nov 2020 15:23:40 -0500 Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08F49C0613CF for ; Mon, 9 Nov 2020 12:23:40 -0800 (PST) Received: by mail-yb1-xb44.google.com with SMTP id c129so9437848yba.8 for ; Mon, 09 Nov 2020 12:23:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NXYuqbSb0umHjf/25ks2osRNJJwJ1GZalx75rhC58a4=; b=CdOi5J6QPaaxMvvUpeMtW7AR+nCbkvM9LyD8XiTejgNzXXIf0CdTU+8cSjHAbiTlaX cGwwBSNaAU+pNlRc8kUVdWGWewf4p67SPaLfnzEJfa1V5mPFiOJoUKD+vVWH5IXzh0rb wbZN22T5ZsHeJVRNIPOIOG0/BZabYQWfRQlqm3hj2EkYkkzMpv1QSZ3Olkia713GEoH2 RKpIAYHyE7Qrmcrzh8m8quUiboDcdIaag6qHTNzmvkanUbGgP3GNiWN3sSwfVWoE6ViK 3Mb9Ai9Gh+n9ma9eO8IpzdTJtMEu4EsNUZ+jAWOTnC0awCqH5GEeW2y7vp2bF0bI2jfL NlRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NXYuqbSb0umHjf/25ks2osRNJJwJ1GZalx75rhC58a4=; b=dBRwM+2rDMjzuYucUcKxaN7ZLjXLpiciLHiYREzRhqvvdv8Wc7OQwQ9Z0lk34hVOey NRUhtRxG2MU1mrDoXzmk3cF3k4Oj9CsIqUkoJ8Ba/Ya6YPJctZuEfDWmwkJa7SXjZYO8 7aUnsbdhroNi11mVzinnC61cmmQdiRE6RK0Ni+KGKrGRTtXpDdxkxc+K5CVvCXW2jTEJ taxNeAflg/XfM2gVgdfT5g3nUJLWBHpTfia5M0ScWbOg5JLh1wV4LoZ9tctgPvCr7txq E8R/kB9RZ+EgIiIPte/T5FxFOJPaWOHOPOsf15HPLQsSHulvyROLGuX8P77mM68urhRm 1OcA== X-Gm-Message-State: AOAM533TfRjrc1rMdqY4wfvqMRYlTPc+BICGiOlXmuw7QmQAA8qvmixB 8pccBg2OA7gh7mpOPba93+PlyWSb75jXIZegDaq7Ubq27Co= X-Google-Smtp-Source: ABdhPJxCsE+o+ljhhFhLwISH1L8p/zq1qqv7otU0h51ks2/RbYeyThX0I3nZw6yyvYXUrmNDK5oDMgHOopxebu1rU9E= X-Received: by 2002:a05:6902:72e:: with SMTP id l14mr19513640ybt.230.1604953419267; Mon, 09 Nov 2020 12:23:39 -0800 (PST) MIME-Version: 1.0 References: <20201109110929.1223538-1-jean-philippe@linaro.org> <20201109110929.1223538-6-jean-philippe@linaro.org> In-Reply-To: <20201109110929.1223538-6-jean-philippe@linaro.org> From: Andrii Nakryiko Date: Mon, 9 Nov 2020 12:23:28 -0800 Message-ID: Subject: Re: [PATCH bpf-next v2 5/6] tools/runqslower: Enable out-of-tree build To: Jean-Philippe Brucker Cc: Alexei Starovoitov , Daniel Borkmann , bpf , Martin Lau , Song Liu , Yonghong Song , Andrii Nakryiko , john fastabend , KP Singh Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Nov 9, 2020 at 3:11 AM Jean-Philippe Brucker wrote: > > Enable out-of-tree build for runqslower. Only set OUTPUT=.output if it > wasn't already set by the user. > > Signed-off-by: Jean-Philippe Brucker > --- > tools/bpf/runqslower/Makefile | 45 +++++++++++++++++++++++------------ > 1 file changed, 30 insertions(+), 15 deletions(-) > > diff --git a/tools/bpf/runqslower/Makefile b/tools/bpf/runqslower/Makefile > index bcc4a7396713..861f4dcde960 100644 > --- a/tools/bpf/runqslower/Makefile > +++ b/tools/bpf/runqslower/Makefile > @@ -1,15 +1,20 @@ > # SPDX-License-Identifier: (LGPL-2.1 OR BSD-2-Clause) > include ../../scripts/Makefile.include > > -OUTPUT := .output > +ifeq ($(OUTPUT),) > + OUTPUT = $(abspath .output)/ > +endif OUTPUT ?= .. didn't work? > + > CLANG ?= clang > LLC ?= llc > LLVM_STRIP ?= llvm-strip > -DEFAULT_BPFTOOL := $(OUTPUT)/sbin/bpftool > +BPFTOOL_OUTPUT := $(OUTPUT)bpftool/ > +DEFAULT_BPFTOOL := $(BPFTOOL_OUTPUT)bpftool > BPFTOOL ?= $(DEFAULT_BPFTOOL) > LIBBPF_SRC := $(abspath ../../lib/bpf) > -BPFOBJ := $(OUTPUT)/libbpf.a > -BPF_INCLUDE := $(OUTPUT) > +BPFOBJ_OUTPUT := $(OUTPUT)libbpf/ > +BPFOBJ := $(BPFOBJ_OUTPUT)libbpf.a > +BPF_INCLUDE := $(BPFOBJ_OUTPUT) > INCLUDES := -I$(OUTPUT) -I$(BPF_INCLUDE) -I$(abspath ../../lib) \ > -I$(abspath ../../include/uapi) > CFLAGS := -g -Wall > @@ -20,7 +25,6 @@ VMLINUX_BTF_PATHS := /sys/kernel/btf/vmlinux /boot/vmlinux-$(KERNEL_REL) > VMLINUX_BTF_PATH := $(or $(VMLINUX_BTF),$(firstword \ > $(wildcard $(VMLINUX_BTF_PATHS)))) > > -abs_out := $(abspath $(OUTPUT)) > ifeq ($(V),1) > Q = > else > @@ -36,9 +40,13 @@ all: runqslower > > runqslower: $(OUTPUT)/runqslower > > -clean: > +clean: $(DEFAULT_BPFTOOL)-clean $(BPFOBJ)-clean why separate targets for $(DEFAULT_BPFTOOL)-clean and $(BPFOBJ)-clean? Are they intended to be called separately? I don't think parallelization is that important for the clean up. Let's just keep all the cleaning in one place, not spreading it across Makefile? > $(call QUIET_CLEAN, runqslower) > - $(Q)rm -rf $(OUTPUT) runqslower > + $(Q)$(RM) -r $(BPFOBJ_OUTPUT) $(BPFTOOL_OUTPUT) > + $(Q)$(RM) $(OUTPUT)*.o $(OUTPUT)*.d > + $(Q)$(RM) $(OUTPUT)*.skel.h $(OUTPUT)vmlinux.h > + $(Q)$(RM) $(OUTPUT)runqslower > + $(Q)$(RM) -r .output > [...]