From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78FE6C433DB for ; Fri, 19 Mar 2021 04:16:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BF9164E89 for ; Fri, 19 Mar 2021 04:16:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233682AbhCSEQB (ORCPT ); Fri, 19 Mar 2021 00:16:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233658AbhCSEPx (ORCPT ); Fri, 19 Mar 2021 00:15:53 -0400 Received: from mail-yb1-xb31.google.com (mail-yb1-xb31.google.com [IPv6:2607:f8b0:4864:20::b31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CD74C06174A; Thu, 18 Mar 2021 21:15:53 -0700 (PDT) Received: by mail-yb1-xb31.google.com with SMTP id v107so4102220ybi.0; Thu, 18 Mar 2021 21:15:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gjpuME1q7jMrrX4TN68UeBFw2KeRypimn7z/8ID1ue0=; b=skHJYz+PMHSXnSso6Yd8Pt7+7pZScB5su1C7yM3iBynxPUXbmCYzL6lsn4v81a8mVf HEUaRT1jFdb6eK9QKxK/bufuRx6wCLZliI8Kf+M5welHIy51SdIgEeVnou3MoplbpCMd eLN1CYDwzkOy8tS9lisXVQANDO0WA/Qeii0ZJo9VC1SqHRvrwpY7VcEv3RLfn9BAs+6Y B2XvVBWiU5RIuwzlG8Yv8/+oYyEt00iQKKTfJkG+H8CgP4Qd9HrBDZqloxNpk9irmwB/ Wsn1j9TF7Efq+QT1LXHEAUZKaZzWigd1UNsK3F4tvfMPHKYuiYRpVxqSAZy1x4BRIkiN DraQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gjpuME1q7jMrrX4TN68UeBFw2KeRypimn7z/8ID1ue0=; b=l4cn4cSbexclN5I5vTdfxYSpPeyJbasMmHjTRzLqVcGbrHlVhYSdqZzGStJSGOtzMF TvNF6eUtK2YaC+QkXwwljcdRnO/8tLroJiJp2ZLjFKf5A4Vtl2NeYR3uxyQeyEODmU6p 4YwlTyWf/NCh8CyYicu7jqvSplLxV4XZpmwYgIvRJYzj5PNLA9nGz1ee9XkdQBrPbY1a pGSvnfoR8TWqrXJUr58AI3kRe5/VPpkvj24/j615J+vIZBrHlNUopE9RFFuO6lklQ7UM LnxrMo4D2ZLMNs4NZTubqxQvXYEiqHl41vYwH11izkNyvELNycm0svke4L0oBgZbf60H Fo+g== X-Gm-Message-State: AOAM532GjsCguwtyhkFzfeEAejDOYFebaGI1f6qo9jaWXAtQfmso242o bb7WxaYZ7NptQ9bkxX7/AWfI/C1Frbl3YmEG+mE= X-Google-Smtp-Source: ABdhPJzjghqHQhMELyaM0yaKnn2Mo/vjGm4BNo7TNIAKcreUoMreUnU0klytMdgHKRvCOFdElYItPYbmuDTd8IUKeSw= X-Received: by 2002:a25:40d8:: with SMTP id n207mr3740266yba.459.1616127352489; Thu, 18 Mar 2021 21:15:52 -0700 (PDT) MIME-Version: 1.0 References: <20210316011336.4173585-1-kafai@fb.com> <20210316011503.4181087-1-kafai@fb.com> In-Reply-To: <20210316011503.4181087-1-kafai@fb.com> From: Andrii Nakryiko Date: Thu, 18 Mar 2021 21:15:41 -0700 Message-ID: Subject: Re: [PATCH bpf-next 14/15] bpf: selftest: bpf_cubic and bpf_dctcp calling kernel functions To: Martin KaFai Lau Cc: bpf , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Networking Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Tue, Mar 16, 2021 at 12:02 AM Martin KaFai Lau wrote: > > This patch removes the bpf implementation of tcp_slow_start() > and tcp_cong_avoid_ai(). Instead, it directly uses the kernel > implementation. > > It also replaces the bpf_cubic_undo_cwnd implementation by directly > calling tcp_reno_undo_cwnd(). bpf_dctcp also directly calls > tcp_reno_cong_avoid() instead. > > Signed-off-by: Martin KaFai Lau > --- This is awesome. Acked-by: Andrii Nakryiko > tools/testing/selftests/bpf/bpf_tcp_helpers.h | 29 ++----------------- > tools/testing/selftests/bpf/progs/bpf_cubic.c | 6 ++-- > tools/testing/selftests/bpf/progs/bpf_dctcp.c | 22 ++++---------- > 3 files changed, 11 insertions(+), 46 deletions(-) > [...]