From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECCDEC433E0 for ; Mon, 15 Jun 2020 18:55:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C4C4A207D3 for ; Mon, 15 Jun 2020 18:55:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IOgvDhNZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731371AbgFOSzh (ORCPT ); Mon, 15 Jun 2020 14:55:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729124AbgFOSzg (ORCPT ); Mon, 15 Jun 2020 14:55:36 -0400 Received: from mail-qv1-xf42.google.com (mail-qv1-xf42.google.com [IPv6:2607:f8b0:4864:20::f42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9EC48C061A0E; Mon, 15 Jun 2020 11:55:36 -0700 (PDT) Received: by mail-qv1-xf42.google.com with SMTP id fc4so8276062qvb.1; Mon, 15 Jun 2020 11:55:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DTBEE8O+flfnTDcID6fw3qIeYva77rci1DenkZlJUeE=; b=IOgvDhNZZ/Ra63kjHD80BCrrPdgVrPnQ2POdr5g3f9gXeDNXx0co9Bt3iHtQANhGNM jIDRxQrjAuy28PtpHq4Yy9R0DY0G5i98RuMJmes0LcZfnae+SJ22TVPlt68D6Tapq7LH QLKZfpyk1A/ovY4N5bBFmhGa74Dym20SOdnK8RpJtBqunCek1pN1LOlrAwKgJySWJIoA vOh5J36E8oMyMkek3/ukB6iCtAEnrfjUSgY2YxhY3dWB0XY8/vBChzBo1dQHLtfS7Vap IiN3FEWpE+00lFUNDjeyRoXMSP/3WeBMhDo8r4kJIBhs4Ew1ljUYZeCJFTe4MC/EGcBl jbDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DTBEE8O+flfnTDcID6fw3qIeYva77rci1DenkZlJUeE=; b=TpnN+8c9Z1yz/syD8fAAgn/7vUj3q5XwlFdFvZ4bnjLHFnB5KDe70Hnjk/pL5SuZqs as2oQApnc/PVojd4rN27zzCrSPFBKb6S5mf2bnHRLpk2vueeyRay866HAoCHTNo9oLwi aW6SYQ1wIivqlj3vO4F0rw44jE2NejQZLQPiyTNhxJFz5/HLbIHNjnDdi7rdyjrDNX+O uodUiqKXY69cb+xXA5FnKcdk1W74FIJU6szAnXoW+juH/sagcWjNC5GKbhV8w2XOi+pP leg8dru024ScW7JlWiVmuQq8CvV5qlMsMYfTALfV5XyHtmjXVXv11rlXJ8DN8pdhlujk Y3kQ== X-Gm-Message-State: AOAM531LdH00NNAoJM14N2WirnbQDeoO2M2YcCxlFkWhbOksmue8gbIL DySCBOx885VZuhISFflTugZ192jfhs4OlNGYmM4= X-Google-Smtp-Source: ABdhPJzh9EwvKt4ruH7h5aplNvcYreWfmUZoQoLPG2HTPkgQ+e541yQdxQmiQttQCjQuuvZ8rs5Ayn+GCIkD8HmRYrs= X-Received: by 2002:ad4:4baa:: with SMTP id i10mr27198653qvw.163.1592247335714; Mon, 15 Jun 2020 11:55:35 -0700 (PDT) MIME-Version: 1.0 References: <20200612223150.1177182-1-andriin@fb.com> <20200612223150.1177182-2-andriin@fb.com> In-Reply-To: From: Andrii Nakryiko Date: Mon, 15 Jun 2020 11:55:24 -0700 Message-ID: Subject: Re: [RFC PATCH bpf-next 1/8] libbpf: generalize libbpf externs support To: Hao Luo Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Arnaldo Carvalho de Melo , Song Liu , Quentin Monnet Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Jun 15, 2020 at 9:44 AM Hao Luo wrote: > > Andrii, > > Thanks for this patch, it looks very nice! Decoupling kconfig from generic externs is much needed. > > On Fri, Jun 12, 2020 at 3:34 PM Andrii Nakryiko wrote: >> >> Switch existing Kconfig externs to be just one of few possible kinds of more >> generic externs. This refactoring is in preparation for ksymbol extern >> support, added in the follow up patch. There are no functional changes >> intended. >> >> Signed-off-by: Andrii Nakryiko >> --- >> tools/lib/bpf/libbpf.c | 332 ++++++++++++++++++++++++----------------- >> 1 file changed, 199 insertions(+), 133 deletions(-) >> [...] >> @@ -1443,12 +1454,12 @@ static int set_ext_value_tri(struct extern_desc *ext, void *ext_val, >> else /* value == 'n' */ >> *(enum libbpf_tristate *)ext_val = TRI_NO; >> break; >> - case EXT_CHAR: >> + case KCFG_CHAR: >> *(char *)ext_val = value; >> break; >> - case EXT_UNKNOWN: >> - case EXT_INT: >> - case EXT_CHAR_ARR: >> + case KCFG_UNKNOWN: >> + case KCFG_INT: >> + case KCFG_CHAR_ARR: >> default: >> pr_warn("extern %s=%c should be bool, tristate, or char\n", >> ext->name, value); > > > Very minor: pr_warn("kconfig extern ..."); I noticed you have one similar message changed below. > yeah, good catch, I'll update >> >> @@ -1458,12 +1469,12 @@ static int set_ext_value_tri(struct extern_desc *ext, void *ext_val, >> return 0; >> } >> for the future, please cut irrelevant parts of the patch, makes it easier to see where your replies are [...]