From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
"Maciek Fijałkowski" <maciejromanfijalkowski@gmail.com>,
"Daniel Borkmann" <borkmann@iogearbox.net>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"Björn Töpel" <bjorn.topel@intel.com>
Subject: Re: [PATCH bpf] samples/bpf: xdp_redirect_cpu fix missing tracepoint attach
Date: Fri, 20 Dec 2019 09:44:42 -0800 [thread overview]
Message-ID: <CAEf4BzbnL43Dka+qsTmUYvEnqSHOS72J+eE1qOnHCQdMAkR4Zg@mail.gmail.com> (raw)
In-Reply-To: <157685877642.26195.2798780195186786841.stgit@firesoul>
On Fri, Dec 20, 2019 at 8:19 AM Jesper Dangaard Brouer
<brouer@redhat.com> wrote:
>
> When sample xdp_redirect_cpu was converted to use libbpf, the
> tracepoints used by this sample were not getting attached automatically
> like with bpf_load.c. The BPF-maps was still getting loaded, thus
> nobody notice that the tracepoints were not updating these maps.
>
> This fix doesn't use the new skeleton code, as this bug was introduced
> in v5.1 and stable might want to backport this. E.g. Red Hat QA uses
> this sample as part of their testing.
>
> Fixes: bbaf6029c49c ("samples/bpf: Convert XDP samples to libbpf usage")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
Acked-by: Andrii Nakryiko <andriin@fb.com>
> samples/bpf/xdp_redirect_cpu_user.c | 59 +++++++++++++++++++++++++++++++++--
> 1 file changed, 55 insertions(+), 4 deletions(-)
>
[...]
next prev parent reply other threads:[~2019-12-20 17:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 16:19 [PATCH bpf] samples/bpf: xdp_redirect_cpu fix missing tracepoint attach Jesper Dangaard Brouer
2019-12-20 17:44 ` Andrii Nakryiko [this message]
2019-12-21 0:14 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbnL43Dka+qsTmUYvEnqSHOS72J+eE1qOnHCQdMAkR4Zg@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).