From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62879C433E0 for ; Wed, 1 Jul 2020 16:08:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3BFF3207FB for ; Wed, 1 Jul 2020 16:08:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="h9t4FMvM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732140AbgGAQI5 (ORCPT ); Wed, 1 Jul 2020 12:08:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731894AbgGAQI5 (ORCPT ); Wed, 1 Jul 2020 12:08:57 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F644C08C5C1; Wed, 1 Jul 2020 09:08:57 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id z63so22646444qkb.8; Wed, 01 Jul 2020 09:08:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yfNFt+1NYRpTdNsdjDpp8UbitSQNTJTzpWaLtRB9mUw=; b=h9t4FMvMdPuO26JCldinVZqqOLIE+W9hXp3+BB8L5pktqgEq/W5zPaxgY8NM6WLFuG oGSVty2n546bpKaE3EKoHtb1BJxL9JlVr87CLLaS1J/uC23D4K8tMDTdQxYlZudc45Tm vUP9s3kDf1P7TjUZg9ufzRLN9rUMTCR2L6spgUfGqZaU3jVW0w0jOqrhmH7kofVuKzeC HRFFrxWIBxLIeh2yAlxl4G0T/18jHCLgdFWI8Hw2IIK+qfJGEYCn5jlk/J1QsNRx/ndl 4BC3/vFcdXpKa/qrYTjL7Lef5e3kwRALeRKl4b+cYpxFRi867eh3HrkGrww034meLWjo zAow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yfNFt+1NYRpTdNsdjDpp8UbitSQNTJTzpWaLtRB9mUw=; b=ZS/Q6v1yFQPArnJs0rZxNFnvmFVb4VVEa8uqVGe6VplaOYyyHqQmHG8y5YlS8e90hc BmRy1lwtdo+YWGfYqSftnShdIxmcWMOyVtrYZReuW+dUvg6MR3agA6VTAlW+j0Pt5k11 uypj8x4GEAxBYTwezT9NzHef9IqPR0fUJXB3tlHV8XPrYfLlWY0/2Wl6s33V2bovP20V VHE1/S9swVqH66Zh7cZWRXzt+mD5k+D1eQtN+GIQV1/k19MpL8nOWqonwjLoOhdnsJwJ Hsx6D1u3y9Yn2Wy5JsJNLEAdGdUonzSeXTirDnfQ5le7ihHu9nJuTOOcL5fJAh16kGD+ VsHQ== X-Gm-Message-State: AOAM531ExDGcHepvlVW1Nq07ACvIuSEGXv0XGsO4CzUtbv7NrLkC3fFe isySHOb81C4VTx5wGnJXPEpz5tHBp4Dl5Q+k+Zg= X-Google-Smtp-Source: ABdhPJxFvmbu4B0LVCrCFTFmDgKU0FPzLNKZ/OSuDrfDgjNLSqBSxkXcJfUe48VftsidadEgxLJ8FM0aMpxuR/A0sOA= X-Received: by 2002:a05:620a:1666:: with SMTP id d6mr26197071qko.449.1593619736343; Wed, 01 Jul 2020 09:08:56 -0700 (PDT) MIME-Version: 1.0 References: <20200701064527.3158178-1-andriin@fb.com> In-Reply-To: From: Andrii Nakryiko Date: Wed, 1 Jul 2020 09:08:45 -0700 Message-ID: Subject: Re: [PATCH bpf-next 0/3] Strip away modifiers from BPF skeleton global variables To: Alexei Starovoitov Cc: Andrii Nakryiko , bpf , Network Development , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Anton Protopopov Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, Jul 1, 2020 at 8:02 AM Alexei Starovoitov wrote: > > On Tue, Jun 30, 2020 at 11:46 PM Andrii Nakryiko wrote: > > > > Fix bpftool logic of stripping away const/volatile modifiers for all global > > variables during BPF skeleton generation. See patch #1 for details on when > > existing logic breaks and why it's important. Support special .strip_mods=true > > mode in btf_dump. Add selftests validating that everything works as expected. > > Why bother with the flag? You mean btf_dump should do this always? That's a bit too invasive a change, I don't like it. > It looks like bugfix to me. It can be considered a bug fix for bpftool's skeleton generation, but it depends on non-trivial changes in libbpf, which are not bug fix per se, so should probably better go through bpf-next.