From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56517C43331 for ; Tue, 12 Nov 2019 02:01:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 14483206C3 for ; Tue, 12 Nov 2019 02:01:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EurjmYjx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726923AbfKLCBU (ORCPT ); Mon, 11 Nov 2019 21:01:20 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:41044 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726915AbfKLCBU (ORCPT ); Mon, 11 Nov 2019 21:01:20 -0500 Received: by mail-qk1-f196.google.com with SMTP id m125so13094989qkd.8; Mon, 11 Nov 2019 18:01:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6QHfjEMIm9urGXzP9jnnx6VoybT/fMEP6wIaodxgVPw=; b=EurjmYjxpbuV8ghL4eiYHXNhCWh9st/DLHN1PXeHD2lamfdww2ufSez/EDoYiHyKWG MigpwA4okUDgqM25ErFmX/njSh03swEW+9Fucq1c5T4sL+f1941EXJNMQmh+F3owAnPG VTt8ERXQvOZaLg6AX0HGwIStKgK1aYeJZ4dE2erXiWxwEssyWloCmY0JygjFVtdMDrdj Kn2Nb7XG3rgCgS33JgsqXDq71G9XEBCEgrm3lKN+U2hDE6USZ5YFeIFu89bFSAvcIw2/ /XgGAG5uhOnjRJMeQyXdi5Ar26KIcQTgqfcD7RFazgJEAJQCQWGlYrTeHV2F8+FTMgH5 7jqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6QHfjEMIm9urGXzP9jnnx6VoybT/fMEP6wIaodxgVPw=; b=eLT6DSa5cCLfvzUBqKCwYdgj7oL8j45xhIPI76Ou4j5GK4itVw5eUeuI6h4HG/PiK6 +6Vf5/zU/JoRaFqD1wH1+GYtUcRuENil9M5jsnVNquRM4anu28oMQ3+c7oYYyNWXR1KF IfzFHnm7w6pZq72j+ZW4PH6D/PUrxQKRYJIwd9Ahenaca12vpoVJqJ33y/bMSKy1Jcap /RNDmWmr3jbVsbRugZh9W7fUCCOVODKMxLwmlASUNgyuuvFP2eURW79dR3ewO8xwBjPo snCWENOf+caUUmjyz6C1/Igskx9TELTmIrdnHHGQEeIJ3AORGTWdR/Z+OKQivVZH+ai4 lEkg== X-Gm-Message-State: APjAAAUpsJKwvsd1s9r3A8yTybl3qMMNiEDQO3p9ykt+Y7yIRCSjsDV+ GcHdJT4vT2NhWKpmRC1jbM5TrEq3s8OlHEi3Jv4= X-Google-Smtp-Source: APXvYqwF9GoCLMkJf2Th24nG1MqMbDFv+BhkSfh2hB8MBlQHCkg1dmSuVKWzck4jq8cmXQaYG++hwzFRZSd+4+/NY4U= X-Received: by 2002:a37:b3c4:: with SMTP id c187mr13752989qkf.36.1573524079217; Mon, 11 Nov 2019 18:01:19 -0800 (PST) MIME-Version: 1.0 References: <20191109080633.2855561-1-andriin@fb.com> <20191109080633.2855561-2-andriin@fb.com> <20191111103916.0af3ac5b@cakuba> In-Reply-To: <20191111103916.0af3ac5b@cakuba> From: Andrii Nakryiko Date: Mon, 11 Nov 2019 18:01:07 -0800 Message-ID: Subject: Re: [PATCH v2 bpf-next 1/3] bpf: add mmap() support for BPF_MAP_TYPE_ARRAY To: Jakub Kicinski Cc: Andrii Nakryiko , bpf , Networking , Alexei Starovoitov , Daniel Borkmann , Kernel Team , Rik van Riel , Johannes Weiner Content-Type: text/plain; charset="UTF-8" Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Mon, Nov 11, 2019 at 10:39 AM Jakub Kicinski wrote: > > On Sat, 9 Nov 2019 00:06:30 -0800, Andrii Nakryiko wrote: > > @@ -74,7 +78,7 @@ static struct bpf_map *array_map_alloc(union bpf_attr *attr) > > int ret, numa_node = bpf_map_attr_numa_node(attr); > > u32 elem_size, index_mask, max_entries; > > bool unpriv = !capable(CAP_SYS_ADMIN); > > - u64 cost, array_size, mask64; > > + u64 cost, array_size, data_size, mask64; > > struct bpf_map_memory mem; > > struct bpf_array *array; > > > > Please don't break reverse xmas tree where it exists. alright, will move it up