bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Oskolkov <posk@posk.io>
To: Jiri Benc <jbenc@redhat.com>
Cc: bpf <bpf@vger.kernel.org>, linux-netdev <netdev@vger.kernel.org>,
	Peter Oskolkov <posk@google.com>
Subject: Re: [PATCH bpf] selftests/bpf: More compatible nc options in test_tc_edt
Date: Fri, 18 Oct 2019 11:51:44 -0700	[thread overview]
Message-ID: <CAFTs51Xh=LjQqzS_YFaG6Z-OdOYLyXeSes+aWxkrPaBx_po_bg@mail.gmail.com> (raw)
In-Reply-To: <f5bf07dccd8b552a76c84d49e80b86c5aa071122.1571400024.git.jbenc@redhat.com>

On Fri, Oct 18, 2019 at 5:00 AM Jiri Benc <jbenc@redhat.com> wrote:
>
> Out of the three nc implementations widely in use, at least two (BSD netcat
> and nmap-ncat) do not support -l combined with -s. Modify the nc invocation
> to be accepted by all of them.
>
> Fixes: 7df5e3db8f63 ("selftests: bpf: tc-bpf flow shaping with EDT")
> Cc: Peter Oskolkov <posk@google.com>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
> ---
>  tools/testing/selftests/bpf/test_tc_edt.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_tc_edt.sh b/tools/testing/selftests/bpf/test_tc_edt.sh
> index f38567ef694b..daa7d1b8d309 100755
> --- a/tools/testing/selftests/bpf/test_tc_edt.sh
> +++ b/tools/testing/selftests/bpf/test_tc_edt.sh
> @@ -59,7 +59,7 @@ ip netns exec ${NS_SRC} tc filter add dev veth_src egress \
>
>  # start the listener
>  ip netns exec ${NS_DST} bash -c \
> -       "nc -4 -l -s ${IP_DST} -p 9000 >/dev/null &"
> +       "nc -4 -l -p 9000 >/dev/null &"

The test passes with the regular linux/debian nc. If it passes will the rest,

Acked-by: Peter Oskolkov <posk@google.com>

>  declare -i NC_PID=$!
>  sleep 1
>
> --
> 2.18.1
>

  reply	other threads:[~2019-10-18 18:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-18 12:00 [PATCH bpf] selftests/bpf: More compatible nc options in test_tc_edt Jiri Benc
2019-10-18 18:51 ` Peter Oskolkov [this message]
2019-10-18 20:35 ` Daniel Borkmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAFTs51Xh=LjQqzS_YFaG6Z-OdOYLyXeSes+aWxkrPaBx_po_bg@mail.gmail.com' \
    --to=posk@posk.io \
    --cc=bpf@vger.kernel.org \
    --cc=jbenc@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=posk@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).