From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E9BC4363D for ; Wed, 30 Sep 2020 23:16:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DFF8E20848 for ; Wed, 30 Sep 2020 23:16:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pw30qPK5" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732165AbgI3XQH (ORCPT ); Wed, 30 Sep 2020 19:16:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58244 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732128AbgI3XP4 (ORCPT ); Wed, 30 Sep 2020 19:15:56 -0400 Received: from mail-ej1-x644.google.com (mail-ej1-x644.google.com [IPv6:2a00:1450:4864:20::644]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95B21C0613D0 for ; Wed, 30 Sep 2020 16:15:54 -0700 (PDT) Received: by mail-ej1-x644.google.com with SMTP id j11so5324717ejk.0 for ; Wed, 30 Sep 2020 16:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7NtR8Af5mbsnJurMxCwsT1Qowr1kj5d6Fb9bCF6cp9U=; b=pw30qPK5acsamYkNqSxjNDViySQWHBINt4pgak0I6oN9BDI2yBlrAFZ7PYx4lB9T7Z HSrQSc1m3X5dyYBHGoAmUL/eyRBqa4xUzqWaH7PPDscJ1Ae2Zj08246uHc//sWeYewck 53vyf72uWa6WOVK8gjf/qYZCkdVIPELn9Fli/FR8OcSgczqjUafRdcOgWuLdh2XYL6bq 9yo/Wp/DaQt/aD69hGgaaI814TkUEQgm3uAVeUNGSM2dH5tXzayx9rjzSQhya0noqQzX nlRgaN7NdT0G8csaLaoJ6G5fx7nFre50Qp1dtsv6Mz5h6A9s/9Z2tcPJRzbi7ACupfCp 9b6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7NtR8Af5mbsnJurMxCwsT1Qowr1kj5d6Fb9bCF6cp9U=; b=WN/AGFcPuIYrjcnheFa7+wBleYpcRmz8ob7LKwLxX3Ki+3hyi6YeBniouddAICYOVI BfUsiLHkqpoUudqQC8Wi1K8/bzvjOUbvTUXTzMsgMC6Unnv/5zPO1j0p59jthnYd0lQW m7hTreRaHtcFLNr6vIyIuTtz3Ai/J0bhPK/PJz2Db1deVapNbXzeeVtPCj2dHYPmHl46 FPuvwmgTff6NIbK0gI6INv0hPxeB7RVjJiEZcUD81A5N2u1/Bo8fBvVehljrwCfltr6P xK9u5hyUiXnLIVAAU/Bpywkxz3yMo3uNoiT1LtbzICZewjiwbjq+UaFm7A9AB+nPkohl xnsw== X-Gm-Message-State: AOAM533JTywFV713XGfoBQRhn7zAz3ElT2rHwMWhrlRxukHIJi+kZ/6m UIf0V8vuixsjRVvv3CPsbtVx88SX2uR1Y0QUXumFCg== X-Google-Smtp-Source: ABdhPJy9ik0VDeL+cu6VtcVQ/+hDXc248kSGiAvJX6+w/4UrgfNPOUORWDEnAsA6QMlkA5tDhYvPNM8Qid/ySYOAIHQ= X-Received: by 2002:a17:906:980f:: with SMTP id lm15mr5403777ejb.184.1601507753153; Wed, 30 Sep 2020 16:15:53 -0700 (PDT) MIME-Version: 1.0 References: <484392624b475cc25d90a787525ede70df9f7d51.1601478774.git.yifeifz2@illinois.edu> <202009301418.20BA0CE33@keescook> <202009301549.17D3DE5@keescook> In-Reply-To: <202009301549.17D3DE5@keescook> From: Jann Horn Date: Thu, 1 Oct 2020 01:15:26 +0200 Message-ID: Subject: Re: [PATCH v3 seccomp 1/5] x86: Enable seccomp architecture tracking To: Kees Cook Cc: YiFei Zhu , Linux Containers , YiFei Zhu , bpf , kernel list , Aleksa Sarai , Andrea Arcangeli , Andy Lutomirski , David Laight , Dimitrios Skarlatos , Giuseppe Scrivano , Hubertus Franke , Jack Chen , Josep Torrellas , Tianyin Xu , Tobin Feldman-Fitzthum , Tycho Andersen , Valentin Rothberg , Will Drewry Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Oct 1, 2020 at 12:53 AM Kees Cook wrote: > > On Wed, Sep 30, 2020 at 11:33:15PM +0200, Jann Horn wrote: > > On Wed, Sep 30, 2020 at 11:21 PM Kees Cook wrote: > > > On Wed, Sep 30, 2020 at 10:19:12AM -0500, YiFei Zhu wrote: > > > > From: Kees Cook > > > > > > > > Provide seccomp internals with the details to calculate which syscall > > > > table the running kernel is expecting to deal with. This allows for > > > > efficient architecture pinning and paves the way for constant-action > > > > bitmaps. > > > > > > > > Signed-off-by: Kees Cook > > > > [YiFei: Removed x32, added macro for nr_syscalls] > > > > Signed-off-by: YiFei Zhu > > [...] > > > But otherwise, yes, looks good to me. For this patch, I think the S-o-b chain is probably more > > > accurately captured as: > > > > > > Signed-off-by: Kees Cook > > > Co-developed-by: YiFei Zhu > > > Signed-off-by: YiFei Zhu > > > > (Technically, https://www.kernel.org/doc/html/latest/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by > > says that "every Co-developed-by: must be immediately followed by a > > Signed-off-by: of the associated co-author" (and has an example of how > > that should look).) > > Right, but it is not needed for the commit author (here, the From:), > the second example given in the docs shows this: Aah, right. Nevermind, sorry for the noise.