From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7093DC4727D for ; Thu, 24 Sep 2020 19:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23B5123899 for ; Thu, 24 Sep 2020 19:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="nW6H9Ez9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728680AbgIXTTB (ORCPT ); Thu, 24 Sep 2020 15:19:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727254AbgIXTTB (ORCPT ); Thu, 24 Sep 2020 15:19:01 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2B48C0613D3 for ; Thu, 24 Sep 2020 12:19:00 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id nw23so332374ejb.4 for ; Thu, 24 Sep 2020 12:19:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rL+0r4nsYsaTnfsp4nKpvqpdZr9u7FgIPOgyMKNt8zc=; b=nW6H9Ez9qPwsgMVuKmXTOIP47WKziOB7h4ORZWYHlPlZmcmBaz4bHW4IU2YbZsB5hb PKuFmofW4Zkf/3SgserbbqW7aN+s9iDgZbxr9QF0a+XDOyQauEYVVSL/KnakazhwL9D4 UwrK4zx1t+sRU7ddaxgI/KYI1iAsm8WFKpkl5/8qG0kYIZDGGh7V/oUZv2AqOwFcMrap DSM8JWFJFnMD99cr4rEr96PRqnbogR9L4C448SM/gzvmeyrVEi1RWLhCxTScPIvkxccL bhyh0HeLsDXVkXxuvggdeni2CgIY8uiKUYP88tL+eo2IucDIcb5mZtmgFAHFmYwp06Dk cHcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rL+0r4nsYsaTnfsp4nKpvqpdZr9u7FgIPOgyMKNt8zc=; b=nHdtvv/jGfAXJy79Pc4X3AOi/XJHzUGz4qAuHVtcjnPN8vdPNtPfsU++pM6ZguDshn TKcSEbZKp1ou/xUbkNR8q2sNbKwaMO0JG8NNmlGCXJ4HCkKlOCifFKIb6ypO0A+6LT+f GzUYdcS/yujlSFYpNH6a1tDHYD2FOSWBldVcBRi+13oskLd70o5zM8KFKFASi24L0f4t jWGEp7MZs9jYwoRBCIS3NCC4M6T5vN7FyK8Y+bLS/OKkLGExgrBqHU4fhNVmitORvK4R UtPNeVBTDCEPU0mRNjq/V8IVhttk1zayPNeq8g9K+GsmhzZ/qjRWqn5E3ZcVY9Qh1TKf 2B8Q== X-Gm-Message-State: AOAM533t8xAf0FWB5/iQES6UDM4x30nYb5OtQxsljhOvAdgCsbOMSTYa 8eObvK3sC5nB/UvcIm6OM5KtQep98pZjVboRCBs1gA== X-Google-Smtp-Source: ABdhPJwH4eJsS5OWHswwTu13j7X710JhXzRLOlQI2ycEssSzTXiSAu4QWPI8Qvq2bTeAc49+G5jFwYQxPfgwyoykqVY= X-Received: by 2002:a17:907:94cf:: with SMTP id dn15mr176599ejc.114.1600975139153; Thu, 24 Sep 2020 12:18:59 -0700 (PDT) MIME-Version: 1.0 References: <20200923232923.3142503-1-keescook@chromium.org> <20200924185702.GA9225@redhat.com> In-Reply-To: <20200924185702.GA9225@redhat.com> From: Jann Horn Date: Thu, 24 Sep 2020 21:18:32 +0200 Message-ID: Subject: Re: [PATCH v1 0/6] seccomp: Implement constant action bitmaps To: Andrea Arcangeli Cc: Kees Cook , YiFei Zhu , Christian Brauner , Tycho Andersen , Andy Lutomirski , Will Drewry , Giuseppe Scrivano , Tobin Feldman-Fitzthum , Dimitrios Skarlatos , Valentin Rothberg , Hubertus Franke , Jack Chen , Josep Torrellas , Tianyin Xu , bpf , Linux Containers , Linux API , kernel list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Thu, Sep 24, 2020 at 8:57 PM Andrea Arcangeli wrote: > > Hello, > > I'm posting this only for the record, feel free to ignore. > > On Wed, Sep 23, 2020 at 04:29:17PM -0700, Kees Cook wrote: > > rfc: https://lore.kernel.org/lkml/20200616074934.1600036-1-keescook@chromium.org/ > > alternative: https://lore.kernel.org/containers/cover.1600661418.git.yifeifz2@illinois.edu/ > > v1: > > - rebase to for-next/seccomp > > - finish X86_X32 support for both pinning and bitmaps > > It's pretty clear the O(1) seccomp filter bitmap was first was > proposed by your RFC in June (albeit it was located in the wrong place > and is still in the wrong place in v1). > > > - replace TLB magic with Jann's emulator > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > That's a pretty fundamental change in v1 compared to your the > non-competing TLB magic technique you used in the RFC last June. > > The bitmap isn't the clever part of the patch, the bitmap can be > reviewed in seconds, the difficult part to implement and to review is > how you fill the bitmap and in that respect there's absolutely nothing > in common in between the "rfc:" and the "alternative" link. > > In June your bitmap-filling engine was this: > > https://lore.kernel.org/lkml/20200616074934.1600036-5-keescook@chromium.org/ > > Then on Sep 21 YiFei Zhu posted his new innovative BPF emulation > innovation that obsoleted your TLB magic of June: > > https://lists.linuxfoundation.org/pipermail/containers/2020-September/042153.html > > And on Sep 23 instead of collaborating and helping YiFei Zhu to > improve his BPF emulator, you posted the same technique that looks > remarkably similar without giving YiFei Zhu any attribution and you > instead attribute the whole idea to Jann Horn: > > https://lkml.kernel.org/r/20200923232923.3142503-5-keescook@chromium.org You're missing that I did suggest the BPF emulation approach (with code very similar to Kees' current code) back in June: https://lore.kernel.org/lkml/CAG48ez1p=dR_2ikKq=xVxkoGg0fYpTBpkhJSv1w-6BG=76PAvw@mail.gmail.com/