bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Moore <paul@paul-moore.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: linux-audit@redhat.com, bpf@vger.kernel.org
Subject: Re: AUDIT_ARCH_ and __NR_syscall constants for seccomp filters
Date: Mon, 28 Jun 2021 13:34:20 -0400	[thread overview]
Message-ID: <CAHC9VhSrki+=724CSQbDdiiMnM8oXTmFP-XFnOmq28c03x1RQQ@mail.gmail.com> (raw)
In-Reply-To: <696bf938-c9d2-4b18-9f53-b6ff27035a97@t-8ch.de>

On Mon, Jun 28, 2021 at 1:13 PM Thomas Weißschuh <linux@weissschuh.net> wrote:
> Hi Paul,
> thanks for your response!

Hi :)

> On Mo, 2021-06-28T12:59-0400, Paul Moore wrote:
> > On Mon, Jun 28, 2021 at 9:25 AM Thomas Weißschuh <linux@weissschuh.net> wrote:
> > >
> > > Hi everyone,
> > >
> > > there does not seem to be a way to access the AUDIT_ARCH_ constant that matches
> > > the currently visible syscall numbers (__NR_...) from the kernel uapi headers.
> >
> > Looking at Linus' current tree I see the AUDIT_ARCH_* defines in
> > include/uapi/linux/audit.h; looking on my system right now I see the
> > defines in /usr/include/linux/audit.h.  What kernel repository and
> > distribution are you using?
> I am using ArchLinux and also have all these defines.
> > > Questions:
> > >
> > > Is it really necessary to validate the arch value when syscall numbers are
> > > already target-specific?
> > > (If not, should this be added to the docs?)
> >
> > Checking the arch/ABI value is important so that you can ensure that
> > you are using the syscall number in the proper context.  For example,
> > look at the access(2) syscall: it is undefined on some ABIs and can
> > take either a value of 20, 21, or 33 depending on the arch/ABI.
> > Unfortunately this is rather common.
> But when if I am not hardcoding the syscall numbers but use the
> __NR_access kernel define then I should always get the correct number for the
> ABI I am compiling for (or an error if the syscall does not exist), no?

Remember that seccomp filters are inherited across forks, so if your
application loads an ABI specific filter and then fork()/exec()'s an
application with a different ABI you could be in trouble.  We saw this
some years ago when people started running containers with ABIs other
than the native system; if the container orchestrator didn't load a
filter that knew about these non-native ABIs Bad Things happened.

I'm sure you are already aware of libseccomp, but if not you may want
to consider it for your application.  Not only does it provide a safe
and easy way to handle multiple ABIs in a single filter, it handles
other seccomp problem areas like build/runtime system differences in
the syscall tables/defines as well as the oddball nature of
direct-call and multiplexed socket related syscalls, i.e. socketcall()
vs socket(), etc.

> > Checking the arch/ABI value is also handy if you want to quickly
> > disallow certain ABIs on a system that supports multiple ABI, e.g.
> > disabling 32-bit x86 on a 64-bit x86_64 system.
> >
> > > Would it make sense to expose the audit arch matching the syscall numbers in
> > > the uapi headers?
> >
> > Yes, which is why the existing headers do so ;)  If you don't see the
> > header files I mentioned above, it may be worth checking your kernel
> > source repository and your distribution's installed kernel header
> > files.
> I do see constants for all the possible ABIs but not one constant that always
> represents the one I am currently compiling for.
> The same way the syscall number defines always give me the syscall number for
> the currently targeted ABI.

I'm sorry, but I don't quite understand what you are looking for in
the header files ... ?  It might help if you could provide a concrete
example of what you would like to see in the header files?

paul moore

  reply	other threads:[~2021-06-28 17:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28  7:31 Thomas Weißschuh
2021-06-28 16:59 ` Paul Moore
2021-06-28 17:13   ` Thomas Weißschuh
2021-06-28 17:34     ` Paul Moore [this message]
2021-06-28 17:58       ` Thomas Weißschuh
2021-06-28 22:43         ` Paul Moore
2021-06-29 10:40           ` Thomas Weißschuh
2021-06-29 23:41             ` Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHC9VhSrki+=724CSQbDdiiMnM8oXTmFP-XFnOmq28c03x1RQQ@mail.gmail.com' \
    --to=paul@paul-moore.com \
    --cc=bpf@vger.kernel.org \
    --cc=linux-audit@redhat.com \
    --cc=linux@weissschuh.net \
    --subject='Re: AUDIT_ARCH_ and __NR_syscall constants for seccomp filters' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).