From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDE4CC433DF for ; Wed, 20 May 2020 17:19:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C70842070A for ; Wed, 20 May 2020 17:19:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i+sEwVLC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbgETRTg (ORCPT ); Wed, 20 May 2020 13:19:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54640 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726548AbgETRTg (ORCPT ); Wed, 20 May 2020 13:19:36 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF942C061A0E; Wed, 20 May 2020 10:19:35 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id w64so3703969wmg.4; Wed, 20 May 2020 10:19:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=y8yUyVm1iQo/mod3v/ZorgdMr0NOkedItsaMzyWnI3k=; b=i+sEwVLCyBecdxxNGXrvdzLG4bFDyxadl2RsVH2OklScUeAFcJ9HmNEdo6usZqYSIy OkaJGdMvq5MGmNBCLM0I892EhrkWR0r8Kxht1UfRb9OvZISLphzQuvaYumVsGiPcbqBm Gko9HPAXaxEGlmID966izg0FhQP+H0i6UlLxnjlak/SrJAmpHHVCI5qTLon1Fc979Auy iuGWPuTyx04O+in+Y4Q5MqoqCS+YCMh8m+ublZtIdGJkN1vPnExkbAU72JA62MDvIezw Pz5GcZ6oYsSVF+gtV6TpuVYtqBT3no0m/zRGod5s+h8QUzQeSaKAPohpL/Y8YbnPy90U ndEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=y8yUyVm1iQo/mod3v/ZorgdMr0NOkedItsaMzyWnI3k=; b=ZEb7Ek3qFktgO1FMpjRMqyqkE+heAC54t35DNPqmPpnyyPaNwN839Xl2qqiy/nkNUU 5Y6XpXOlfWcTn8RdWHRvye9S4qLI3jEIYpB5q9FQq0vp8SmuvqvCWMWlWtzGbeqgE9XT C7kutdOow1p33VcL1a5jh1EtVaF+FM5zbtfARzNytq37kNkEKiFXaW/50m2Ma7ZTFRug PGhUFPvfOIG0fGAlXQ/6Vu0Nl2scNdn59AoI2W+9Z+NT+TRwdSSmHC44Zhc0nX9nu10e fwXpDVIJq8Qta9/QHpihCpxPmzkuuAtAe8qnJeWY30mvdvF2kpHTr0CtqpE/z1ePzA3F iueQ== X-Gm-Message-State: AOAM533l3nwDyu4iJLzE0JPqsOx00wHx3P0jgkAiNEDuJ0xdDDyNNiLn cj9Qetz7hhoU4wmtg4qeU5YFxB48pqTIU0rdo+E= X-Google-Smtp-Source: ABdhPJyHqLx5nZUFccD6mBIJZ0Sj6jqebi2SOcGJxSylM31RSSLDJaUMgq5UtSHHT/NBLm7NS0684QV+bsyGj9eIhLY= X-Received: by 2002:a1c:3281:: with SMTP id y123mr5449288wmy.30.1589995174436; Wed, 20 May 2020 10:19:34 -0700 (PDT) MIME-Version: 1.0 References: <20200520094742.337678-1-bjorn.topel@gmail.com> <20200520094742.337678-8-bjorn.topel@gmail.com> <20200520100218.56e4ee2c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20200520100218.56e4ee2c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Wed, 20 May 2020 19:19:22 +0200 Message-ID: Subject: Re: [PATCH bpf-next v4 07/15] i40e: separate kernel allocated rx_bi rings from AF_XDP rings To: Jakub Kicinski Cc: Alexei Starovoitov , Daniel Borkmann , David Miller , Jesper Dangaard Brouer , John Fastabend , Netdev , bpf , "Karlsson, Magnus" , Jonathan Lemon , Jeff Kirsher , =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= , Maxim Mikityanskiy , "Fijalkowski, Maciej" , intel-wired-lan Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, 20 May 2020 at 19:02, Jakub Kicinski wrote: > > On Wed, 20 May 2020 11:47:34 +0200 Bj=C3=B6rn T=C3=B6pel wrote: > > From: Bj=C3=B6rn T=C3=B6pel > > > > Continuing the path to support MEM_TYPE_XSK_BUFF_POOL, the AF_XDP > > zero-copy/sk_buff rx_bi rings are now separate. Functions to properly > > allocate the different rings are added as well. > > > > v3->v4: Made i40e_fd_handle_status() static. (kbuild test robot) > > > > Cc: intel-wired-lan@lists.osuosl.org > > Signed-off-by: Bj=C3=B6rn T=C3=B6pel > > There is a new warning here, at least one. But i40e has so many > existing warnings with W=3D1, I can't figure out which one is new :( > > You most likely forgot to adjust kdoc somewhere after adding or > removing a function parameter. Hmm, yes. A lot of warnings there. I'll see if I can find it. Thanks!