From: "Björn Töpel" <bjorn.topel@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"David Miller" <davem@davemloft.net>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"John Fastabend" <john.fastabend@gmail.com>,
Netdev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Jeff Kirsher" <jeffrey.t.kirsher@intel.com>,
"Maxim Mikityanskiy" <maximmi@mellanox.com>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"Björn Töpel" <bjorn.topel@intel.com>
Subject: Re: [PATCH bpf-next v4 03/15] xsk: move driver interface to xdp_sock_drv.h
Date: Wed, 20 May 2020 19:18:49 +0200 [thread overview]
Message-ID: <CAJ+HfNgxH0xLUvm=MPpF-VhoGLPYF2=gJMAw3VkmduO2SJhy=Q@mail.gmail.com> (raw)
In-Reply-To: <20200520095743.0d6dda04@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Wed, 20 May 2020 at 18:57, Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Wed, 20 May 2020 11:47:30 +0200 Björn Töpel wrote:
> > From: Magnus Karlsson <magnus.karlsson@intel.com>
> >
> > Move the AF_XDP zero-copy driver interface to its own include file
> > called xdp_sock_drv.h. This, hopefully, will make it more clear for
> > NIC driver implementors to know what functions to use for zero-copy
> > support.
> >
> > Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
>
> With W=1:
>
> net/xdp/xsk_queue.c:67:26: warning: symbol 'xsk_reuseq_prepare' was not declared. Should it be static?
> net/xdp/xsk_queue.c:86:26: warning: symbol 'xsk_reuseq_swap' was not declared. Should it be static?
> net/xdp/xsk_queue.c:108:6: warning: symbol 'xsk_reuseq_free' was not declared. Should it be static?
> net/xdp/xsk_queue.c:67:27: warning: no previous prototype for xsk_reuseq_prepare [-Wmissing-prototypes]
> 67 | struct xdp_umem_fq_reuse *xsk_reuseq_prepare(u32 nentries)
> | ^~~~~~~~~~~~~~~~~~
> net/xdp/xsk_queue.c:86:27: warning: no previous prototype for xsk_reuseq_swap [-Wmissing-prototypes]
> 86 | struct xdp_umem_fq_reuse *xsk_reuseq_swap(struct xdp_umem *umem,
> | ^~~~~~~~~~~~~~~
> net/xdp/xsk_queue.c:108:6: warning: no previous prototype for xsk_reuseq_free [-Wmissing-prototypes]
> 108 | void xsk_reuseq_free(struct xdp_umem_fq_reuse *rq)
> | ^~~~~~~~~~~~~~~
Yes, missing include there. After the series these functions are
removed, but still good to get rid of the (bisect) noise.
I'll fix this in a v5. Thanks, Jakub!
Björn
next prev parent reply other threads:[~2020-05-20 17:19 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 9:47 [PATCH bpf-next v4 00/15] Introduce AF_XDP buffer allocation API Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 01/15] xsk: fix xsk_umem_xdp_frame_sz() Björn Töpel
2020-05-20 13:18 ` Jesper Dangaard Brouer
2020-05-20 14:34 ` Björn Töpel
2020-05-21 4:29 ` Jesper Dangaard Brouer
2020-05-21 18:06 ` Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 02/15] xsk: move xskmap.c to net/xdp/ Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 03/15] xsk: move driver interface to xdp_sock_drv.h Björn Töpel
2020-05-20 16:57 ` Jakub Kicinski
2020-05-20 17:18 ` Björn Töpel [this message]
2020-05-20 9:47 ` [PATCH bpf-next v4 04/15] xsk: move defines only used by AF_XDP internals to xsk.h Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 05/15] xsk: introduce AF_XDP buffer allocation API Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 06/15] i40e: refactor rx_bi accesses Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 07/15] i40e: separate kernel allocated rx_bi rings from AF_XDP rings Björn Töpel
2020-05-20 17:02 ` Jakub Kicinski
2020-05-20 17:19 ` Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 08/15] i40e, xsk: migrate to new MEM_TYPE_XSK_BUFF_POOL Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 09/15] ice, " Björn Töpel
2020-05-20 17:03 ` Jakub Kicinski
2020-05-20 17:20 ` Björn Töpel
2020-05-20 18:49 ` Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 10/15] ixgbe, " Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 11/15] mlx5, " Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 12/15] xsk: remove MEM_TYPE_ZERO_COPY and corresponding code Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 13/15] xdp: simplify xdp_return_{frame,frame_rx_napi,buff} Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 14/15] xsk: explicitly inline functions and move definitions Björn Töpel
2020-05-20 9:47 ` [PATCH bpf-next v4 15/15] MAINTAINERS, xsk: update AF_XDP section after moves/adds Björn Töpel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ+HfNgxH0xLUvm=MPpF-VhoGLPYF2=gJMAw3VkmduO2SJhy=Q@mail.gmail.com' \
--to=bjorn.topel@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=john.fastabend@gmail.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).