From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8DC0C43603 for ; Wed, 18 Dec 2019 12:18:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A94022072B for ; Wed, 18 Dec 2019 12:18:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HD9orLfv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726824AbfLRMSX (ORCPT ); Wed, 18 Dec 2019 07:18:23 -0500 Received: from mail-qt1-f193.google.com ([209.85.160.193]:38186 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbfLRMSW (ORCPT ); Wed, 18 Dec 2019 07:18:22 -0500 Received: by mail-qt1-f193.google.com with SMTP id n15so1772913qtp.5; Wed, 18 Dec 2019 04:18:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=9SbLIPt1twIa7fqW6yKEFytGs3p1PVhXbihgXlQIz9I=; b=HD9orLfvlNLujZcNgZV1JgDHpZALJi51J2pd4nhdAvHiJ7UAeEq4/5IyjKwxBuNr7L bqiQQAheBHxqHohf5ES2l1fd0Wqg4YQQbOp1RgJvqy8iA3F94j9m6x18Mt1tUVtMZ4nx YoV4xk8ObWwnrrnJ927nViIABVhJ8lim85Q4moYXDVEgBBecoiv7G6E/QCf6wXbGDCmA hBynUcMUq55E+W71nmWfXWmc9U7l18lwxxSi+Hb6woxzPvfEDaqaGq59nPrAI5KMDS5n vX7jYnZySvnAlv3J8q7quVcqeUm1Hs4NPSbogyS/Sj26Am7R8mbsVLoehcsibSunfuuE hDUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9SbLIPt1twIa7fqW6yKEFytGs3p1PVhXbihgXlQIz9I=; b=uPeRN1nLVU0bxzNrjLsGGW0RB/tX6aJlBzI5OLpnAmRR5NvA4oCJJzpRfgrdspGxOF ffu0soIMJaAq9FXaRFR0UCLT2cdy23yN3+/01Zjhj9EOPUWzQZ1NIEdf6Lbu+qnzmaqz BxtwwiZHHxwfxDkrGtVJwc2yZWyg/gS5uWnHaLxTOT2hFDECHqmItA5ne2inwe6cSVT4 IgnOOGe/1omObRB1DdCIZ69JgXL2L+685OPnFl8t9IE/EG2fn9Q86NijBBBSEpuT+3m1 QV+AR3fnP6mRRRuE3bX7bixy5scqnXM+x1h9TrsovaoQlTCQZyGA/5pF9s0rFmcE8iR6 NEFw== X-Gm-Message-State: APjAAAX/kqK5BIp0rKC4nHDuYyunypH272EOSXWa3CuzxJiu1JX9Faes FnRHvK1/0Z5lF5TlmZ2eYWjSyE41OAxnMEnIanQ= X-Google-Smtp-Source: APXvYqz38eqyQGWWg2kdaURmi27j+qBIQ3C6EWLj+kuOdaC5r9YMIinNVBg6dVfd5o8YHUvSq4qI43G12joKR9eT8/w= X-Received: by 2002:ac8:34b5:: with SMTP id w50mr1874307qtb.107.1576671501245; Wed, 18 Dec 2019 04:18:21 -0800 (PST) MIME-Version: 1.0 References: <20191218105400.2895-1-bjorn.topel@gmail.com> <20191218121132.4023f4f1@carbon> <20191218130346.1a346606@carbon> In-Reply-To: <20191218130346.1a346606@carbon> From: =?UTF-8?B?QmrDtnJuIFTDtnBlbA==?= Date: Wed, 18 Dec 2019 13:18:10 +0100 Message-ID: Subject: Re: [PATCH bpf-next 0/8] Simplify xdp_do_redirect_map()/xdp_do_flush_map() and XDP maps To: Jesper Dangaard Brouer Cc: Netdev , Alexei Starovoitov , Daniel Borkmann , bpf , David Miller , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , "Karlsson, Magnus" , Jonathan Lemon , Maciej Fijalkowski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: bpf-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org On Wed, 18 Dec 2019 at 13:04, Jesper Dangaard Brouer wr= ote: > > On Wed, 18 Dec 2019 12:39:53 +0100 > Bj=C3=B6rn T=C3=B6pel wrote: > > > On Wed, 18 Dec 2019 at 12:11, Jesper Dangaard Brouer wrote: > > > > > > On Wed, 18 Dec 2019 11:53:52 +0100 > > > Bj=C3=B6rn T=C3=B6pel wrote: > > > > > > > $ sudo ./xdp_redirect_cpu --dev enp134s0f0 --cpu 22 xdp_cpu_map0 > > > > > > > > Running XDP/eBPF prog_name:xdp_cpu_map5_lb_hash_ip_pairs > > > > XDP-cpumap CPU:to pps drop-pps extra-info > > > > XDP-RX 20 7723038 0 0 > > > > XDP-RX total 7723038 0 > > > > cpumap_kthread total 0 0 0 > > > > redirect_err total 0 0 > > > > xdp_exception total 0 0 > > > > > > Hmm... I'm missing some counters on the kthread side. > > > > > > > Oh? Any ideas why? I just ran the upstream sample straight off. > > Looks like it happened in commit: bbaf6029c49c ("samples/bpf: Convert > XDP samples to libbpf usage") (Cc Maciej). > > The old bpf_load.c will auto attach the tracepoints... for and libbpf > you have to be explicit about it. > > Can I ask you to also run a test with --stress-mode for > ./xdp_redirect_cpu, to flush out any potential RCU race-conditions > (don't provide output, this is just a robustness test). > Sure! Other than that, does the command line above make sense? I'm blasting UDP packets to core 20, and the idea was to re-route them to 22. Bj=C3=B6rn