bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Björn Töpel" <bjorn.topel@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: "Masahiro Yamada" <yamada.masahiro@socionext.com>,
	"Ivan Khoronzhuk" <ivan.khoronzhuk@linaro.org>,
	Networking <netdev@vger.kernel.org>,
	"Alexei Starovoitov" <ast@kernel.org>,
	"Daniel Borkmann" <daniel@iogearbox.net>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Linux Kbuild mailing list" <linux-kbuild@vger.kernel.org>,
	bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig
Date: Thu, 3 Oct 2019 19:37:51 +0200	[thread overview]
Message-ID: <CAJ+HfNi1cTvCxcgjU4r03eJt_mc7L4Zwn7vfgWHAPWyjH0q4Bw@mail.gmail.com> (raw)
In-Reply-To: <CAEf4BzbZxa3iGZEWB03rdL+7ErmhdpB0e3aeOQvbLPu0o8XFqw@mail.gmail.com>

On Thu, 3 Oct 2019 at 19:16, Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote:
>
> On Thu, Oct 3, 2019 at 3:52 AM Björn Töpel <bjorn.topel@gmail.com> wrote:
> >
> > On Thu, 3 Oct 2019 at 12:37, Masahiro Yamada
> > <yamada.masahiro@socionext.com> wrote:
> > >
> > > On Thu, Oct 3, 2019 at 3:28 PM Björn Töpel <bjorn.topel@gmail.com> wrote:
> > > >
> > > > On Thu, 3 Oct 2019 at 01:14, Ivan Khoronzhuk <ivan.khoronzhuk@linaro.org> wrote:
> > > > >
> > > > > On Wed, Oct 02, 2019 at 09:41:15AM +0200, Björn Töpel wrote:
> > > > > >On Wed, 2 Oct 2019 at 03:49, Masahiro Yamada
> > > > > ><yamada.masahiro@socionext.com> wrote:
> > > > > >>
> > > > > >[...]
> > > > > >> > Yes, the BPF samples require clang/LLVM with BPF support to build. Any
> > > > > >> > suggestion on a good way to address this (missing tools), better than
> > > > > >> > the warning above? After the commit 394053f4a4b3 ("kbuild: make single
> > > > > >> > targets work more correctly"), it's no longer possible to build
> > > > > >> > samples/bpf without support in the samples/Makefile.
> > > > > >>
> > > > > >>
> > > > > >> You can with
> > > > > >>
> > > > > >> "make M=samples/bpf"
> > > > > >>
> > > > > >
> > > > > >Oh, I didn't know that. Does M= support "output" builds (O=)?
> > >
> > > No.
> > > O= points to the output directory of vmlinux,
> > > not of the external module.
> > >
> > > You cannot put the build artifacts from samples/bpf/
> > > in a separate directory.
> > >
> >
> > Hmm, I can't even get "make M=samples/bpf/" to build. Am I missing
> > something obvious?
>
> There were 3 or 4 separate fixes submitted for samples/bpf yesterday,
> maybe you are hitting some of those issues. Try to pull latest (not
> sure if bpf or bpf-next tree). I tried make M=samples/bpf and it
> worked for me.
>

Yeah, it was PEBKAC. "make M=samples/bpf" works if you have a proper
.config + "make prepare" ;-)

I guess I need to change my workflow. I build all my kernels "O=", and
did so with samples/bpf as well. Everything ended up in the same
output directory. Now I need to have all this build output in source
tree, and need to manage the .config files in where the source is at.
Oh well... I'll stop complaining now. :-)

Thanks,
Björn

> >
> > Prior 394053f4a4b3 "make samples/bpf/" and "make O=/foo/bar
> > samples/bpf/" worked, but I guess I can live with that...
> >
> >
> > Thanks!
> > Björn
> >
> >
> > >
> > >
> > > > > >I usually just build samples/bpf/ with:
> > > > > >
> > > > > >  $ make V=1 O=/home/foo/build/bleh samples/bpf/
> > > > > >
> > > > > >
> > > > > >Björn
> > > > >
> > > > > Shouldn't README be updated?
> > > > >
> > > >
> > > > Hmm, the M= variant doesn't work at all for me. The build is still
> > > > broken for me. Maybe I'm missing anything obvious...
> > > >
> > > >
> > > > > --
> > > > > Regards,
> > > > > Ivan Khoronzhuk
> > >
> > >
> > >
> > > --
> > > Best Regards
> > > Masahiro Yamada

      reply	other threads:[~2019-10-03 17:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 10:14 [PATCH bpf] samples/bpf: kbuild: add CONFIG_SAMPLE_BPF Kconfig Björn Töpel
2019-10-01 10:17 ` Björn Töpel
2019-10-01 12:33 ` Masahiro Yamada
2019-10-01 14:16   ` Björn Töpel
2019-10-02  1:48     ` Masahiro Yamada
2019-10-02  7:41       ` Björn Töpel
2019-10-02 23:14         ` Ivan Khoronzhuk
2019-10-03  6:28           ` Björn Töpel
2019-10-03 10:36             ` Masahiro Yamada
2019-10-03 10:50               ` Björn Töpel
2019-10-03 17:16                 ` Andrii Nakryiko
2019-10-03 17:37                   ` Björn Töpel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJ+HfNi1cTvCxcgjU4r03eJt_mc7L4Zwn7vfgWHAPWyjH0q4Bw@mail.gmail.com \
    --to=bjorn.topel@gmail.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=ast@kernel.org \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=ivan.khoronzhuk@linaro.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).