From: "Björn Töpel" <bjorn.topel@gmail.com>
To: Jiong Wang <jiong.wang@netronome.com>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
Y Song <ys114321@gmail.com>, Alexei Starovoitov <ast@kernel.org>,
netdev <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>
Subject: Re: [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor
Date: Thu, 23 May 2019 18:05:22 +0200 [thread overview]
Message-ID: <CAJ+HfNj_ZBqdwoWh7w4M3mUm_vPUwJ2QBWpyKCSSvk7e8xKz6w@mail.gmail.com> (raw)
In-Reply-To: <3ED3A4F8-CC01-4179-9154-6FC5338E83B5@netronome.com>
On Thu, 23 May 2019 at 16:31, Jiong Wang <jiong.wang@netronome.com> wrote:
>
>
> > On 23 May 2019, at 15:02, Daniel Borkmann <daniel@iogearbox.net> wrote:
> >
> > On 05/23/2019 08:38 AM, Y Song wrote:
> >> On Wed, May 22, 2019 at 1:46 PM Björn Töpel <bjorn.topel@gmail.com> wrote:
> >>> On Wed, 22 May 2019 at 20:13, Y Song <ys114321@gmail.com> wrote:
> >>>> On Wed, May 22, 2019 at 2:25 AM Björn Töpel <bjorn.topel@gmail.com> wrote:
> >>>>>
> >>>>> Add three tests to test_verifier/basic_instr that make sure that the
> >>>>> high 32-bits of the destination register is cleared after an ALU32
> >>>>> and/or/xor.
> >>>>>
> >>>>> Signed-off-by: Björn Töpel <bjorn.topel@gmail.com>
> >>>>
> >>>> I think the patch intends for bpf-next, right? The patch itself looks
> >>>> good to me.
> >>>> Acked-by: Yonghong Song <yhs@fb.com>
> >>>
> >>> Thank you. Actually, it was intended for the bpf tree, as a test
> >>> follow up for this [1] fix.
> >> Then maybe you want to add a Fixes tag and resubmit?
> >
> > Why would the test case need a fixes tag? It's common practice that we have
> > BPF fixes that we queue to bpf tree along with kselftest test cases related
> > to them. Therefore, applied as well, thanks for following up!
> >
> > Björn, in my email from the fix, I mentioned we should have test snippets
> > ideally for all of the alu32 insns to not miss something falling through the
> > cracks when JITs get added or changed. If you have some cycles to add the
> > remaining missing ones, that would be much appreciated.
>
> Björn,
>
> If you don’t have time, I can take this alu32 test case follow up as well.
>
Jiong, that would be great. Thank you. I'd guess it would take much
longer for me to do it (gmail.com time vs intel.com time ;-)).
Björn
> Regards,
> Jiong
>
> >
> > Thanks,
> > Daniel
>
prev parent reply other threads:[~2019-05-23 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 9:23 [PATCH bpf] selftests: bpf: add zero extend checks for ALU32 and/or/xor Björn Töpel
2019-05-22 18:13 ` Y Song
2019-05-22 20:46 ` Björn Töpel
2019-05-23 6:38 ` Y Song
2019-05-23 7:48 ` Björn Töpel
2019-05-23 14:02 ` Daniel Borkmann
2019-05-23 14:31 ` Jiong Wang
2019-05-23 16:05 ` Björn Töpel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ+HfNj_ZBqdwoWh7w4M3mUm_vPUwJ2QBWpyKCSSvk7e8xKz6w@mail.gmail.com \
--to=bjorn.topel@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jiong.wang@netronome.com \
--cc=netdev@vger.kernel.org \
--cc=ys114321@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).