From: Magnus Karlsson <magnus.karlsson@gmail.com>
To: Li RongQing <lirongqing@baidu.com>
Cc: Network Development <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>
Subject: Re: [PATCH][V2] libbpf: add support for canceling cached_cons advance
Date: Tue, 24 Nov 2020 09:12:46 +0100 [thread overview]
Message-ID: <CAJ8uoz0WNm6no8NRehgUH5RiGgvjJkKeD-Yyoah8xJerpLhgdg@mail.gmail.com> (raw)
In-Reply-To: <1606202474-8119-1-git-send-email-lirongqing@baidu.com>
On Tue, Nov 24, 2020 at 8:33 AM Li RongQing <lirongqing@baidu.com> wrote:
>
> Add a new function for returning descriptors the user received
> after an xsk_ring_cons__peek call. After the application has
> gotten a number of descriptors from a ring, it might not be able
> to or want to process them all for various reasons. Therefore,
> it would be useful to have an interface for returning or
> cancelling a number of them so that they are returned to the ring.
>
> This patch adds a new function called xsk_ring_cons__cancel that
> performs this operation on nb descriptors counted from the end of
> the batch of descriptors that was received through the peek call.
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> [ Magnus Karlsson: rewrote changelog ]
> Cc: Magnus Karlsson <magnus.karlsson@intel.com>
> ---
> diff with v1: fix the building, and rewrote changelog
>
> tools/lib/bpf/xsk.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/lib/bpf/xsk.h b/tools/lib/bpf/xsk.h
> index 1069c46364ff..1719a327e5f9 100644
> --- a/tools/lib/bpf/xsk.h
> +++ b/tools/lib/bpf/xsk.h
> @@ -153,6 +153,12 @@ static inline size_t xsk_ring_cons__peek(struct xsk_ring_cons *cons,
> return entries;
> }
>
> +static inline void xsk_ring_cons__cancel(struct xsk_ring_cons *cons,
> + size_t nb)
> +{
> + cons->cached_cons -= nb;
> +}
> +
> static inline void xsk_ring_cons__release(struct xsk_ring_cons *cons, size_t nb)
> {
> /* Make sure data has been read before indicating we are done
> --
> 2.17.3
Thank you RongQing.
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
next prev parent reply other threads:[~2020-11-24 8:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 7:21 [PATCH][V2] libbpf: add support for canceling cached_cons advance Li RongQing
2020-11-24 8:12 ` Magnus Karlsson [this message]
2020-11-24 21:58 ` Daniel Borkmann
2020-11-25 8:30 ` Magnus Karlsson
2020-11-25 9:02 ` Daniel Borkmann
2020-11-25 9:13 ` Magnus Karlsson
2020-11-25 10:06 ` Daniel Borkmann
2020-11-25 10:09 ` Magnus Karlsson
2020-11-25 12:22 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJ8uoz0WNm6no8NRehgUH5RiGgvjJkKeD-Yyoah8xJerpLhgdg@mail.gmail.com \
--to=magnus.karlsson@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).