From: Magnus Karlsson <magnus.karlsson@gmail.com>
To: "Björn Töpel" <bjorn.topel@gmail.com>
Cc: "Network Development" <netdev@vger.kernel.org>,
bpf <bpf@vger.kernel.org>, "Björn Töpel" <bjorn.topel@intel.com>,
"Karlsson, Magnus" <magnus.karlsson@intel.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Fijalkowski, Maciej" <maciej.fijalkowski@intel.com>,
"Samudrala, Sridhar" <sridhar.samudrala@intel.com>,
"Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
"Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Jonathan Lemon" <jonathan.lemon@gmail.com>,
"Maxim Mikityanskiy" <maximmi@nvidia.com>
Subject: Re: [PATCH bpf-next v3 04/10] xsk: check need wakeup flag in sendmsg()
Date: Wed, 25 Nov 2020 08:16:11 +0100 [thread overview]
Message-ID: <CAJ8uoz31U=WprbtgGhrGqzuC5-TswsKEtOhfk1NFnBS6fz53Bg@mail.gmail.com> (raw)
In-Reply-To: <20201119083024.119566-5-bjorn.topel@gmail.com>
On Thu, Nov 19, 2020 at 9:33 AM Björn Töpel <bjorn.topel@gmail.com> wrote:
>
> From: Björn Töpel <bjorn.topel@intel.com>
>
> Add a check for need wake up in sendmsg(), so that if a user calls
> sendmsg() when no wakeup is needed, do not trigger a wakeup.
>
> To simplify the need wakeup check in the syscall, unconditionally
> enable the need wakeup flag for Tx. This has a side-effect for poll();
> If poll() is called for a socket without enabled need wakeup, a Tx
> wakeup is unconditionally performed.
>
> The wakeup matrix for AF_XDP now looks like:
>
> need wakeup | poll() | sendmsg() | recvmsg()
> ------------+--------------+-------------+------------
> disabled | wake Tx | wake Tx | nop
> enabled | check flag; | check flag; | check flag;
> | wake Tx/Rx | wake Tx | wake Rx
>
> Signed-off-by: Björn Töpel <bjorn.topel@intel.com>
> ---
> net/xdp/xsk.c | 6 +++++-
> net/xdp/xsk_buff_pool.c | 13 ++++++-------
> 2 files changed, 11 insertions(+), 8 deletions(-)
Acked-by: Magnus Karlsson <magnus.karlsson@intel.com>
> diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c
> index 56a52ec75696..bf0f5c34af6c 100644
> --- a/net/xdp/xsk.c
> +++ b/net/xdp/xsk.c
> @@ -522,13 +522,17 @@ static int xsk_sendmsg(struct socket *sock, struct msghdr *m, size_t total_len)
> bool need_wait = !(m->msg_flags & MSG_DONTWAIT);
> struct sock *sk = sock->sk;
> struct xdp_sock *xs = xdp_sk(sk);
> + struct xsk_buff_pool *pool;
>
> if (unlikely(!xsk_is_bound(xs)))
> return -ENXIO;
> if (unlikely(need_wait))
> return -EOPNOTSUPP;
>
> - return __xsk_sendmsg(sk);
> + pool = xs->pool;
> + if (pool->cached_need_wakeup & XDP_WAKEUP_TX)
> + return __xsk_sendmsg(sk);
> + return 0;
> }
>
> static int xsk_recvmsg(struct socket *sock, struct msghdr *m, size_t len, int flags)
> diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c
> index 8a3bf4e1318e..96bb607853ad 100644
> --- a/net/xdp/xsk_buff_pool.c
> +++ b/net/xdp/xsk_buff_pool.c
> @@ -144,14 +144,13 @@ static int __xp_assign_dev(struct xsk_buff_pool *pool,
> if (err)
> return err;
>
> - if (flags & XDP_USE_NEED_WAKEUP) {
> + if (flags & XDP_USE_NEED_WAKEUP)
> pool->uses_need_wakeup = true;
> - /* Tx needs to be explicitly woken up the first time.
> - * Also for supporting drivers that do not implement this
> - * feature. They will always have to call sendto().
> - */
> - pool->cached_need_wakeup = XDP_WAKEUP_TX;
> - }
> + /* Tx needs to be explicitly woken up the first time. Also
> + * for supporting drivers that do not implement this
> + * feature. They will always have to call sendto() or poll().
> + */
> + pool->cached_need_wakeup = XDP_WAKEUP_TX;
>
> dev_hold(netdev);
>
> --
> 2.27.0
>
next prev parent reply other threads:[~2020-11-25 7:16 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 8:30 [PATCH bpf-next v3 00/10] Introduce preferred busy-polling Björn Töpel
2020-11-19 8:30 ` [PATCH bpf-next v3 01/10] net: introduce " Björn Töpel
2020-11-24 0:04 ` Jakub Kicinski
2020-11-24 7:58 ` Björn Töpel
2020-11-24 0:11 ` Jakub Kicinski
2020-11-24 8:47 ` Björn Töpel
2020-11-24 16:21 ` Jakub Kicinski
2020-11-19 8:30 ` [PATCH bpf-next v3 02/10] net: add SO_BUSY_POLL_BUDGET socket option Björn Töpel
2020-11-24 16:21 ` Jakub Kicinski
2020-11-19 8:30 ` [PATCH bpf-next v3 03/10] xsk: add support for recvmsg() Björn Töpel
2020-11-25 6:55 ` Magnus Karlsson
2020-11-19 8:30 ` [PATCH bpf-next v3 04/10] xsk: check need wakeup flag in sendmsg() Björn Töpel
2020-11-25 7:16 ` Magnus Karlsson [this message]
2020-11-19 8:30 ` [PATCH bpf-next v3 05/10] xsk: add busy-poll support for {recv,send}msg() Björn Töpel
2020-11-25 7:58 ` Magnus Karlsson
2020-11-19 8:30 ` [PATCH bpf-next v3 06/10] xsk: propagate napi_id to XDP socket Rx path Björn Töpel
2020-11-25 14:47 ` Magnus Karlsson
2020-11-25 21:14 ` Michael S. Tsirkin
2021-09-29 18:33 ` kernel test robot
2021-09-30 6:04 ` Magnus Karlsson
2021-10-02 2:07 ` [kbuild-all] " Philip Li
2021-11-05 20:17 ` kernel test robot
2020-11-19 8:30 ` [PATCH bpf-next v3 07/10] samples/bpf: use recvfrom() in xdpsock/rxdrop Björn Töpel
2020-11-25 7:59 ` Magnus Karlsson
2020-11-19 8:30 ` [PATCH bpf-next v3 08/10] samples/bpf: use recvfrom() in xdpsock/l2fwd Björn Töpel
2020-11-25 8:00 ` Magnus Karlsson
2020-11-19 8:30 ` [PATCH bpf-next v3 09/10] samples/bpf: add busy-poll support to xdpsock Björn Töpel
2020-11-25 8:19 ` Magnus Karlsson
2020-11-19 8:30 ` [PATCH bpf-next v3 10/10] samples/bpf: add option to set the busy-poll budget Björn Töpel
2020-11-25 8:23 ` Magnus Karlsson
2020-11-23 13:31 ` [PATCH bpf-next v3 00/10] Introduce preferred busy-polling Björn Töpel
2020-11-23 23:54 ` Jakub Kicinski
2020-11-24 0:14 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ8uoz31U=WprbtgGhrGqzuC5-TswsKEtOhfk1NFnBS6fz53Bg@mail.gmail.com' \
--to=magnus.karlsson@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=edumazet@google.com \
--cc=jesse.brandeburg@intel.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=qi.z.zhang@intel.com \
--cc=sridhar.samudrala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).