From: Joanne Koong <joannelkoong@gmail.com>
To: Martin KaFai Lau <kafai@fb.com>
Cc: bpf@vger.kernel.org, andrii@kernel.org, daniel@iogearbox.net,
ast@kernel.org, memxor@gmail.com, toke@redhat.com,
kuba@kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v5 1/3] bpf: Add skb dynptrs
Date: Thu, 1 Sep 2022 14:58:59 -0700 [thread overview]
Message-ID: <CAJnrk1ZiYWu1R+mK5_OCZRBGLPx+_bE-fon30zDwSmrcxAxZQQ@mail.gmail.com> (raw)
In-Reply-To: <20220901195917.2ho5g5hqsaidzadd@kafai-mbp.dhcp.thefacebook.com>
On Thu, Sep 1, 2022 at 12:59 PM Martin KaFai Lau <kafai@fb.com> wrote:
>
> On Wed, Aug 31, 2022 at 11:32:22AM -0700, Joanne Koong wrote:
> > +#ifdef CONFIG_NET
> > +int __bpf_skb_load_bytes(const struct sk_buff *skb, u32 offset, void *to, u32 len);
> > +int __bpf_skb_store_bytes(struct sk_buff *skb, u32 offset, const void *from,
> > + u32 len, u64 flags);
> > +#else /* CONFIG_NET */
> > +int __bpf_skb_load_bytes(const struct sk_buff *skb, u32 offset, void *to, u32 len)
> static inline
>
> This should address the build issue reported by the test bot.
Awesome, I will add this in for v6. Thanks!
>
> > +{
> > + return -EOPNOTSUPP;
> > +}
> > +
> > +int __bpf_skb_store_bytes(struct sk_buff *skb, u32 offset, const void *from,
> > + u32 len, u64 flags)
> Same here.
>
> > +{
> > + return -EOPNOTSUPP;
> > +}
> > +#endif /* CONFIG_NET */
next prev parent reply other threads:[~2022-09-01 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-31 18:32 [PATCH bpf-next v5 0/3] Add skb + xdp dynptrs Joanne Koong
2022-08-31 18:32 ` [PATCH bpf-next v5 1/3] bpf: Add skb dynptrs Joanne Koong
2022-09-01 1:27 ` kernel test robot
2022-09-01 1:58 ` kernel test robot
2022-09-01 19:59 ` Martin KaFai Lau
2022-09-01 21:58 ` Joanne Koong [this message]
2022-08-31 18:32 ` [PATCH bpf-next v5 2/3] bpf: Add xdp dynptrs Joanne Koong
2022-08-31 18:32 ` [PATCH bpf-next v5 3/3] selftests/bpf: tests for using dynptrs to parse skb and xdp buffers Joanne Koong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJnrk1ZiYWu1R+mK5_OCZRBGLPx+_bE-fon30zDwSmrcxAxZQQ@mail.gmail.com \
--to=joannelkoong@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).